Blink CachePolicy migration |
|||||||||
Issue descriptionThis is a sub task of crbug.com/599364 . There were three cache policy enums, and two of them were already merged. Another policy that wasn't merged is for memory cache, and the other merged policy is for cache. In code review, there is a proposal that we just remove a dedicated policy for the memory cache, but have one policy. This probably makes code simple and clean, but I may need some investigation separately.
,
Apr 13 2016
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7 commit e5aaf6a00745888f8fb79c8eec9b01d53f6436c7 Author: toyoshim <toyoshim@chromium.org> Date: Wed May 18 08:07:48 2016 Add content_browsertests for testing cache control flags Now Blink inserts "Cache-Control: max-age=0" header for resource revalidation. But we also use WebCachePolicy::ValidatingCacheData in such cases so that //net uses "max-age=0". So we can safely remove this insertion from Blink, and it would help to avoid unexpected cache control flag mismatches. Before making actual changes, submit some content_browsertests that check cache control flags to avoid unexpected breakages. These tests will be useful for other changes, e.g. pull-to-refresh new behavior, and so on. BUG= 602900 , 558829 TEST=content_browsertests --gtest_filter='ReloadCacheControlBrowserTest.*' NOTRY=true # to skip unrelated failure on win_chromium_compile_dbg_ng Review-Url: https://codereview.chromium.org/1905873002 Cr-Commit-Position: refs/heads/master@{#394356} [add] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/content/browser/loader/reload_cache_control_browsertest.cc [modify] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/content/content_tests.gypi [modify] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/content/public/test/content_browser_test_utils.cc [modify] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/content/public/test/content_browser_test_utils.h [modify] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/content/shell/browser/shell.cc [modify] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/content/shell/browser/shell.h [add] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/content/test/data/loader/empty16x16.png [add] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/content/test/data/loader/reload.html [modify] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/net/test/embedded_test_server/embedded_test_server.cc [modify] https://crrev.com/e5aaf6a00745888f8fb79c8eec9b01d53f6436c7/net/test/embedded_test_server/embedded_test_server.h
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 14 2016
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 27 2017
Considering removing CachePolicy in fetch and use WebCachePolicy for all https://docs.google.com/document/d/1qwrDesORn_1sGuVpgMq3aUn5A7orQUxh4BU6CAwFg60/edit?usp=sharing
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5a6eef5a42368c79fe80beac730e53e544736df commit e5a6eef5a42368c79fe80beac730e53e544736df Author: toyoshim <toyoshim@chromium.org> Date: Wed Mar 01 06:50:07 2017 Reduce FetchContext::getCachePolicy() callers Before removing all callers, remove some callers that can be modified to call alternatives almost mechanically. BUG= 602900 Review-Url: https://codereview.chromium.org/2714383003 Cr-Commit-Position: refs/heads/master@{#453870} [modify] https://crrev.com/e5a6eef5a42368c79fe80beac730e53e544736df/third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp [modify] https://crrev.com/e5a6eef5a42368c79fe80beac730e53e544736df/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp [modify] https://crrev.com/e5a6eef5a42368c79fe80beac730e53e544736df/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h [modify] https://crrev.com/e5a6eef5a42368c79fe80beac730e53e544736df/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp [modify] https://crrev.com/e5a6eef5a42368c79fe80beac730e53e544736df/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
,
Mar 1 2017
,
Mar 1 2017
,
Mar 1 2017
,
Mar 2 2017
Issue 693021 has been merged into this issue.
,
Mar 2 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4562d4a8a6cc89ff20222ca0fe082e42a4625c86 commit 4562d4a8a6cc89ff20222ca0fe082e42a4625c86 Author: toyoshim <toyoshim@chromium.org> Date: Thu Mar 16 04:09:02 2017 Loading: extends ReloadCacheControlBrowserTest to cover frame reload To verify end to end reload behaviors against pages that contains iframes, update ReloadCacheControlBrowserTestt to check cache control flags against a page containing a simple frame in addition to an image resource. BUG= 602900 Review-Url: https://codereview.chromium.org/2756443002 Cr-Commit-Position: refs/heads/master@{#457348} [modify] https://crrev.com/4562d4a8a6cc89ff20222ca0fe082e42a4625c86/content/browser/loader/reload_cache_control_browsertest.cc [add] https://crrev.com/4562d4a8a6cc89ff20222ca0fe082e42a4625c86/content/test/data/loader/reload_test.html [rename] https://crrev.com/4562d4a8a6cc89ff20222ca0fe082e42a4625c86/content/test/data/loader/simple_frame.html
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa78cf3a4331be2113c320020e10d1223127c125 commit fa78cf3a4331be2113c320020e10d1223127c125 Author: toyoshim <toyoshim@chromium.org> Date: Wed Mar 22 10:29:39 2017 remove FetchContext::getCachePolicy() CachePolicy represents per-frame memory cache policy, and used to determine WebCachePolicy for resourceRequestCachePolicy in FrameFetchContext. Since the last caller of getCachePolicy() is only in FrameFetchContext, remove the virtual method completely, and replace it with some anonymous functions. BUG= 602900 Review-Url: https://codereview.chromium.org/1867493003 Cr-Commit-Position: refs/heads/master@{#458708} [modify] https://crrev.com/fa78cf3a4331be2113c320020e10d1223127c125/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/fa78cf3a4331be2113c320020e10d1223127c125/third_party/WebKit/Source/core/loader/FrameFetchContext.h [delete] https://crrev.com/d086be303574fcf89fe19de16307b2a582dd3362/third_party/WebKit/Source/platform/loader/fetch/CachePolicy.h [modify] https://crrev.com/fa78cf3a4331be2113c320020e10d1223127c125/third_party/WebKit/Source/platform/loader/fetch/FetchContext.cpp [modify] https://crrev.com/fa78cf3a4331be2113c320020e10d1223127c125/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
,
Mar 23 2017
Now Blink use single cache policy in all places :) |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by toyoshim@chromium.org
, Apr 13 2016