New issue
Advanced search Search tips

Issue 602885 link

Starred by 2 users
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

KeyboardEvent.code values for Windows logo keys are legacy values

Reported by dtoybo...@gmail.com, Apr 13 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2706.0 Safari/537.36

Example URL:
https://dvcs.w3.org/hg/d4e/raw-file/tip/key-event-test.html

Steps to reproduce the problem:
1. Go to https://dvcs.w3.org/hg/d4e/raw-file/tip/key-event-test.html
2. Set focus to the editor
3. Press Windows Logo keys on your keyboard (if there are, and pressing with Shift key is easier to test)

What is the expected behavior?
code value of Windows logo keys should be one of "MetaLeft" and "MetaRight".
https://w3c.github.io/uievents-code/#key-alphanumeric-functional

What went wrong?
Chromium still uses older draft's code values such as "OSLeft" and "OSRight".

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? No Firefox

Chrome version: 52.0.2706.0  Channel: n/a
OS Version: 10.0
Flash Version: 

Bug of Firefox is this: https://bugzilla.mozilla.org/show_bug.cgi?id=1264150

Comment 1 by dtapu...@chromium.org, Apr 13 2016

Components: -Blink Blink>Input
Labels: Hotlist-Input-Dev
Owner: dtapu...@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af863af3e83fae3718ffd0f4340eb1827b9ec15d

commit af863af3e83fae3718ffd0f4340eb1827b9ec15d
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Apr 21 14:33:59 2016

Replace OS_LEFT/RIGHT with META_LEFT/RIGHT

The DOM Code specification changed so ensure we send the correct
names for the Meta keys.

This change was done via git grep | sed.

BUG= 602885 

Review URL: https://codereview.chromium.org/1908683002

Cr-Commit-Position: refs/heads/master@{#388764}

[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/chrome/browser/chromeos/events/event_rewriter.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/remoting/client/normalizing_input_filter_cros.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/remoting/client/normalizing_input_filter_cros_unittest.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/remoting/client/normalizing_input_filter_mac.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/remoting/client/normalizing_input_filter_mac_unittest.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/remoting/host/input_injector_x11.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/remoting/protocol/input_event_tracker.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/ui/events/keycodes/dom/keycode_converter.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/ui/events/keycodes/dom/keycode_converter_data.inc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/ui/events/keycodes/dom_us_layout_data.h
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/ui/events/keycodes/keyboard_code_conversion.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/ui/events/keycodes/keyboard_code_conversion_unittest.cc
[modify] https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc

Comment 3 by dtapu...@chromium.org, Apr 21 2016

Labels: M-52
Status: Fixed (was: Assigned)
►

Sign in to add a comment