New issue
Advanced search Search tips

Issue 602879 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

KeyboardEvent.code values for volume control keys are legacy values

Reported by dtoybo...@gmail.com, Apr 13 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2706.0 Safari/537.36

Example URL:
https://dvcs.w3.org/hg/d4e/raw-file/tip/key-event-test.html

Steps to reproduce the problem:
1. Go to https://dvcs.w3.org/hg/d4e/raw-file/tip/key-event-test.html
2. Set focus to the editor
3. Press volume control keys on your keyboard (if there are)

What is the expected behavior?
code value of volume control keys should be one of "AudioVolumeDown", "AudioVolumeUp" and "AudioVolumeMute".
https://w3c.github.io/uievents-code/#key-media

What went wrong?
Chromium still uses older draft's code values such as "VolumeDown", "VolumeUp" and "VolumeMute".

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? No Firefox

Chrome version: 52.0.2706.0  Channel: n/a
OS Version: 10.0
Flash Version: 

Bug of Firefox is this: https://bugzilla.mozilla.org/show_bug.cgi?id=1264150
 
Components: -Blink Blink>Input
Labels: Hotlist-Input-Dev
Owner: dtapu...@chromium.org
Status: Assigned (was: Unconfirmed)
Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c20ce7dc62c6b92e7a827bf7856e2466f01ca38f

commit c20ce7dc62c6b92e7a827bf7856e2466f01ca38f
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Apr 13 18:48:18 2016

Rename Keyboard.code VolumeXXX to AudioVolumeXXX

Conform to the latest specification related to the volume key
name definitions.

BUG= 602879 

Review URL: https://codereview.chromium.org/1877243004

Cr-Commit-Position: refs/heads/master@{#387049}

[modify] https://crrev.com/c20ce7dc62c6b92e7a827bf7856e2466f01ca38f/ui/events/keycodes/dom/keycode_converter_data.inc

Sign in to add a comment