Chrome_Android: Crash Report - remote_media::RemoteMediaPlayerManager::GetAlternativePlayer |
|||||||
Issue descriptionProduct name: Chrome_Android Magic Signature: remote_media::RemoteMediaPlayerManager::GetAlternativePlayer Current link: https://crash.corp.google.com/browse?q=product.name%20CONTAINS%20'Chrome'%20AND%20custom_data.ChromeCrashProto.magic_signature_1.file_path%20CONTAINS%20'media%2F'%20AND%20product.name%3D'Chrome_Android'%20AND%20product.version%3D'51.0.2700.2'%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D'remote_media%3A%3ARemoteMediaPlayerManager%3A%3AGetAlternativePlayer'%20AND%20ReportID%3D'dac029c400000000'&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#3 Search properties: product.name: Chrome_Android custom_data.chromecrashproto.magic_signature_1.file_path: null product.version: 51.0.2700.2 custom_data.chromecrashproto.magic_signature_1.name: remote_media::RemoteMediaPlayerManager::GetAlternativePlayer reportid: dac029c400000000 Metadata : Product Name: Chrome_Android Product Version: 51.0.2700.2 Report ID: dac029c400000000 Report Time: Tue, 12 Apr 2016 22:28:00 GMT Uptime: 2321510 ms Cumulative Uptime: 0 ms User Email: OS Name: Android OS Version: 0.0.0 Linux 3.10.61-7194820 #1 SMP PREEMPT Sat Feb 13 15:29:24 KST 2016 aarch64 CPU Architecture: arm64 CPU Info: Seems a nullptr is getting into the alternative players list somehow. I don't immediately see how, but there are enough of these across various clients to indicate that this is a real crash.
,
Apr 15 2016
Sorry, ignore my comment, apparently the code has changed since then :)
,
Apr 15 2016
I see the crashes from Chrome 48... Potentially introduced by https://codereview.chromium.org/1403703005/
,
Apr 15 2016
This is the #32 browser crash on latest Android beta so I see no reason to track it as a blocker. That said, if you find a fix, I'm happy to merge it. Ping me if you disagree.
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9af71a3cfca697a63586d334267829408d702d6a commit 9af71a3cfca697a63586d334267829408d702d6a Author: avayvod <avayvod@chromium.org> Date: Mon Apr 18 18:29:59 2016 [Android,VideoFling] Never add null players to alternative ones BUG= 602851 TEST=existing tests The fix is a mere speculation from staring at the code. Review URL: https://codereview.chromium.org/1889233002 Cr-Commit-Position: refs/heads/master@{#387961} [modify] https://crrev.com/9af71a3cfca697a63586d334267829408d702d6a/chrome/browser/media/android/remote/remote_media_player_manager.cc [modify] https://crrev.com/9af71a3cfca697a63586d334267829408d702d6a/chrome/browser/media/android/remote/remote_media_player_manager.h
,
Apr 19 2016
,
Apr 19 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0115acda9502cc79e19e627f95ea2947191f478 commit f0115acda9502cc79e19e627f95ea2947191f478 Author: Anton Vayvod <avayvod@google.com> Date: Tue Apr 19 19:12:11 2016 [Android,VideoFling] Never add null players to alternative ones BUG= 602851 TEST=existing tests The fix is a mere speculation from staring at the code. Review URL: https://codereview.chromium.org/1889233002 Cr-Commit-Position: refs/heads/master@{#387961} (cherry picked from commit 9af71a3cfca697a63586d334267829408d702d6a) Review URL: https://codereview.chromium.org/1895873005 . Cr-Commit-Position: refs/branch-heads/2704@{#127} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/f0115acda9502cc79e19e627f95ea2947191f478/chrome/browser/media/android/remote/remote_media_player_manager.cc [modify] https://crrev.com/f0115acda9502cc79e19e627f95ea2947191f478/chrome/browser/media/android/remote/remote_media_player_manager.h
,
Apr 19 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by avayvod@chromium.org
, Apr 15 2016