New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 602843 link

Starred by 2 users
Status: WontFix
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Dec 2017
Cc:
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: devtools tests should not use InspectorTest.runAfterPendingDispatches method

Project Member Reported by lushnikov@chromium.org, Apr 13 2016 
DevTools tests should not use InspectorTest.runAfterPendingDispatches.

Tests written with this method tend to flake over time as DevTools code
evolves, increasing maintenance burden.

Instead, a specified methods of type _someMethodForTest should be sniffed to wait for a certain state.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d

commit cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d
Author: lushnikov <lushnikov@chromium.org>
Date: Wed Apr 13 21:28:47 2016

DevTools: deprecate InspectorTest.runAfterPendingDispatches

The InspectorTest.runAfterPendingDispatches results in an eventual test
flakiness, increasing maintanence burden.

Clients should consider other ways instead of using
InspectorTest.runAfterPendingDispatches, e.g. adding a specific
_methodForTest method which will be sniffed.

R=dgozman
BUG= 602843 

Review URL: https://codereview.chromium.org/1877223003

Cr-Commit-Position: refs/heads/master@{#387101}

[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/database-open.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/dom-storage-open.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/dynamic-scripts.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/console-fetch-logging.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/console-xhr-logging-async.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/console-xhr-logging.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/fragment.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/network/load-resource-for-frontend.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-blocked-reason.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-reload.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-manager.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/audits/audits-test.js
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-big-array.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-clear.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-eval-scoped.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-format-array-prototype.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-format-broken-unicode.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-format.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-last-result.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-log-wrapped-in-framework.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/console/console-tainted-globals.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-1.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-3.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-4.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-shadow-2.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-test.js
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/edit/insert-node-collapsed.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/elements-inspect-iframe-from-different-domain.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-limited-children.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-selection-on-refresh.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/expand-recursively.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/styles-2/metrics-box-sizing.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/styles/updates-during-dom-traversal.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/elements/styles/updates-throttled.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/extensions/extensions-audits-api.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/extensions/extensions-resources.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/load-file-resource-for-frontend.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-after-suspension.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-xhr.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-change-variable.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/skip-pauses-until-reload.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-inline-values.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/sources/debugger/dynamic-scripts.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/LayoutTests/inspector/storage-panel-dom-storage.html
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/cb18158bf1f1ef145d2aa6ebe7481b9bc14c1b4d/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js

Comment 2 by lushnikov@chromium.org, Dec 5 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment