New issue
Advanced search Search tips

Issue 602824 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

safe_browsing build failure on win gn

Project Member Reported by scottmg@chromium.org, Apr 12 2016

Issue description

Look familiar to anyone?

[e88057c...]d:\src\cr3\src>type out\debug\args.gn
is_debug = true
is_component_build = true
enable_nacl = false
is_chrome_branded = true
is_win_fastlink = true
target_cpu = "x86"
win_console_app = true
symbol_level = 2

[e88057c...]d:\src\cr3\src>ninja -C out\Debug chrome
ninja: Entering directory `out\Debug'
[13938->14/13985 ~33] ACTION //chrome/browser/resources/safe_browsing:make_file_types_protobuf(//build/toolchain/win:x86)
FAILED: d:/src/depot_tools/python276_bin/python.exe ../../chrome/browser/resources/safe_browsing/gen_file_type_proto.py -i ../../chrome/browser/resources/safe_browsing/download_file_types.asciipb -o gen/chrome/browser/resources/safe_browsing/download_file_types.pb -p pyproto/chrome/common/safe_browsing
Traceback (most recent call last):
  File "../../chrome/browser/resources/safe_browsing/gen_file_type_proto.py", line 13, in <module>
    import google.protobuf.text_format as text_format
ImportError: No module named google.protobuf.text_format

 

Comment 1 by vakh@chromium.org, Apr 12 2016

Owner: nparker@chromium.org
Status: Assigned (was: Untriaged)
nparker@ -- it looks like the script is having problems on Windows. Assigning to you. Related to http://crrev.com/1857983002
Status: Fixed (was: Assigned)
The CL was reverted. I'll update the import path and try landing again.  The bots didn't have trouble with the original CL though.

https://chromium.googlesource.com/chromium/src.git/+/6834929f54cd4dfbdd926ebb1f34edff98d32027

Sign in to add a comment