New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602820 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

"LevelDBServiceTest.Basic" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 12 2016

Issue description

"LevelDBServiceTest.Basic" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyIwsSBUZsYWtlIhhMZXZlbERCU2VydmljZVRlc3QuQmFzaWMM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by vabr@chromium.org, Apr 13 2016

 Issue 602806  has been merged into this issue.

Comment 2 by vabr@chromium.org, Apr 13 2016

 Issue 602874  has been merged into this issue.

Comment 3 by vabr@chromium.org, Apr 13 2016

 Issue 602867  has been merged into this issue.

Comment 4 by vabr@chromium.org, Apr 13 2016

 Issue 602845  has been merged into this issue.

Comment 5 by vabr@chromium.org, Apr 13 2016

 Issue 602833  has been merged into this issue.

Comment 6 by vabr@chromium.org, Apr 13 2016

Owner: vabr@chromium.org
Status: Started (was: Untriaged)
The LevelDBServiceTests seem to flake at the same time, so I bundled the different reports for different testcases into this one.

Comment 7 by vabr@chromium.org, Apr 13 2016

All the failures seem to have this log
Value of: error
  Actual: DatabaseError::INVALID_ARGUMENT
Expected: DatabaseError::OK

Comment 8 by vabr@chromium.org, Apr 13 2016

Labels: -Pri-1 -Sheriff-Chromium OS-Linux Pri-2
Owner: e...@chromium.org
Status: Assigned (was: Started)
CL disabling the tests is in flight: https://codereview.chromium.org/1883793002

Assigning to the code OWNER for triaging.

Comment 9 by vabr@chromium.org, Apr 13 2016

Adding logs from one of the failed builds.
Log File contents.html
69.2 KB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94f23841e2279711fdf26dda97efbc354454d2d9

commit 94f23841e2279711fdf26dda97efbc354454d2d9
Author: vabr <vabr@chromium.org>
Date: Wed Apr 13 09:56:43 2016

Disable flaky LevelDBServiceTests

BUG= 602820 
TBR=erg@chromium.org

Review URL: https://codereview.chromium.org/1883793002

Cr-Commit-Position: refs/heads/master@{#386954}

[modify] https://crrev.com/94f23841e2279711fdf26dda97efbc354454d2d9/components/leveldb/leveldb_service_unittest.cc

Consider switching all the tests to use an in-memory database, faster and more reliable. At least one tests must use actual files on disk, but i also think at most only one needs to. wdyt?
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb8314f733c1d0fb260c6059245fcf6ce2036317

commit cb8314f733c1d0fb260c6059245fcf6ce2036317
Author: erg <erg@chromium.org>
Date: Fri Apr 29 20:42:16 2016

mojo leveldb: Reenable tests which can be moved to the in-memory db.

File operations were causing flake on some of the leveldb
tests. We now run tests that can be done on an in-memory database there.

(There's still one test left disabled which requires file operations and
will be sorted out separately.)

BUG= 602820 

Review-Url: https://codereview.chromium.org/1928073002
Cr-Commit-Position: refs/heads/master@{#390747}

[modify] https://crrev.com/cb8314f733c1d0fb260c6059245fcf6ce2036317/components/leveldb/leveldb_service_unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a95c3cd937908671730b1b8aad013492b7670796

commit a95c3cd937908671730b1b8aad013492b7670796
Author: erg <erg@chromium.org>
Date: Mon May 02 20:13:35 2016

mojo: Fix leveldb unittests by making fs::Directories cloneable.

This adds a Clone() method to mojo filesystem Directory objects, along
with making it safe to clone Directory objects that represent temporary
directories so that the temporary directory sticks around as long as
there's a single open File or Directory referencing it.

Using this, we can fix the last flaky LevelDBServiceTest that needed to
access the filesystem.

BUG= 602820 

Review-Url: https://codereview.chromium.org/1935863002
Cr-Commit-Position: refs/heads/master@{#391040}

[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/BUILD.gn
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/directory_impl.cc
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/directory_impl.h
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/directory_impl_unittest.cc
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/file_impl.cc
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/file_impl.h
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/file_system_impl.cc
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/file_system_impl.h
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/filesystem.gyp
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/public/interfaces/directory.mojom
[add] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/shared_temp_dir.cc
[add] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/filesystem/shared_temp_dir.h
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/components/leveldb/leveldb_service_unittest.cc
[modify] https://crrev.com/a95c3cd937908671730b1b8aad013492b7670796/services/user/user_service.cc

Comment 14 by e...@chromium.org, May 2 2016

Status: Fixed (was: Assigned)

Sign in to add a comment