Material design hover effect on bookmarks bar buttons should have 2px rounded corners |
||||||||
Issue descriptionMaterial design hover effect on bookmarks bar buttons should have 2px rounded corners.
,
May 17 2016
,
May 18 2016
,
Jul 14 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9 2016
Kicking this into the available pool since Ben says he's not working on this.
,
Apr 26 2017
,
Apr 26 2017
Be aware that InkDropMasks don't work currently on Windows, see Issue 713359.
,
Apr 26 2017
thanks for the heads up. Are you suggesting that ink drop masks won't ever work, or that they just won't *yet* work on Windows?
,
Apr 26 2017
I'm saying 'yet', but I don't think Issue 713359 is on anyone's short term agenda.
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fe9396d6935924e6bff4345269293ed3ffd430e commit 6fe9396d6935924e6bff4345269293ed3ffd430e Author: estade <estade@chromium.org> Date: Fri Apr 28 19:26:15 2017 Round the corners of bookmark button ink drop effects. This applies to Linux and Chrome OS (and Mac Views) until 713359 is fixed. BUG= 602756 ,713359 Review-Url: https://codereview.chromium.org/2839953005 Cr-Commit-Position: refs/heads/master@{#468090} [modify] https://crrev.com/6fe9396d6935924e6bff4345269293ed3ffd430e/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/6fe9396d6935924e6bff4345269293ed3ffd430e/ui/views/animation/ink_drop_host_view.cc [modify] https://crrev.com/6fe9396d6935924e6bff4345269293ed3ffd430e/ui/views/animation/ink_drop_host_view.h [modify] https://crrev.com/6fe9396d6935924e6bff4345269293ed3ffd430e/ui/views/animation/ink_drop_mask.cc [modify] https://crrev.com/6fe9396d6935924e6bff4345269293ed3ffd430e/ui/views/animation/ink_drop_mask.h [modify] https://crrev.com/6fe9396d6935924e6bff4345269293ed3ffd430e/ui/views/controls/button/label_button.cc
,
Apr 28 2017
This is fixed for !win. Fixing it for win will require addressing bug 713359, at which point we'll get this for free. No further action is required on this bug but I'm not closing it because it's technically not fixed on !win.
,
May 4 2017
I just tested this on Windows 10 by removing #ifdef guards for Windows and exaggerating the rounded corners and the mask seems to work perfectly on Windows, too. See the attached screenshot showing a growing ripple.
,
Sep 24
Material Refresh has shipped, so this is no longer the spec. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pkasting@chromium.org
, May 4 2016Labels: -M-52 M-53