Issue metadata
Sign in to add a comment
|
Incorrect appearance of MD ripple animation when longpressing back/forward buttons |
||||||||||||||||||||
Issue descriptionWhen longpressing the back/forward buttons, the MD ripple animation briefly disappears once the longpress timer fires.
,
Apr 25 2016
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb commit b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb Author: bruthig <bruthig@chromium.org> Date: Tue Apr 26 00:16:59 2016 Fixed Back/Forward buttons to not hide ink drop when long press shows drop down menu. Some CustomButtons should hide the ink drop when showing the context menu (i.e. Bookmark menu buttons) and some should not (i.e. the Back/ Forward toolbar buttons). BUG= 602754 TEST=CustomButton.HideInkDropWhenShowingContextMenu TEST=CustomButton.DontHideInkDropWhenShowingContextMenu Review URL: https://codereview.chromium.org/1920783003 Cr-Commit-Position: refs/heads/master@{#389629} [modify] https://crrev.com/b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb/ui/views/controls/button/custom_button.cc [modify] https://crrev.com/b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb/ui/views/controls/button/custom_button.h [modify] https://crrev.com/b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb/ui/views/controls/button/custom_button_unittest.cc
,
Apr 28 2016
Verified on Version: 52.2717.0 canary Platform: 8249.0.0 canary-channel veyron_minnie
,
Apr 28 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f71636d278a0eaa4ed6818075b8ad3a05c204e12 commit f71636d278a0eaa4ed6818075b8ad3a05c204e12 Author: Ben Ruthig <bruthig@chromium.org> Date: Thu Apr 28 15:19:48 2016 Fixed Back/Forward buttons to not hide ink drop when long press shows drop down menu. Some CustomButtons should hide the ink drop when showing the context menu (i.e. Bookmark menu buttons) and some should not (i.e. the Back/ Forward toolbar buttons). BUG= 602754 TEST=CustomButton.HideInkDropWhenShowingContextMenu TEST=CustomButton.DontHideInkDropWhenShowingContextMenu Review URL: https://codereview.chromium.org/1920783003 Cr-Commit-Position: refs/heads/master@{#389629} (cherry picked from commit b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb) Review URL: https://codereview.chromium.org/1927983002 . Cr-Commit-Position: refs/branch-heads/2704@{#287} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/f71636d278a0eaa4ed6818075b8ad3a05c204e12/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/f71636d278a0eaa4ed6818075b8ad3a05c204e12/ui/views/controls/button/custom_button.cc [modify] https://crrev.com/f71636d278a0eaa4ed6818075b8ad3a05c204e12/ui/views/controls/button/custom_button.h [modify] https://crrev.com/f71636d278a0eaa4ed6818075b8ad3a05c204e12/ui/views/controls/button/custom_button_unittest.cc
,
Apr 28 2016
,
Apr 28 2016
Merged manually.
,
Jun 3 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bruthig@chromium.org
, Apr 25 2016