Issue metadata
Sign in to add a comment
|
Chrome not updating all accessible object locations |
||||||||||||||||||||||
Issue descriptionIn http://crrev.com/377045 ( http://crbug.com/588889 ), we tried to fire fewer Android events when objects change location. While this achieved its desired goal, it sometimes didn't update the internal data structure with the new locations, leading to the location updates containing stale data. Example: open the Google homepage, search for something, then in the search results page click on the Search Tools button. The green highlight is off and doesn't fix itself. It should fix itself within half a second max.
,
Apr 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8196ad3aa5a432169904cb72d57d760719df3e4a commit 8196ad3aa5a432169904cb72d57d760719df3e4a Author: dmazzoni <dmazzoni@chromium.org> Date: Fri Apr 15 00:18:46 2016 Accessible location change events need to update internal data structure In http://crrev.com/377045 ( http://crbug.com/588889 ), we tried to fire fewer Android events when objects change location. While this achieved its desired goal, it sometimes didn't update the internal data structure with the new locations, leading to the location updates containing stale data. This change refactors the code so that the internal data structure is always updated first, then a second function is called to send events, which can be deferred on Android. BUG= 602739 , 588889 Review URL: https://codereview.chromium.org/1884723003 Cr-Commit-Position: refs/heads/master@{#387488} [modify] https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a/content/browser/accessibility/browser_accessibility_manager.h [modify] https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a/content/browser/accessibility/browser_accessibility_manager_android.cc [modify] https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a/content/browser/accessibility/browser_accessibility_manager_android.h
,
Apr 15 2016
,
Apr 15 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e78110fb18421d81679d5ee745c78b68408ae0ad commit e78110fb18421d81679d5ee745c78b68408ae0ad Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Apr 15 16:44:57 2016 Merge to M51: Accessible location change events need to update internal data structure In http://crrev.com/377045 ( http://crbug.com/588889 ), we tried to fire fewer Android events when objects change location. While this achieved its desired goal, it sometimes didn't update the internal data structure with the new locations, leading to the location updates containing stale data. This change refactors the code so that the internal data structure is always updated first, then a second function is called to send events, which can be deferred on Android. BUG= 602739 , 588889 Review URL: https://codereview.chromium.org/1884723003 Cr-Commit-Position: refs/heads/master@{#387488} (cherry picked from commit 8196ad3aa5a432169904cb72d57d760719df3e4a) Review URL: https://codereview.chromium.org/1896463002 . Cr-Commit-Position: refs/branch-heads/2704@{#76} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/e78110fb18421d81679d5ee745c78b68408ae0ad/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/e78110fb18421d81679d5ee745c78b68408ae0ad/content/browser/accessibility/browser_accessibility_manager.h [modify] https://crrev.com/e78110fb18421d81679d5ee745c78b68408ae0ad/content/browser/accessibility/browser_accessibility_manager_android.cc [modify] https://crrev.com/e78110fb18421d81679d5ee745c78b68408ae0ad/content/browser/accessibility/browser_accessibility_manager_android.h
,
Apr 15 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by amineer@chromium.org
, Apr 14 2016