New issue
Advanced search Search tips

Issue 602739 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Chrome not updating all accessible object locations

Project Member Reported by dmazz...@chromium.org, Apr 12 2016

Issue description

In http://crrev.com/377045 ( http://crbug.com/588889 ), we tried to fire fewer Android events when objects change location. While this achieved its desired goal, it sometimes didn't update the internal data structure with the new locations, leading to the location updates containing stale data.

Example: open the Google homepage, search for something, then in the search results page click on the Search Tools button. The green highlight is off and doesn't fix itself. It should fix itself within half a second max.

 
[Bulk edit]

This bug is marked as a blocker for Android M51 beta, which is targeted for release on Apr 21, with the candidate build being cut on Apr 20.  As such, please fix the regression on trunk by no later than Tuesday, Apr 19 @ 5 PM PT in order to facilitate a merge.

100% sure this isn't a blocker?  Remove the ReleaseBlock-Beta label.  Think it shouldn't block, but not totally sure - or know it should block, but you won't be able to fix it in time?  Reply here and CC me.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8196ad3aa5a432169904cb72d57d760719df3e4a

commit 8196ad3aa5a432169904cb72d57d760719df3e4a
Author: dmazzoni <dmazzoni@chromium.org>
Date: Fri Apr 15 00:18:46 2016

Accessible location change events need to update internal data structure

In http://crrev.com/377045 ( http://crbug.com/588889 ), we tried to fire
fewer Android events when objects change location. While this achieved
its desired goal, it sometimes didn't update the internal data
structure with the new locations, leading to the location updates
containing stale data.

This change refactors the code so that the internal data structure is
always updated first, then a second function is called to send events,
which can be deferred on Android.

BUG= 602739 , 588889 

Review URL: https://codereview.chromium.org/1884723003

Cr-Commit-Position: refs/heads/master@{#387488}

[modify] https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a/content/browser/accessibility/browser_accessibility_manager.h
[modify] https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a/content/browser/accessibility/browser_accessibility_manager_android.h

Labels: Merge-Request-51

Comment 4 by tin...@google.com, Apr 15 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 15 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e78110fb18421d81679d5ee745c78b68408ae0ad

commit e78110fb18421d81679d5ee745c78b68408ae0ad
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Apr 15 16:44:57 2016

Merge to M51: Accessible location change events need to update internal data structure

In http://crrev.com/377045 ( http://crbug.com/588889 ), we tried to fire
fewer Android events when objects change location. While this achieved
its desired goal, it sometimes didn't update the internal data
structure with the new locations, leading to the location updates
containing stale data.

This change refactors the code so that the internal data structure is
always updated first, then a second function is called to send events,
which can be deferred on Android.

BUG= 602739 , 588889 

Review URL: https://codereview.chromium.org/1884723003

Cr-Commit-Position: refs/heads/master@{#387488}
(cherry picked from commit 8196ad3aa5a432169904cb72d57d760719df3e4a)

Review URL: https://codereview.chromium.org/1896463002 .

Cr-Commit-Position: refs/branch-heads/2704@{#76}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/e78110fb18421d81679d5ee745c78b68408ae0ad/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/e78110fb18421d81679d5ee745c78b68408ae0ad/content/browser/accessibility/browser_accessibility_manager.h
[modify] https://crrev.com/e78110fb18421d81679d5ee745c78b68408ae0ad/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/e78110fb18421d81679d5ee745c78b68408ae0ad/content/browser/accessibility/browser_accessibility_manager_android.h

Status: Fixed (was: Started)

Sign in to add a comment