New issue
Advanced search Search tips

Issue 602737 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue angleproject:1468

Blocking:
issue 602688



Sign in to add a comment

Run command buffer unit tests and fuzzers against the passthrough command buffer

Project Member Reported by geoffl...@chromium.org, Apr 12 2016

Issue description

Re-use as many mock tests as possible to test security issues in the new pass-through command buffer.

Not all tests will be portable because they make assumptions about when the GL driver will be called but many can be re-used to verify that commands that have been tampered with do no cause crashes.
 
Status: Started (was: Untriaged)
Summary: Run command buffer unit tests against the passthrough command buffer (was: Run )
Blockedon: angleproject:1468
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/c51642b40f23b40c9cb2f0ecd30db8a45a6b3c53

commit c51642b40f23b40c9cb2f0ecd30db8a45a6b3c53
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Nov 14 21:18:26 2016

Validate level exists for TexSubImage calls.

Before validating the texture format, verify that the texture level already
exists in glTexSubImage calls.

BUG= 602737 

Change-Id: I0d83c7d43c7b358abdb59583dc83265df70c13b5
Reviewed-on: https://chromium-review.googlesource.com/411361
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/c51642b40f23b40c9cb2f0ecd30db8a45a6b3c53/src/libANGLE/validationES3.cpp
[modify] https://crrev.com/c51642b40f23b40c9cb2f0ecd30db8a45a6b3c53/src/tests/gl_tests/TextureTest.cpp
[modify] https://crrev.com/c51642b40f23b40c9cb2f0ecd30db8a45a6b3c53/src/libANGLE/validationES2.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf4d8f4e8ca46c12e420cc57ed39bfa349ec47a2

commit bf4d8f4e8ca46c12e420cc57ed39bfa349ec47a2
Author: jmadill <jmadill@chromium.org>
Date: Thu Nov 17 03:57:51 2016

Roll ANGLE 9863a3e..555009c

https://chromium.googlesource.com/angle/angle.git/+log/9863a3e..555009c

BUG= chromium:593024 , 661413 , 602737 

TBR=zmo@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2506143003
Cr-Commit-Position: refs/heads/master@{#432733}

[modify] https://crrev.com/bf4d8f4e8ca46c12e420cc57ed39bfa349ec47a2/DEPS

Cc: cwallez@chromium.org jmad...@chromium.org
Summary: Run command buffer unit tests and fuzzers against the passthrough command buffer (was: Run command buffer unit tests against the passthrough command buffer)
Description: Show this description
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/559c4b2fba5e962a26396a952b79bf448de3160c

commit 559c4b2fba5e962a26396a952b79bf448de3160c
Author: geofflang <geofflang@chromium.org>
Date: Sat Feb 11 17:02:12 2017

Add validation to gl[Bind|Release]TexImage2DCHROMIUM.

BUG= 602737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2690633003
Cr-Commit-Position: refs/heads/master@{#449863}

[modify] https://crrev.com/559c4b2fba5e962a26396a952b79bf448de3160c/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dbb71ef483227725d0167e2fc602a64b07d02f8

commit 3dbb71ef483227725d0167e2fc602a64b07d02f8
Author: geofflang <geofflang@chromium.org>
Date: Sat Feb 11 17:04:09 2017

Explicitly validate sizes before allocating vectors.

GLsizei validation is not auto-generated in the passthrough command
decoder and is left up to ANGLE's validation but some entry points need
to make copies of the data before making GL calls.  Make sure the
GLsizei is non-negative in these cases.

BUG= 602737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2687393003
Cr-Commit-Position: refs/heads/master@{#449864}

[modify] https://crrev.com/3dbb71ef483227725d0167e2fc602a64b07d02f8/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6ed682b7d37b8f07bf9688b7a61352cd8969661

commit b6ed682b7d37b8f07bf9688b7a61352cd8969661
Author: geofflang <geofflang@chromium.org>
Date: Sat Feb 11 17:05:19 2017

Add null checks to the parameters of glGet* calls.

The passthrough command buffer wasn't validating that the params values
of glGet calls were large enough to hold the resulting data and was
potentially passing null pointers to the driver.

BUG= 602737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2688233002
Cr-Commit-Position: refs/heads/master@{#449865}

[modify] https://crrev.com/b6ed682b7d37b8f07bf9688b7a61352cd8969661/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec9b0ca3bf54e11d3e9d206f24845c32e77c5385

commit ec9b0ca3bf54e11d3e9d206f24845c32e77c5385
Author: geofflang <geofflang@chromium.org>
Date: Sat Feb 11 17:06:32 2017

Mark SwapBuffers for an offscreen surface as unimplemented

BUG= 602737 
BUG= 665521 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2686233004
Cr-Commit-Position: refs/heads/master@{#449866}

[modify] https://crrev.com/ec9b0ca3bf54e11d3e9d206f24845c32e77c5385/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/ec9b0ca3bf54e11d3e9d206f24845c32e77c5385/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/ec9b0ca3bf54e11d3e9d206f24845c32e77c5385/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a503e85de502aa541cae933a6cc7b6586b5b9cf

commit 4a503e85de502aa541cae933a6cc7b6586b5b9cf
Author: geofflang <geofflang@chromium.org>
Date: Sat Feb 11 17:07:51 2017

Only initialize a std::string with data when the data has len > 0.

When glGet[Shader|Program]InfoLog returned a zero-length info log,
std::string would be initialized with garbage data.  std::vector::data
has an undefined return value when the size of the vector is 0.

BUG= 602737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2693553002
Cr-Commit-Position: refs/heads/master@{#449867}

[modify] https://crrev.com/4a503e85de502aa541cae933a6cc7b6586b5b9cf/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c0f2dc2a8d781fcd7f8ddbb85ab27fb30255f2a

commit 3c0f2dc2a8d781fcd7f8ddbb85ab27fb30255f2a
Author: geofflang <geofflang@chromium.org>
Date: Sat Feb 11 17:09:00 2017

Flush errors when destroying a passthrough command decoder.

Sometimes the context would be re-used after destroying a command
decoder and would fail initialization of a new command decoder because
errors were already present on the context.

BUG= 602737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2689673004
Cr-Commit-Position: refs/heads/master@{#449868}

[modify] https://crrev.com/3c0f2dc2a8d781fcd7f8ddbb85ab27fb30255f2a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/c5508d6e6afe2a9faf14c251ed18a44fd1cfbdf0

commit c5508d6e6afe2a9faf14c251ed18a44fd1cfbdf0
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Feb 13 16:38:14 2017

Validate that the format is compressed before calculating data size.

glCompressedTexImage3D was missing a check that the format was valid
before trying to compute the expected data size.  This lead to an
assertion failure in the size computation code.

BUG= 602737 

Change-Id: I74e6ced082e78396a0af92317fb1c0098299a026
Reviewed-on: https://chromium-review.googlesource.com/441185
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/c5508d6e6afe2a9faf14c251ed18a44fd1cfbdf0/src/libANGLE/validationES3.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b0ca8add9594566989b917f50fb948556125698

commit 7b0ca8add9594566989b917f50fb948556125698
Author: geofflang <geofflang@chromium.org>
Date: Mon Feb 13 16:48:38 2017

Auto-generate null checks for pointer arguemnts in the passthrough cmd decoder.

Argument validation wasn't added previously because it was mostly for
enum checks.  These null checks prevent issues where the buffer is not
big enough and null was returned when getting immediate data.

BUG= 602737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2692573002
Cr-Commit-Position: refs/heads/master@{#449979}

[modify] https://crrev.com/7b0ca8add9594566989b917f50fb948556125698/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/7b0ca8add9594566989b917f50fb948556125698/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/44ec2f5995836b4915c04158f1aa0b47f774b1ae

commit 44ec2f5995836b4915c04158f1aa0b47f774b1ae
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Feb 13 17:01:52 2017

Fix GL_MAX_SAMPLES query for ES3 when the extension is missing.

This query was added in both ES3 and ANGLE_framebuffer_multisample but
the code was never updated to accept it for an ES3 context without the
extension present.

Caught by the angle passthrough command decoder fuzzer.

BUG= 602737 

Change-Id: Ic9a8c67747777ef48e1dd227110482998fee75ce
Reviewed-on: https://chromium-review.googlesource.com/440651
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/44ec2f5995836b4915c04158f1aa0b47f774b1ae/src/libANGLE/ContextState.cpp

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/1e031b279b9c4e0297a3d80e6555edf33e72ee8a

commit 1e031b279b9c4e0297a3d80e6555edf33e72ee8a
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Feb 13 17:05:56 2017

Expose the CHROMIUM copy texture extensions on the NULL backend.

These extensions are required by the passthrough command decoder.

BUG= 602737 

Change-Id: Ifd04fca27ae35b30e4c8ab458904530e3dd44377
Reviewed-on: https://chromium-review.googlesource.com/441204
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/1e031b279b9c4e0297a3d80e6555edf33e72ee8a/src/libANGLE/renderer/null/ContextNULL.cpp

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/1b60d8d24b9af6bb5e3dd2f6301b9173dcf840d7

commit 1b60d8d24b9af6bb5e3dd2f6301b9173dcf840d7
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Feb 13 18:39:58 2017

Add artificial limits to the total memory allocated by the NULL backend.

Fuzzer tests were capable of allocating very large chunks of memory by
calling glBufferData with a null pointer.  This sets a limit before the
NULL backend starts returning out of memory GL errors.

BUG= 602737 

Change-Id: Ic53ebcf999f951b96c1df82e4db57e949d03c908
Reviewed-on: https://chromium-review.googlesource.com/441184
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/1b60d8d24b9af6bb5e3dd2f6301b9173dcf840d7/src/libANGLE/renderer/null/DisplayNULL.cpp
[modify] https://crrev.com/1b60d8d24b9af6bb5e3dd2f6301b9173dcf840d7/src/libANGLE/renderer/null/BufferNULL.h
[modify] https://crrev.com/1b60d8d24b9af6bb5e3dd2f6301b9173dcf840d7/src/libANGLE/renderer/null/DisplayNULL.h
[modify] https://crrev.com/1b60d8d24b9af6bb5e3dd2f6301b9173dcf840d7/src/libANGLE/renderer/null/BufferNULL.cpp
[modify] https://crrev.com/1b60d8d24b9af6bb5e3dd2f6301b9173dcf840d7/src/libANGLE/renderer/null/ContextNULL.h
[modify] https://crrev.com/1b60d8d24b9af6bb5e3dd2f6301b9173dcf840d7/src/libANGLE/renderer/null/ContextNULL.cpp

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/879aaac59dca262da89e57b8048722dd69050ff9

commit 879aaac59dca262da89e57b8048722dd69050ff9
Author: jmadill <jmadill@chromium.org>
Date: Tue Feb 14 02:04:26 2017

Roll ANGLE 875bbba..b1eeba1

https://chromium.googlesource.com/angle/angle.git/+log/875bbba..b1eeba1

BUG= chromium:678870 , 602737 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2693003002
Cr-Commit-Position: refs/heads/master@{#450197}

[modify] https://crrev.com/879aaac59dca262da89e57b8048722dd69050ff9/DEPS

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/34fefb7e3598c7c30dd483f161e8f90da8168827

commit 34fefb7e3598c7c30dd483f161e8f90da8168827
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Feb 15 15:16:33 2017

Fix initialization of Caps members.

sRGB was never initialized and maxTextureAnisotropy was initialized with
a bool instead of a float.

BUG= 602737 

Change-Id: Ied7c27d1dbdbec96f8aead618132b4f59892bd99
Reviewed-on: https://chromium-review.googlesource.com/442668
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/34fefb7e3598c7c30dd483f161e8f90da8168827/src/libANGLE/Caps.cpp

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/085d96d2ce61f416d03f95f228196f55746e63ed

commit 085d96d2ce61f416d03f95f228196f55746e63ed
Author: cwallez <cwallez@chromium.org>
Date: Wed Feb 15 16:52:29 2017

Roll ANGLE 6137ddc..92db39e

https://chromium.googlesource.com/angle/angle.git/+log/6137ddc..92db39e

BUG= chromium:678870 , 602737 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2698673002
Cr-Commit-Position: refs/heads/master@{#450725}

[modify] https://crrev.com/085d96d2ce61f416d03f95f228196f55746e63ed/DEPS

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/feb8c68685270e7cc482a4e56291eac3399b6646

commit feb8c68685270e7cc482a4e56291eac3399b6646
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Feb 15 17:31:55 2017

Add extensions to disable client arrays.

Chrome doesn't allow any client data in its command buffer.  Add an ANGLE
extension to request a context that disallows client data.

BUG= 602737 

Change-Id: If9d5144daea3c629a73562396000df59a671aad3
Reviewed-on: https://chromium-review.googlesource.com/441986
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[add] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/tests/gl_tests/ClientArraysTest.cpp
[add] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/extensions/EGL_ANGLE_create_context_client_arrays.txt
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/validationES_unittest.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/tests/test_utils/ANGLETest.h
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/State.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/Display.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/Context.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/util/EGLWindow.h
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/util/EGLWindow.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/validationEGL.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/State.h
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/tests/test_utils/ANGLETest.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/Caps.h
[add] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/extensions/ANGLE_client_arrays.txt
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/Caps.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/tests/angle_end2end_tests.gypi
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/validationES.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/validationES2.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/include/GLES2/gl2ext.h
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/ContextState.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/include/EGL/eglext.h

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/feb8c68685270e7cc482a4e56291eac3399b6646

commit feb8c68685270e7cc482a4e56291eac3399b6646
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Feb 15 17:31:55 2017

Add extensions to disable client arrays.

Chrome doesn't allow any client data in its command buffer.  Add an ANGLE
extension to request a context that disallows client data.

BUG= 602737 

Change-Id: If9d5144daea3c629a73562396000df59a671aad3
Reviewed-on: https://chromium-review.googlesource.com/441986
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[add] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/tests/gl_tests/ClientArraysTest.cpp
[add] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/extensions/EGL_ANGLE_create_context_client_arrays.txt
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/validationES_unittest.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/tests/test_utils/ANGLETest.h
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/State.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/Display.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/Context.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/util/EGLWindow.h
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/util/EGLWindow.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/validationEGL.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/State.h
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/tests/test_utils/ANGLETest.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/Caps.h
[add] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/extensions/ANGLE_client_arrays.txt
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/Caps.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/tests/angle_end2end_tests.gypi
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/validationES.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/validationES2.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/include/GLES2/gl2ext.h
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/src/libANGLE/ContextState.cpp
[modify] https://crrev.com/feb8c68685270e7cc482a4e56291eac3399b6646/include/EGL/eglext.h

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/092c4965754a0db3db743b9d2b83564070a3cdf3

commit 092c4965754a0db3db743b9d2b83564070a3cdf3
Author: geofflang <geofflang@chromium.org>
Date: Wed Feb 15 19:26:08 2017

Roll ANGLE 92db39e..feb8c68

https://chromium.googlesource.com/angle/angle.git/+log/92db39e..feb8c68

BUG= 602737 

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2696203002
Cr-Commit-Position: refs/heads/master@{#450768}

[modify] https://crrev.com/092c4965754a0db3db743b9d2b83564070a3cdf3/DEPS

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0526716fe414eef61b0c151affd57b6f3bb6c96f

commit 0526716fe414eef61b0c151affd57b6f3bb6c96f
Author: geofflang <geofflang@chromium.org>
Date: Wed Feb 15 22:23:42 2017

Check for some extensions before calling potentially NULL GL entry points.

Some extensions are exposed by the command buffer unconditionally, add
some tracking of which extensions are natively supported and call the
correct entry point.

BUG= 602737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2689203002
Cr-Commit-Position: refs/heads/master@{#450816}

[modify] https://crrev.com/0526716fe414eef61b0c151affd57b6f3bb6c96f/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/0526716fe414eef61b0c151affd57b6f3bb6c96f/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/0526716fe414eef61b0c151affd57b6f3bb6c96f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/0526716fe414eef61b0c151affd57b6f3bb6c96f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1ff92273926fd3a8d8a12393fe7fdcbfc99736d

commit d1ff92273926fd3a8d8a12393fe7fdcbfc99736d
Author: geofflang <geofflang@chromium.org>
Date: Thu Feb 23 18:53:59 2017

Don't require CHROMIUM_copy_compressed_texture for the passthrough decoder.

ANGLE's OpenGL backend doesn't support this extension yet so the decoder
fails to initialze.

TBR=zmo@chromium.org

BUG= angleproject:1876 
BUG= 602737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2717443004
Cr-Commit-Position: refs/heads/master@{#452566}

[modify] https://crrev.com/d1ff92273926fd3a8d8a12393fe7fdcbfc99736d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/d1ff92273926fd3a8d8a12393fe7fdcbfc99736d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/547de958066823514c34b264b0711bb24eb31dc6

commit 547de958066823514c34b264b0711bb24eb31dc6
Author: geofflang <geofflang@chromium.org>
Date: Mon Mar 20 17:11:15 2017

Add gpu_angle_passthrough_fuzzer.

Tests the passthrough command decoder and the ANGLE null backend.

Reset the context after each iteration. When the same context was
re-used, it lead to crashes that could not be reproduced with the input
file provided. Theoretically, the fuzzer will still find the same
crashes with a single run using one context unless the crash was in the
intialization/destruction code of the command decoder and depended on a
context having specific state.

BUG= 602737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2691643002
Cr-Commit-Position: refs/heads/master@{#458103}

[modify] https://crrev.com/547de958066823514c34b264b0711bb24eb31dc6/gpu/BUILD.gn
[modify] https://crrev.com/547de958066823514c34b264b0711bb24eb31dc6/gpu/command_buffer/tests/fuzzer_main.cc

Status: Fixed (was: Started)
Project Member

Comment 31 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/9b8dfb8032d88f3f3cf892c1b2ebc43ebfa037b6

commit 9b8dfb8032d88f3f3cf892c1b2ebc43ebfa037b6
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Aug 16 20:26:05 2017

Support more display extensions in DisplayNULL.

BUG= 602737 

Change-Id: I05987f4806e179eb50f4b86533c88831e359b9e8
Reviewed-on: https://chromium-review.googlesource.com/617514
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/9b8dfb8032d88f3f3cf892c1b2ebc43ebfa037b6/src/libANGLE/renderer/null/DisplayNULL.cpp

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/be1b071753538584c34257ce6eb17dcb78ef7d35

commit be1b071753538584c34257ce6eb17dcb78ef7d35
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Thu Aug 17 13:27:06 2017

Roll skia/third_party/externals/angle2/ aadc8f376..41ac68e71 (11 commits)

https://chromium.googlesource.com/angle/angle.git/+log/aadc8f376a2c..41ac68e711f5

$ git log aadc8f376..41ac68e71 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 602737 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE
TBR=bsalomon@google.com

Change-Id: Ifc91ba4ec20ede1fdc2fa865186edb4d83e83146
Reviewed-on: https://skia-review.googlesource.com/35680
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/be1b071753538584c34257ce6eb17dcb78ef7d35/DEPS

Status: Started (was: Fixed)
Project Member

Comment 34 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6e54d929c511986b2ef43c4bcc1312b8e2bb426

commit b6e54d929c511986b2ef43c4bcc1312b8e2bb426
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Thu Aug 17 18:35:34 2017

Roll src/third_party/skia/ cf75b00ff..0741818e7 (20 commits)

https://skia.googlesource.com/skia.git/+log/cf75b00ff0b5..0741818e7ab4

$ git log cf75b00ff..0741818e7 --date=short --no-merges --format='%ad %ae %s'
2017-08-15 scroggo Move calls to conversion_possible to SkCodec
2017-08-17 angle-deps-roller Roll skia/third_party/externals/angle2/ 41ac68e71..b18c33e94 (1 commit)
2017-08-17 bsalomon Revert "Switched highp float to highfloat and mediump float to half."
2017-08-17 bsalomon Revert "fixed constant vector swizzling"
2017-08-17 bungeman Remove SkPARAM and SkDECLAREPARAM.
2017-08-17 bungeman Remove SkFAIL.
2017-08-17 mtklein Revert "skia: add heif decoding support"
2017-08-17 angle-deps-roller Roll skia/third_party/externals/angle2/ aadc8f376..41ac68e71 (11 commits)
2017-08-17 bungeman Revert "Remove SkFAIL."
2017-08-16 bungeman Remove SkFAIL.
2017-08-16 brianosman Optimize the size of our JSON
2017-08-16 brianosman Support color space and other color types in SkImage_Raster::onMakeSubset
2017-08-16 ethannicholas fixed constant vector swizzling
2017-08-16 ethannicholas Switched highp float to highfloat and mediump float to half.
2017-08-16 mtklein Revert "turn exceptions on in test tools on Android"
2017-08-16 chz skia: add heif decoding support
2017-08-16 brianosman Cache WGL extension function pointers
2017-08-16 jcgregorio Remove examples of now removed SkArcToPathEffect.
2017-08-16 mtklein cut down GrShapeTest stack usage
2017-08-16 stani Add additional logging in GrRenderTargetOpList

Created with:
  roll-dep src/third_party/skia
BUG= 602737 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=bsalomon@chromium.org

Change-Id: I5e7d084c27e412060360327cf450cb20b96ba500
Reviewed-on: https://chromium-review.googlesource.com/619268
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495241}
[modify] https://crrev.com/b6e54d929c511986b2ef43c4bcc1312b8e2bb426/DEPS

Project Member

Comment 35 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/236105a6afc95bfab50b0a3e3487c85cc049b49c

commit 236105a6afc95bfab50b0a3e3487c85cc049b49c
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Aug 18 05:10:40 2017

Roll ANGLE 79f7104..92996b0

https://chromium.googlesource.com/angle/angle.git/+log/79f7104..92996b0

BUG=:angleproject:1644,602737

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I9973eb1aa8857345388435e172e74484344a9de0
Reviewed-on: https://chromium-review.googlesource.com/620387
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495469}
[modify] https://crrev.com/236105a6afc95bfab50b0a3e3487c85cc049b49c/DEPS

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a7d47643185b94a0ba4c0c0e92a5607c8065a84

commit 6a7d47643185b94a0ba4c0c0e92a5607c8065a84
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Aug 24 15:05:50 2017

Run the command decoder buffer unittests against the passthrough command decoder.

Fix tracking of mapped buffers when the buffer is deleted or re-initialized.

BUG= 602737 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I97800d542f41bc591d04a52af2653d35f1f8076d
Reviewed-on: https://chromium-review.googlesource.com/615802
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497049}
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/BUILD.gn
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[add] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_buffers.cc
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/service/gles2_cmd_decoder_unittest.h
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/6a7d47643185b94a0ba4c0c0e92a5607c8065a84/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/9fe13cd7101b2d5c9663d8d5008c8a62e00ca15f

commit 9fe13cd7101b2d5c9663d8d5008c8a62e00ca15f
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Thu Aug 31 20:10:20 2017

Roll skia/third_party/externals/angle2/ e49058e75..6ee26d7a2 (3 commits)

https://chromium.googlesource.com/angle/angle.git/+log/e49058e7590d..6ee26d7a2e35

$ git log e49058e75..6ee26d7a2 --date=short --no-merges --format='%ad %ae %s'
2017-08-31 oetuaho Fix linking of non-existent XFB varyings with gl_ prefix
2017-05-18 oetuaho Remove webgl_ prefix from emulated function names
2017-08-30 cwallez FramebufferNULL::readPixels: write pixels for tests

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 602737 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-ZBOX-GPU-GTX1070-x86_64-Debug-ANGLE
TBR=djsollen@google.com

Change-Id: I83524719a04bee8e8438c2536e91eb1d3e77d3a6
Reviewed-on: https://skia-review.googlesource.com/41603
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/9fe13cd7101b2d5c9663d8d5008c8a62e00ca15f/DEPS

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a895bfb349181c649f6578f1dcbba941ec6d2e83

commit a895bfb349181c649f6578f1dcbba941ec6d2e83
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Fri Sep 01 19:40:20 2017

Roll src/third_party/skia/ 36c60c977..dbb24efcc (36 commits)

https://skia.googlesource.com/skia.git/+log/36c60c9777fc..dbb24efcc5f2

$ git log 36c60c977..dbb24efcc --date=short --no-merges --format='%ad %ae %s'
2017-09-01 jvanverth Get viewer running on iOS
2017-09-01 angle-deps-roller Roll skia/third_party/externals/angle2/ bb6e66434..f00f7ffed (1 commit)
2017-08-31 robertphillips Cosmetic changes to GrDrawOpAtlas
2017-09-01 mtklein Add FIFO thread pool, use it for most things.
2017-09-01 brianosman With threaded software paths, free mask memory earlier
2017-09-01 mtklein pixmap erase fast-path
2017-09-01 mtklein ok, rate limit forking
2017-09-01 bsalomon Add methods for converting GrShape to filled style
2017-08-31 liyuqian Use SkSTArenaAlloc to handle the stack memory of the delta list
2017-09-01 angle-deps-roller Roll skia/third_party/externals/angle2/ bb2bbfbbf..bb6e66434 (1 commit)
2017-09-01 egdaniel Fix up and clarify use of maxMipLevel in Vulkan
2017-08-31 jvanverth Move texture proxy allocation for atlas to constructor.
2017-09-01 angle-deps-roller Roll skia/third_party/externals/angle2/ 561ed3aeb..bb2bbfbbf (1 commit)
2017-08-31 angle-deps-roller Roll skia/third_party/externals/angle2/ fa08cae7c..561ed3aeb (2 commits)
2017-08-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 6ee26d7a2..fa08cae7c (2 commits)
2017-08-31 bungeman Fix system icu build.
2017-08-31 brianosman Fix config strings in nanobench tracing
2017-08-31 angle-deps-roller Roll skia/third_party/externals/angle2/ e49058e75..6ee26d7a2 (3 commits)
2017-08-31 bsalomon Revert "Revert "Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget.""""
2017-08-31 bsalomon Revert "Revert "Add a GrShape::Type value for an inverted empty path""
2017-08-31 brianosman Blacklist (flaky) textbloblooper on gltestthreading
2017-08-31 bsalomon Revert "Add a GrShape::Type value for an inverted empty path"
2017-08-31 brianosman Add top-level trace markers for each benchmark
2017-08-31 bsalomon Add a GrShape::Type value for an inverted empty path
2017-08-31 kjlubick Fix chromecast perfs
2017-08-31 herb Use interpolating blur for sigma < 2
2017-08-31 reed add 8bit stages for load/store 565
2017-08-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 855d964bd..e49058e75 (1 commit)
2017-08-31 bsalomon Revert "Revert "Revert "Remove GrBackendRenderTargetDesc in favor of GrBackendRenderTarget."""
2017-08-31 kjlubick Add Correctness tests for Chromecast
2017-08-30 bungeman Add bidi to SkShaper.
2017-08-31 robertphillips Retract Gr*Priv.h includes a bit
2017-08-31 bsalomon Use high precision for TextureOp texture coord varying
2017-08-31 hcm Update Skia milestone to 63
2017-08-31 rmistry Whitespace change to test task-scheduler/task-scheduler-internal
2017-08-31 angle-deps-roller Roll skia/third_party/externals/angle2/ ced5c86c3..855d964bd (1 commit)

Created with:
  roll-dep src/third_party/skia
BUG=None,602737,759273


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: I39d24f8cecebdafd0d8fa03c23236c9b9f8a6818
Reviewed-on: https://chromium-review.googlesource.com/647999
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499262}
[modify] https://crrev.com/a895bfb349181c649f6578f1dcbba941ec6d2e83/DEPS

Project Member

Comment 40 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dcbe4dd3b6868fdd77f7bc04d47c6c2341d407a

commit 7dcbe4dd3b6868fdd77f7bc04d47c6c2341d407a
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Sep 05 06:43:44 2017

Roll ANGLE 855d964..72b4e1e

https://chromium.googlesource.com/angle/angle.git/+log/855d964..72b4e1e

BUG= 759402 , 602737 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: If5c6dc88ce9dbb9c790f5b59c92bef2cf6ede3d8
Reviewed-on: https://chromium-review.googlesource.com/650007
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499578}
[modify] https://crrev.com/7dcbe4dd3b6868fdd77f7bc04d47c6c2341d407a/DEPS

Project Member

Comment 41 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9527cb23fb5328b0fef0efbe8147a3adaf876f0a

commit 9527cb23fb5328b0fef0efbe8147a3adaf876f0a
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Oct 02 20:07:09 2017

Run relevant framebuffer cmd decoder unittests on passthrough

Also make the passthrough command decoder better replicate the behavior
of HandleReadPixels with / without pack buffers.

BUG= 602737 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I165919177ba94d5cb182148c8f8b2e4d36108671
Reviewed-on: https://chromium-review.googlesource.com/644212
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505747}
[modify] https://crrev.com/9527cb23fb5328b0fef0efbe8147a3adaf876f0a/gpu/BUILD.gn
[modify] https://crrev.com/9527cb23fb5328b0fef0efbe8147a3adaf876f0a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
[add] https://crrev.com/9527cb23fb5328b0fef0efbe8147a3adaf876f0a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_framebuffers.cc
[modify] https://crrev.com/9527cb23fb5328b0fef0efbe8147a3adaf876f0a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/9527cb23fb5328b0fef0efbe8147a3adaf876f0a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h

Project Member

Comment 42 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/679ae771d747c9192482fddd6d8e6df4770335fa

commit 679ae771d747c9192482fddd6d8e6df4770335fa
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu Oct 05 21:02:20 2017

Add more FBO passthrough command decoder unittests

BUG= 602737 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icd8e5a4c6d1c7ccddbbd591ef22326d2719084f5
Reviewed-on: https://chromium-review.googlesource.com/700989
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506853}
[modify] https://crrev.com/679ae771d747c9192482fddd6d8e6df4770335fa/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_framebuffers.cc
[modify] https://crrev.com/679ae771d747c9192482fddd6d8e6df4770335fa/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/679ae771d747c9192482fddd6d8e6df4770335fa/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h

Project Member

Comment 43 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c19bed143da563da8b3f94a8836ea249ecff6039

commit c19bed143da563da8b3f94a8836ea249ecff6039
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Oct 11 21:10:57 2017

Run relevant drawing cmd decoder unittests on passthrough

Includes fixes to disallow ANGLE_instanced_arrays entry-points when the
extension isn't enabled.

BUG= 602737 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I94fa75c02dd49d0a9020d35c7b00c2b7e0b23640
Reviewed-on: https://chromium-review.googlesource.com/713662
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508114}
[modify] https://crrev.com/c19bed143da563da8b3f94a8836ea249ecff6039/gpu/BUILD.gn
[modify] https://crrev.com/c19bed143da563da8b3f94a8836ea249ecff6039/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/c19bed143da563da8b3f94a8836ea249ecff6039/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[add] https://crrev.com/c19bed143da563da8b3f94a8836ea249ecff6039/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_drawing.cc
[modify] https://crrev.com/c19bed143da563da8b3f94a8836ea249ecff6039/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/c19bed143da563da8b3f94a8836ea249ecff6039/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h

Project Member

Comment 44 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/91c8de883f2cd736b758dfe3f6026b30f8f59c75

commit 91c8de883f2cd736b758dfe3f6026b30f8f59c75
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu Oct 12 23:44:31 2017

WebGLCompat: Add test for ANGLE_instanced_arrays

Also adds a test for an integer overflow in DrawArrays validation.

BUG= 602737 

Change-Id: I71c5bd155cf919964f46e2b0b48267253cab91eb
Reviewed-on: https://chromium-review.googlesource.com/716841
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/91c8de883f2cd736b758dfe3f6026b30f8f59c75/src/tests/gl_tests/WebGLCompatibilityTest.cpp

Project Member

Comment 45 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/23ac1b2aeb4522696520bee384212c12624187c9

commit 23ac1b2aeb4522696520bee384212c12624187c9
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Oct 13 01:17:02 2017

Roll skia/third_party/externals/angle2/ 22d7f1f3f..91c8de883 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/22d7f1f3f5b9..91c8de883f2c

$ git log 22d7f1f3f..91c8de883 --date=short --no-merges --format='%ad %ae %s'
2017-10-12 cwallez WebGLCompat: Add test for ANGLE_instanced_arrays

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 602737 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=reed@google.com

Change-Id: Id98bd1eb547e272465c178f2862b213ea5215017
Reviewed-on: https://skia-review.googlesource.com/59263
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/23ac1b2aeb4522696520bee384212c12624187c9/DEPS

Project Member

Comment 46 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a24eadedcaf0ccdaac8648c812dffad37b9fce5

commit 1a24eadedcaf0ccdaac8648c812dffad37b9fce5
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Fri Oct 13 22:15:45 2017

Roll src/third_party/skia/ e60ca7eae..f543a60ef (46 commits; 2 trivial rolls)

https://skia.googlesource.com/skia.git/+log/e60ca7eae432..f543a60ef06a

$ git log e60ca7eae..f543a60ef --date=short --no-merges --format='%ad %ae %s'
2017-10-13 fmalita [SVGDom] Add 'stroke-dasharray' support
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 40dbdd6c7..2bdbf788b (1 commit)
2017-10-13 abarth Add the ability to customize skia's settings in gn
2017-10-13 kjlubick Fix asset version detection
2017-10-13 bsalomon Implemenet onStealBackendTexture in GrMtlTexture
2017-10-13 reed remove dead code -- older than min picture version
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 3755c48d1..40dbdd6c7 (1 commit)
2017-10-13 halcanary platform_tools/android/bin/android_gdbserver: fix error
2017-10-12 bungeman Make SkTypeface::Style and FromOldStyle private.
2017-10-09 egdaniel Add support for allocating mips inside of ColorSpaceXormImageGenerator
2017-10-11 benjaminwagner Add Win Clang ANGLE test and perf jobs.
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 429756442..3755c48d1 (1 commit)
2017-10-13 reed remove dead code for getSize, getSafeSize, etc.
2017-10-13 mtklein Back out new SkColorSpaceXform pipeline.
2017-10-13 reed Revert "move SkMatrix anonymous affine enum to private"
2017-10-13 kjlubick Modify skpbench to use newer adb version
2017-10-13 kjlubick Adjust blacklist for IB2
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 41200d21b..429756442 (1 commit)
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 91c8de883..41200d21b (1 commit)
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 22d7f1f3f..91c8de883 (1 commit)
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ f6d242edb..22d7f1f3f (1 commit)
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ c3bc98415..f6d242edb (1 commit)
2017-10-12 ericrk MakeBackendTextureFromSkImage
2017-10-12 caryclark move SkMatrix anonymous affine enum to private
2017-10-12 egdaniel Handle coverage for hairline lines with sub pixel lengths correctly on GPU
2017-10-12 reed remove dead flag
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 6aee8620c..c3bc98415 (2 commits)
2017-10-12 kjlubick Fix Chromebook output step and skpbench
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ d736cccf0..6aee8620c (1 commit)
2017-10-11 mtklein check unpremul scale directly against infinity
2017-10-12 kjlubick Update to adb 1.0.35
2017-10-12 fmalita [SVGDom] Add 'visibility' support
2017-10-12 egdaniel Add flag on GrBackendTexture to say whether texture is mipped or not
2017-10-12 egdaniel Fix Metal build
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 923ecef6b..d736cccf0 (2 commits)
2017-10-12 egdaniel Use enum to track MipMapsStatus throughout Texture creation
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ d92e93b8c..923ecef6b (1 commit)
2017-10-12 jvanverth Fix assert in GrSmallPathRenderer tickled by GLProgramsTest
2017-10-12 fmalita Plumb more SkPaintFilterCanvas virtuals
2017-10-11 mtklein abort SkRRect::transform() before dst->scaleRadii() asserts
2017-10-12 hcm Update Skia milestone to 64
2017-10-12 stani Implement getGrContext in SkPaintFilterCanvas
2017-10-12 jvanverth Batch better in GrSmallPathRenderer and add perspective support.
2017-10-11 robertphillips Force all Intel GPUs to use draws instead of clears on Macs

Created with:
  roll-dep src/third_party/skia
BUG= 602737 ,602688,772695


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I5195a5c74f49f8b9f8830dcbf373e97f0f9ed63d
Reviewed-on: https://chromium-review.googlesource.com/719419
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508840}
[modify] https://crrev.com/1a24eadedcaf0ccdaac8648c812dffad37b9fce5/DEPS

Project Member

Comment 47 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32af0c846ce00672c60c6e643ff16fb05ea573c3

commit 32af0c846ce00672c60c6e643ff16fb05ea573c3
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Oct 16 19:10:10 2017

Roll ANGLE c3bc984..2d88e9b

https://chromium.googlesource.com/angle/angle.git/+log/c3bc984..2d88e9b

BUG= 602737 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I57e2799cd3ba16f3d48ac10e9e92861a401e531b
Reviewed-on: https://chromium-review.googlesource.com/721761
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509126}
[modify] https://crrev.com/32af0c846ce00672c60c6e643ff16fb05ea573c3/DEPS

Project Member

Comment 48 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eb616cc0a57a01d863144952c4e240c86f2b8af

commit 1eb616cc0a57a01d863144952c4e240c86f2b8af
Author: Geoff Lang <geofflang@chromium.org>
Date: Fri Oct 20 03:58:51 2017

Disable automatic extension requesting for unittests.

Due to a bug in the RequestExtension API, extensions were being enabled
without backend support in some cases.  Correctly test this in the
gpu_unittests by not requesting any extensions at initialization and
only enabling the ones to be tested in the tests.

BUG= 602737 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2cac0d493abaa96e523e2d63e173d881650b4928
Reviewed-on: https://chromium-review.googlesource.com/726942
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510324}
[modify] https://crrev.com/1eb616cc0a57a01d863144952c4e240c86f2b8af/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/1eb616cc0a57a01d863144952c4e240c86f2b8af/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/1eb616cc0a57a01d863144952c4e240c86f2b8af/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_drawing.cc
[modify] https://crrev.com/1eb616cc0a57a01d863144952c4e240c86f2b8af/gpu/command_buffer/service/gles2_cmd_decoder_unittest.h
[modify] https://crrev.com/1eb616cc0a57a01d863144952c4e240c86f2b8af/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

Status: Fixed (was: Started)

Sign in to add a comment