New issue
Advanced search Search tips

Issue 602735 link

Starred by 4 users
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: May 2016
Cc:
tkent@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

Make 'passive' EventListenerOptions not part of the event listener key

Project Member Reported by rbyers@chromium.org, Apr 12 2016 
From https://github.com/WICG/EventListenerOptions/issues/27 it sounds like the DOM spec is likely to be updated to say that the 'passive' option isn't part of the "key" (i.e. calling addEventListener a 2nd time with the same args except different "passive" should not add a 2nd listener).

Once the semantics are agreed upon, we should do an intent-to-ship and update our impl.    I think the compat risk should be very low.  But if we can get it merged into M-51 that would be nice (to eliminate any risk of developer confusion / compat issues).

Comment 1 by dtapu...@chromium.org, Apr 25 2016

Labels: -Type-Bug Type-Launch-OWP

Comment 2 by dtapu...@chromium.org, Apr 26 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/908fce48e7365aebede69d3275ad88817b8cf8b4

commit 908fce48e7365aebede69d3275ad88817b8cf8b4
Author: dtapuska <dtapuska@chromium.org>
Date: Fri May 06 14:26:53 2016

Change EventTarget callback APIs for add/RemoveEventListenerInternal.

It will be necessary to know what RegisteredEventListener was added or
removed with the AddEventListenerOptions IDL definition coming.

Change the way the API callbacks occur to pass the registeredEventListener
in.

No functional change is intended with this change.

BUG= 602735 

Review-Url: https://codereview.chromium.org/1942723004
Cr-Commit-Position: refs/heads/master@{#392055}

[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/animation/Animation.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/events/EventListenerMap.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/events/EventListenerMap.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/events/EventTarget.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/events/RegisteredEventListener.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/frame/LocalDOMWindow.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/core/svg/SVGElement.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/mediastream/MediaDevices.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/presentation/PresentationConnection.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp
[modify] https://crrev.com/908fce48e7365aebede69d3275ad88817b8cf8b4/third_party/WebKit/Source/modules/webmidi/MIDIInput.h
Project Member

Comment 4 by bugdroid1@chromium.org, May 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97

commit b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97
Author: dtapuska <dtapuska@chromium.org>
Date: Fri May 06 16:43:34 2016

Add AddEventListenerOptions addEventListenerOptions interface.

Change the 'passive' field from EventListenerOptions to
AddEventListenerOptions dictionary.

Change argument on addEventListener to take a AddEventListenerOptions
dictionary.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/k6v-puVgMLs/sftw2oJ7AAAJ

BUG= 602735 

Review-Url: https://codereview.chromium.org/1922093003
Cr-Commit-Position: refs/heads/master@{#392075}

[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_dispatch.html
[add] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_inequality.html
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/LayoutTests/fast/events/eventlisteneroptions/passive_query.html
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/core.gypi
[add] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/events/AddEventListenerOptions.idl
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/events/EventListenerMap.cpp
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/events/EventListenerMap.h
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/events/EventListenerOptions.idl
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/events/EventTarget.h
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/events/EventTarget.idl
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/events/RegisteredEventListener.h
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/b4cc79f5db2ea11ff1c865ce43bca1b035c6ef97/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

Comment 5 by dtapu...@chromium.org, May 6 2016

Labels: -M-51 M-52
Status: Fixed (was: Started)
►

Sign in to add a comment