Issue metadata
Sign in to add a comment
|
Audio of type HE-AAC stutters in canary using MSE
Reported by
don...@jwplayer.com,
Apr 12 2016
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.110 Safari/537.36 Example URL: http://qa.jwplayer.com/~todd/jw74-chromium.html Steps to reproduce the problem: 1. Load the first video stream, by clicking it 2. Listen to the audio What is the expected behavior? The audio should sound smooth What went wrong? The audio sounds choppy. Interestingly, if you seek around, then MSE seems to right itself out, and it will sound correctly. In Chrome Beta, it sounds fine. Did this work before? Yes It works in Chrome 50 Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? N/A Chrome version: 49.0.2623.110 Channel: canary OS Version: OS X 10.10.5 Flash Version: Shockwave Flash 21.0 r0
,
Apr 12 2016
DaleCur@ the fix you are referring to is merged into both Chrome 50 and Chrome 51. The bug reported here, is present in chrome 51 and not chrome 50.
,
Apr 12 2016
Oh, the bug report is not clear about that -- it just says M49. We'll take a look, this might be related to a recent security fix for this work.
,
Apr 12 2016
,
Apr 12 2016
,
Apr 12 2016
Whoops, this is a regression due to the security fix.
,
Apr 12 2016
Updating labels due to impact. +RBS for M51. Will mark for merge to M50 as well.
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4e5abab8d5d01bbb920bac53b0c9598412e4105 commit f4e5abab8d5d01bbb920bac53b0c9598412e4105 Author: dalecurtis <dalecurtis@chromium.org> Date: Wed Apr 13 01:36:00 2016 Fix audio glitch issue introduced by security fix for format changes. The patch was comparing the new sample rate value versus itself instead of the old sample rate value versus the new. BUG= 602731 TEST=no more stuttering. Review URL: https://codereview.chromium.org/1879143004 Cr-Commit-Position: refs/heads/master@{#386887} [modify] https://crrev.com/f4e5abab8d5d01bbb920bac53b0c9598412e4105/media/filters/ffmpeg_audio_decoder.cc
,
Apr 13 2016
,
Apr 13 2016
,
Apr 13 2016
,
Apr 14 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/199d980741e84ed8588b074d0ce214427f822a36 commit 199d980741e84ed8588b074d0ce214427f822a36 Author: Dale Curtis <dalecurtis@chromium.org> Date: Thu Apr 14 00:46:16 2016 Merge M51: "Fix audio glitch issue introduced by security fix for format changes." The patch was comparing the new sample rate value versus itself instead of the old sample rate value versus the new. BUG= 602731 TEST=no more stuttering. Review URL: https://codereview.chromium.org/1879143004 Cr-Commit-Position: refs/heads/master@{#386887} (cherry picked from commit f4e5abab8d5d01bbb920bac53b0c9598412e4105) Review URL: https://codereview.chromium.org/1886173002 . Cr-Commit-Position: refs/branch-heads/2704@{#46} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/199d980741e84ed8588b074d0ce214427f822a36/media/filters/ffmpeg_audio_decoder.cc
,
Apr 14 2016
Marking Merge-Request-50 for next stable refresh.
,
Apr 14 2016
[Automated comment] Less than a week to go before stable on M50, we might already have a stable candidate build. Manual review required.
,
Apr 15 2016
Confirmed that audio in Chrome 51 is working properly now.
,
Apr 15 2016
Approving the merge to M50 branch 2661 as this change is already baked in Canary and user confirmed that it is working fine on M51.
,
Apr 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e992c2efdceed3aecdd2e5fcaa5dd43e3639384 commit 0e992c2efdceed3aecdd2e5fcaa5dd43e3639384 Author: Matt Wolenetz <wolenetz@chromium.org> Date: Fri Apr 15 19:05:40 2016 Merge M50: "Fix audio glitch issue introduced by security fix for format changes." The patch was comparing the new sample rate value versus itself instead of the old sample rate value versus the new. BUG= 602731 TEST=no more stuttering. Review URL: https://codereview.chromium.org/1879143004 Cr-Commit-Position: refs/heads/master@{#386887} (cherry picked from commit f4e5abab8d5d01bbb920bac53b0c9598412e4105) Review URL: https://codereview.chromium.org/1886173002 . Cr-Commit-Position: refs/branch-heads/2704@{#46} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} (cherry picked from commit 199d980741e84ed8588b074d0ce214427f822a36) Review URL: https://codereview.chromium.org/1889273003 . Cr-Commit-Position: refs/branch-heads/2661@{#586} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/0e992c2efdceed3aecdd2e5fcaa5dd43e3639384/media/filters/ffmpeg_audio_decoder.cc
,
Apr 15 2016
Merged to M50.
,
Apr 20 2016
Verified the Issue on Mac 10.11.4, Win 7 and Ubuntu 14.04 using 50.0.2661.86 and 51.0.2704.20 and observed no glitches by following the steps from original report.Hence added the respective TE-Verified labels for the same. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dalecur...@chromium.org
, Apr 12 2016Status: Duplicate (was: Unconfirmed)