New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 602725 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Nov 2016
Cc:
█ fsam...@chromium.org
█ andyb...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

git cl format could fix braces

Project Member Reported by rjkroege@chromium.org, Apr 12 2016 
My understanding is that chrome style prefers:

if (true)
  callFunction();

is preferred over

if (true) {
  callFunction();
}

It would be nice if the pre-submit caught this mistake or (even better) git cl format fixed it.

Comment 1 by jpar...@google.com, Apr 13 2016

Cc: andyb...@chromium.org tandrii@chromium.org

Comment 2 by tandrii@chromium.org, Apr 13 2016

Cc: -tandrii@chromium.org
Labels: Infra-DX

Comment 3 by hinoka@chromium.org, Apr 13 2016

Labels: -Infra

Comment 4 by dtapu...@chromium.org, Aug 31 2016

Components: Infra

Comment 5 by bpastene@chromium.org, Sep 1 2016

Components: -Infra

Comment 6 Deleted

Comment 7 Deleted

Comment 8 by andyb...@chromium.org, Nov 11 2016

Components: Infra>SDK

Comment 9 by aga...@chromium.org, Nov 22 2016

Status: WontFix (was: Untriaged)
'git cl format' is literally just a call through to 'clang-format-diff.py', which is sourced directly from the llvm repo:
https://chromium.googlesource.com/chromium/llvm-project/cfe/tools/clang-format/+/master/clang-format-diff.py

So the change would need to be made there. As such, I'm going to mark this bug as WontFix, as I don't believe there's anything Infra can directly do about this. Maybe some of the LLVM folks know more?
►

Sign in to add a comment