The initial fix for Issue 578168 disabled text input state updates for RenderWidgetHostViewMac and caused issues such as Issue 601738 (IME was not working on Mac OSX). We should have tests spotting errors on this scale.
Adding a note to this CL
https://codereview.chromium.org/1894473002/
Can we have a test to prevent this? The issue was due to use of uninitialized bool in C++ leading to crashes in JNI conversion for Android.
Manually adding a CL related to this bug which missed to include the bug number when they were landed:
Confirm ongoing IME composition at the right render widget in response to mouse click/tap.
After CL: https://codereview.chromium.org/2092103002/ all IME result methods are
being routed to the right RenderWidget. Similarly, when an IME session is closed
on the browser side due to a click or tap, the right widget should be notifed
by receiving an IME confirm composition with empty text. Currently, this IPC is
sent to the tab's RenderWidget regardless of what the active widget is.
This CL will route the IPC to the right widget and adds a unit test for this purpose.
BUG= 578168
Review-Url: https://codereview.chromium.org/2116593002
Cr-Commit-Position: refs/heads/master@{#403273}
Manually adding a CL related to this bug which missed to include the bug number when they were landed:
[reland] Routing IME Result Calls to the Correct RenderWidgetHost (Aura Only)
This is a reland of the original CL: https://codereview.chromium.org/2045363002/ which was
reverted by this CL https://codereview.chromium.org/2095813002. The reason for the revert
was the regression of several SiteInstanceTests on Dr Memory bots.
The cause of the issue was that the newly introduced content unit tests in the original CL
were not deleting a RenderWidgetHostImpl which was keeping a RenderProcessHost alive. This
was interfering with the SiteInstanceTests which have explicit asserts on the number of
RenderProceessHosts alive.
BUG= 578168 , 622793 , 602723
Committed: https://crrev.com/8cba7886c3e170ca2dc324dbbd31b28dae623887
Cr-Commit-Position: refs/heads/master@{#401939}
Comment 1 by ekaramad@chromium.org
, Apr 13 2016