New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602714 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Add user actions metrics for media element controls usage

Project Member Reported by mlamouri@chromium.org, Apr 12 2016

Issue description

In order to help improve the controls, it would help having data regarding how much they are being used. It will help finding out what need to be improved but also could be used as control if a change to the UI is made.
 
Cc: liber...@chromium.org
Status: Started (was: Assigned)
https://codereview.chromium.org/1884573004
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea625d2ecbc66d8b47468c2662f399ed88e0eb22

commit ea625d2ecbc66d8b47468c2662f399ed88e0eb22
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Apr 14 17:02:26 2016

Add user actions to record media controls interaction.

This is recording interaction on:
- Play/Pause
- Play button overlay
- Fullscreen (enter/exit)
- Mute/Unmute
- Volume slider
- Scrubber
- Closed Caption (show/hide)
- Cast (built-in/overlay)

BUG= 602714 
R=isherman@chromium.org, philipj@opera.com

Review URL: https://codereview.chromium.org/1884573004

Cr-Commit-Position: refs/heads/master@{#387342}

[modify] https://crrev.com/ea625d2ecbc66d8b47468c2662f399ed88e0eb22/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/ea625d2ecbc66d8b47468c2662f399ed88e0eb22/tools/metrics/actions/actions.xml

Labels: Merge-Request-51
Let's get this in Beta, it's only metrics so it should be safe enough.
Labels: M-52

Comment 5 by tin...@google.com, Apr 15 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 6 by gov...@chromium.org, Apr 15 2016

Please merge your change before 5:00 PM PST on Monday (04/18) so we can take it in for next week M51 release.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f97f723874c3fc3c1997dcb0d3d448a7151046ab

commit f97f723874c3fc3c1997dcb0d3d448a7151046ab
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Apr 18 12:21:07 2016

Merge "Add user actions to record media controls interaction."

This is recording interaction on:
- Play/Pause
- Play button overlay
- Fullscreen (enter/exit)
- Mute/Unmute
- Volume slider
- Scrubber
- Closed Caption (show/hide)
- Cast (built-in/overlay)

BUG= 602714 
R=isherman@chromium.org, philipj@opera.com

Review URL: https://codereview.chromium.org/1884573004

Cr-Commit-Position: refs/heads/master@{#387342}
(cherry picked from commit ea625d2ecbc66d8b47468c2662f399ed88e0eb22)

Review URL: https://codereview.chromium.org/1894993003 .

Cr-Commit-Position: refs/branch-heads/2704@{#89}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/f97f723874c3fc3c1997dcb0d3d448a7151046ab/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/f97f723874c3fc3c1997dcb0d3d448a7151046ab/tools/metrics/actions/actions.xml

Status: Fixed (was: Started)

Sign in to add a comment