New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Compat

Blocked on:
issue 617877
issue 617881
issue 658997



Sign in to add a comment

Import serviceworker web-platform-tests

Project Member Reported by falken@chromium.org, Apr 12 2016

Issue description

We should get Chrome passing on serviceworker web-platform-tests.

We've started an effort to triage Firefox failures against Blink's tests, but I think that direction will duplicate much of Mozilla's work. Mozilla already modified Blink tests to work on Firefox, and are regularly upstreaming/downstreaming to web-platform-tests.

Here's the rough steps I think we should do:
1) Run Chrome on SW web platform tests <https://github.com/w3c/web-platform-tests> and triage the results.
2) For failures, either fix Chrome implementation or the tests, and upstream test changes.
3) Once those are done, run Firefox against Chrome's tests again. This should catch what tests we've added that aren't yet in web-platform-tests, and upstream them.
4) When the wptserve bot comes online (issue 581386) we should ensure serviceworker tests remain green. We could make this part of the weekly triage.

Eventually, we’ll have an upstream/downstream process and the wptserve tests should be run as part of CQ.
 
Cc: shimazu@chromium.org
Cc: -shimazu@chromium.org nhiroki@chromium.org
Labels: -Pri-3 Pri-2
Owner: shimazu@chromium.org
shimazu@, can you take a look at this?
Status: Started (was: Assigned)
I'm creating the compatibility checksheet using the web-patform-tests:
https://goo.gl/NmFGKZ

The test looks a bit older than the upstream spec, and there is a test causing crash. I'll take a look at the detail.
Blockedon: 617877
Blockedon: 617881
Blockedon: 617886
I'll create PRs for fixing the wpt tests which is shown as blue-bold on the checksheet.
And, I created an issue to ask how to run the tests which is much strict for the same-origin policy and SSL.

https://github.com/w3c/web-platform-tests/issues/3120

Remove ServiceWorkerGlobalScope.close(): https://github.com/w3c/web-platform-tests/pull/3126
What I'm planning to do for this issue is:

- Classify wpt tests into green and red (Mostly done; see the check sheet)
- Import green service-workers' tests on web-platform-tests into the chromium repository
  - Confirm these tests successfully run on chromium.fyi after wpt tests is enabled: http://crbug.com/581386
- Write a memo of how to run the wpt test manually
- Write a document to show how to update your tests on LayoutTests and w3c tests
- Dig into the red tests
I did the wpt test by run-webkit-tests with --enable-wptserve flag.
./third_party/WebKit/Tools/Scripts/run-webkit-tests --enable-wptserve -t Master imported/wpt/service-workers/service-worker 

Here is the result:
https://drive.google.com/open?id=0Bwd71LAFvG5SaWJNMl9EYXljMzg

I'll summarize this, add the Expectation and triage.
This is the result wpt test with run-webkit-tests on the correct origin:
https://drive.google.com/open?id=0Bwd71LAFvG5SV1IwYW9aN0dsZEU

After all of failing tests are triaged, I'm going to upload the w3c test into the imported/ directory.
https://docs.google.com/spreadsheets/d/1ifxj5xdLpEZtk3gWpuNC9iQZFO_7VMRS3JD3qQDAPfY/edit#gid=1738128813
Labels: -Pri-2 Pri-1
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4ed034738fe6c86c262e5cb0466b79ca84ab65f

commit a4ed034738fe6c86c262e5cb0466b79ca84ab65f
Author: shimazu <shimazu@chromium.org>
Date: Thu Oct 20 04:43:34 2016

Import w3c tests for the service workers

This patch imports wpt tests @357b83b809e3cbc7a1805e7c3ca108a7980d782f. Many
failures are left as is, so we should file each bugs after this lands.

BUG= 602693 , 618616 , 624278 ,571722,617886
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Debug --enable-wptserve imported/wpt/service-workers

Review-Url: https://chromiumcodereview.appspot.com/2415873002
Cr-Commit-Position: refs/heads/master@{#426405}

[modify] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/W3CImportExpectations
[modify] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/WPTServeExpectations
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-controlling-worker.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.py
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/activate-event-after-install-state-change.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/activation-after-registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/activation.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/active.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/appcache-ordering-main.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/claim-not-using-registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/claim-using-registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/client-navigate.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/client-navigate.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-get-cross-origin.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-get-cross-origin.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-get.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall-client-types.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/clients-matchall.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-disconnect.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-disconnect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-load.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-load.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-reload.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/controller-on-reload.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/extendable-event-async-waituntil.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/extendable-event-waituntil.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-cors-xhr.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-cors-xhr.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-csp.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-csp.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-after-navigation-within-page.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-network-error.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-redirect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-frame-resource.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-header-visibility.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-header-visibility.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-mixed-content-to-inscope.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-mixed-content-to-outscope.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-css-base-url.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-css-images.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-fallback.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-fallback.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-no-freshness-headers.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-redirect.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-redirect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-resources.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-resources.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-xhr.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-request-xhr.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-response-xhr.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-response-xhr.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-waits-for-activate.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/getregistration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/getregistrations.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/getregistrations.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/indexeddb.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/install-event-type.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/installing.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/interfaces.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-blobtype.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-blobtype.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-header.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/invalid-header.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/multiple-register.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/multiple-update.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigate-window.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigate-window.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/navigation-redirect.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/onactivate-script-error.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/performance-timeline.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/performance-timeline.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-to-client.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-to-client.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/ready.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/referer.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/referer.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-closed-window.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-default-scope.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-same-scope-different-script-url.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-wait-forever-in-install-worker.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/register-wait-forever-in-install-worker.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-end-to-end.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-events.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-iframe.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration-service-worker-attributes.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/registration.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/rejections.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/request-end-to-end.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/request-end-to-end.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resource-timing.https-expected.txt
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resource-timing.https.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/404.py
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.install.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.is-appcached.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.is-appcached.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/appcache-ordering.manifest
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/blank.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/claim-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigate-frame.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigate-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/client-navigated-frame.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-get-frame.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-get-other-origin.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-get-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-matchall-client-types-iframe.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-matchall-client-types-shared-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/clients-matchall-worker.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy-shared-worker-interceptor.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy-worker-interceptor.js
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy-worker-script.py
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy.html
[add] https://crrev.com/a4ed034738fe6c86c262e5cb0466b79ca84ab65f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/dummy.txt
Cc: qyears...@chromium.org
hmm... I took a look at a stdio on the waterfall dashboard, but all tests seems to be skipped.
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Linux%20-%20WPTServe/builds/5892

qyearsley@: Is there any method to override TestExpectation by WPTServeExpectations on the wptserve bots?
Hm, I see. Filed a bug:  bug 657869 .

One possible workaround would be to not skip them in the general TestExpectations file, but instead to have specific Pass/Failure/Timeout expectations for the tests without wptserve, e.g.:

# Most of these tests fail without wptserve
 crbug.com/602693  imported/wpt/service-workers [ Failure ]
# Some of the tests pass without wptserve
 crbug.com/602693  imported/wpt/service-workers/service-worker/rejections.https.html [ Pass ]
 crbug.com/602693  imported/wpt/service-workers/stub-3.1.1-service-worker-scope.html [ Pass ]
 crbug.com/602693  imported/wpt/service-workers/stub-3.1.2-service-worker-url.html [ Pass ]
 crbug.com/602693  imported/wpt/service-workers/stub-3.1.3-service-worker-state.html [ Pass ]
 crbug.com/602693  imported/wpt/service-workers/stub-3.1.4-service-worker-on-state-change.html [ Pass ]
# Some of the tests time out without wptserve
 crbug.com/602693  imported/wpt/service-workers/stub-3.1-service-worker-obj.html [ Timeout ]
 crbug.com/602693  imported/wpt/service-workers/service-worker/register-closed-window.https.html [ Timeout ]

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a97fb88d5ad4c437c60562d0083a87b898547a4

commit 6a97fb88d5ad4c437c60562d0083a87b898547a4
Author: shimazu <shimazu@chromium.org>
Date: Mon Oct 24 02:57:12 2016

Update expectations of imported/wpt/service-workers

As mentioned at  https://crbug.com/602693#c17  and  https://crbug.com/657869 ,
'[ Skip ]' in TestExpectations cannot be overwritten by WPTTestExpectations.
This patch changes '[ Skip ]' to '[ Failure ]' by default in TestExpectations
in order to run the w3c tests on WPTServe bots.

BUG= 602693 , 453190 , 624278 ,617886,571722, 618616 
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Debug imported/wpt/service-workers
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests --enable-wptserve -f -t Debug imported/wpt/service-workers

Review-Url: https://codereview.chromium.org/2441963002
Cr-Commit-Position: refs/heads/master@{#427010}

[modify] https://crrev.com/6a97fb88d5ad4c437c60562d0083a87b898547a4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6a97fb88d5ad4c437c60562d0083a87b898547a4/third_party/WebKit/LayoutTests/WPTServeExpectations

16 tests are now failing by timeout.
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Linux%20-%20WPTServe/builds/6013

qyearsley@:
I found this happened only when using Release build. Do you have any idea of possible causes?

Blockedon: 658997
shimazu@ can you repro locally?

Release build has a shorter timeout than the Debug build. If it only times out on Release it suggests the tests are indeed just slow.

Since this didn't happen on Blink's httpd, it might be that the wptserve server doesn't handle concurrent requests well.
Created another issue for c#19.
> Release build has a shorter timeout than the Debug build.
I didn't know about that, thanks!

Setting timeout longer works well.
./third_party/WebKit/Tools/Scripts/run-webkit-tests --time-out-ms=18000 --enable-wptserve -f -t Master imported/wpt/service-workers/service-worker

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74e0e4302ff524635ecbef0e45cecbda268e8552

commit 74e0e4302ff524635ecbef0e45cecbda268e8552
Author: shimazu <shimazu@chromium.org>
Date: Wed Oct 26 05:43:02 2016

Mark several w3c tests for service workers [ Slow ]

Several web platform tests introduced at https://crrev.com/2441963002 are passed
with longer timeout. This patch is to keep the bots green.

BUG= 602693 , 658997 

Review-Url: https://codereview.chromium.org/2443073002
Cr-Commit-Position: refs/heads/master@{#427600}

[modify] https://crrev.com/74e0e4302ff524635ecbef0e45cecbda268e8552/third_party/WebKit/LayoutTests/SlowTests

Summary: Import serviceworker web-platform-tests (was: Chrome should pass serviceworker web-platform-tests )
This is great! Retitling the bug as there's more work to getting all the tests passing :)
(it doesn't show up in the test expectations file, since we are using -expected.txt files to track failures)
Project Member

Comment 27 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1f3fe30040eca73500617f2a401ef2299e2f87f

commit d1f3fe30040eca73500617f2a401ef2299e2f87f
Author: falken <falken@chromium.org>
Date: Wed Feb 22 10:15:22 2017

Gardening: Remove external/wpt/service-workers/stub* expectations.

The test runner already ignores stub tests.

BUG= 602693 

Review-Url: https://codereview.chromium.org/2713593002
Cr-Commit-Position: refs/heads/master@{#451972}

[modify] https://crrev.com/d1f3fe30040eca73500617f2a401ef2299e2f87f/third_party/WebKit/LayoutTests/TestExpectations

Blockedon: -617886

Sign in to add a comment