New issue
Advanced search Search tips

Issue 602690 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

[remoting host] Enable running the host from ToT checkout with GN.

Project Member Reported by lambroslambrou@chromium.org, Apr 12 2016

Issue description

The script at src/remoting/host/linux/linux_me2me_host.py
will look in out/Debug and out/Release for the host executable.
We should make this work for GN builds in out/some-random-directory.

Suggestion:
* Have GN copy this script to the build output directory.
* Have the script look in its own directory for the host executable.
Then users can run the copied script.

 
Status: Started (was: Untriaged)
Owner: lambroslambrou@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dfafe066c1f16fde58ac93a63c8e6218101e3b2

commit 2dfafe066c1f16fde58ac93a63c8e6218101e3b2
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Wed Apr 20 00:27:19 2016

[remoting host] Copy Linux Me2Me script for GN builds

On Linux, this adds a new build target which copies the
linux_me2me_host.py script to a remoting/ subdirectory
of the GN output directory. It also creates a wrapper
script in the same place to run the remoting_me2me_host
binary.

This enables a developer to do:
ninja -C out/foo remoting_dev_me2me_host
and then:
out/foo/remoting/chrome-remote-desktop-host --start
to run the newly-built host.

BUG= 602690 

Review URL: https://codereview.chromium.org/1885483003

Cr-Commit-Position: refs/heads/master@{#388376}

[modify] https://crrev.com/2dfafe066c1f16fde58ac93a63c8e6218101e3b2/remoting/host/BUILD.gn
[modify] https://crrev.com/2dfafe066c1f16fde58ac93a63c8e6218101e3b2/remoting/host/linux/linux_me2me_host.py
[add] https://crrev.com/2dfafe066c1f16fde58ac93a63c8e6218101e3b2/remoting/host/linux/remoting_me2me_host_wrapper.sh

Status: Fixed (was: Started)

Sign in to add a comment