New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602688 link

Starred by 17 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on: View detail
issue angleproject:1463
issue angleproject:1621
issue angleproject:1824
issue angleproject:1874
issue 754710
issue 766918
issue angleproject:2188
issue angleproject:2196
issue angleproject:2894
issue angleproject:891
issue 602737
issue 602740
issue 665518
issue angleproject:1353
issue angleproject:1354
issue angleproject:1356
issue angleproject:1366
issue angleproject:1377
issue angleproject:1378
issue angleproject:1382
issue angleproject:1518
issue 665520
issue 665521
issue angleproject:1634
issue angleproject:1635
issue 668223
issue angleproject:1638
issue angleproject:1639
issue 671217
issue angleproject:1649
issue 671290
issue angleproject:1675
issue angleproject:1685
issue angleproject:1688
issue angleproject:1708
issue angleproject:1715
issue angleproject:1719
issue angleproject:1721
issue 682745
issue angleproject:1815
issue angleproject:1816
issue angleproject:1817
issue angleproject:1819
issue angleproject:1820
issue angleproject:1821
issue angleproject:1822
issue angleproject:1823
issue angleproject:1825
issue 693233
issue angleproject:1897
issue angleproject:1954
issue angleproject:1958
issue angleproject:1985
issue angleproject:1988
issue angleproject:1989
issue angleproject:1991
issue angleproject:1998
issue angleproject:1999
issue angleproject:2009
issue angleproject:2012
issue angleproject:2013
issue angleproject:2015
issue angleproject:2016
issue angleproject:2017
issue angleproject:2019
issue angleproject:2021
issue angleproject:2048
issue angleproject:2070
issue 736537
issue 738513
issue 749748
issue 750813
issue 754000
issue 754008
issue 770696
issue 775226
issue angleproject:2192
issue angleproject:2195
issue angleproject:2197
issue angleproject:2198
issue 787063
issue 825906
issue 871955
issue 892288

Blocking:
issue 738568
issue 829541
issue 832028



Sign in to add a comment

Create a passthrough command buffer implementation

Project Member Reported by geoffl...@chromium.org, Apr 12 2016

Issue description

As part of making ANGLE the only GLES implementation used by chromium, a non-validating and non-state tracking command buffer is needed to improve performance on Windows and maintain performance on other operating systems.

This command buffer will simply forward GLES calls to ANGLE wherever possible while still performing security checks. 
 
Showing comments 112 - 211 of 211 Older
Blockedon: angleproject:2015
Blockedon: angleproject:2016
Blockedon: angleproject:2017
Project Member

Comment 115 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ad7f6d7a7478d21b30a505dd00e473a609b687d

commit 7ad7f6d7a7478d21b30a505dd00e473a609b687d
Author: cwallez <cwallez@chromium.org>
Date: Mon May 01 16:22:54 2017

Passthrough CmdDecoder: Reset unpack state on some TexImage

The command buffer client handles all the unpack parameters but
alignment for non-compressed texture uploads from client data.
Resetting the unpack state was handled transparently on the
service-side. This implements the resetting in the passthrough cmd
decoder too.

This makes the following tests pass with the passthrough command buffer:
 - conformance2/textures/misc/tex-unpack-params
 - deqp/functional/gles3/texturespecification/teximage2d_unpack_params
 - deqp/functional/gles3/texturespecification/teximage3d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage2d_unpack_params
 - deqp/functional/gles3/texturespecification/texsubimage3d_unpack_params

BUG=chromium:602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2844393004
Cr-Commit-Position: refs/heads/master@{#468322}

[modify] https://crrev.com/7ad7f6d7a7478d21b30a505dd00e473a609b687d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/7ad7f6d7a7478d21b30a505dd00e473a609b687d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Blockedon: angleproject:2019
Blockedon: angleproject:1958
Blockedon: angleproject:2021
Project Member

Comment 119 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/290bb6a21076dfeda8103206fe39a61ab9b5ed25

commit 290bb6a21076dfeda8103206fe39a61ab9b5ed25
Author: geofflang <geofflang@chromium.org>
Date: Tue May 02 21:41:22 2017

Update passthrough command buffer WebGL expectations.

TBR=zmo@chromium.org

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2850583002
Cr-Commit-Position: refs/heads/master@{#468782}

[modify] https://crrev.com/290bb6a21076dfeda8103206fe39a61ab9b5ed25/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 120 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/488e3c4fa6071dbcae2d58791ab2dced0744d7cb

commit 488e3c4fa6071dbcae2d58791ab2dced0744d7cb
Author: geofflang <geofflang@chromium.org>
Date: Wed May 03 15:01:26 2017

Re-add expected failure of WebGL test renderbuffer-initialization.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857983002
Cr-Commit-Position: refs/heads/master@{#468972}

[modify] https://crrev.com/488e3c4fa6071dbcae2d58791ab2dced0744d7cb/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 121 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bcba1f80eb3c41b069af63200a2640e2bff7b40

commit 7bcba1f80eb3c41b069af63200a2640e2bff7b40
Author: geofflang <geofflang@chromium.org>
Date: Thu May 04 15:58:16 2017

Re-add expected failure of WebGL test get-extension.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2866453002
Cr-Commit-Position: refs/heads/master@{#469346}

[modify] https://crrev.com/7bcba1f80eb3c41b069af63200a2640e2bff7b40/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 122 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad504b2f5de06ad7e437d0fc8378f7f126ef88ed

commit ad504b2f5de06ad7e437d0fc8378f7f126ef88ed
Author: geofflang <geofflang@chromium.org>
Date: Thu May 25 17:49:40 2017

Make sure to only call valid GL query functions when processing queries.

Both glGetQueryObjectiv and glGetQueryObjectui64v are not available
without disjoint timer queries on OpenGL ES.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2886253003
Cr-Commit-Position: refs/heads/master@{#474694}

[modify] https://crrev.com/ad504b2f5de06ad7e437d0fc8378f7f126ef88ed/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Project Member

Comment 123 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f6d93dd40c218bea0718132b326146ce177c16d

commit 1f6d93dd40c218bea0718132b326146ce177c16d
Author: geofflang <geofflang@chromium.org>
Date: Thu May 25 17:53:26 2017

Initialize remaining passthrough command decoder caps.

 - Implement the PostSubBufferCHROMIUM command, ANGLE's surfaces support it.
 - WebGL disjoint timer queries now work.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2886263005
Cr-Commit-Position: refs/heads/master@{#474696}

[modify] https://crrev.com/1f6d93dd40c218bea0718132b326146ce177c16d/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/1f6d93dd40c218bea0718132b326146ce177c16d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/1f6d93dd40c218bea0718132b326146ce177c16d/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Blockedon: angleproject:2048
Project Member

Comment 125 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b36048fa31af260d3cfac960f986dba1b3acd7b1

commit b36048fa31af260d3cfac960f986dba1b3acd7b1
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Jun 05 20:20:01 2017

Don't require OES_texture_float to check for OES_texture_float_linear.

ANGLE is able to dynamically enable the OES_texture_float_linear extension
before OES_texture_float but the command buffer would not expose the
OES_texture_float_linear extension string.

This caused failures in various WebGL extension tests when the initial
extension could be enabled because it was in the requestable set but could
not be queried again because it did not appear in the extension strings after
being enabled.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I19181e24081dd094c255f7129f04cac72d33f9d4
Reviewed-on: https://chromium-review.googlesource.com/521746
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477067}
[modify] https://crrev.com/b36048fa31af260d3cfac960f986dba1b3acd7b1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/b36048fa31af260d3cfac960f986dba1b3acd7b1/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/b36048fa31af260d3cfac960f986dba1b3acd7b1/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Project Member

Comment 126 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/046dc9a43e7e2560e0636283c7a89425babb63d1

commit 046dc9a43e7e2560e0636283c7a89425babb63d1
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Jun 07 15:04:38 2017

Add tracing for the passthrough command decoder.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I288b06583392767d19966740c93058e94ce2dc48
Reviewed-on: https://chromium-review.googlesource.com/521788
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477644}
[modify] https://crrev.com/046dc9a43e7e2560e0636283c7a89425babb63d1/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/046dc9a43e7e2560e0636283c7a89425babb63d1/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/046dc9a43e7e2560e0636283c7a89425babb63d1/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 127 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f44323edbf586dc2077aad835da9aec7bc3e5f26

commit f44323edbf586dc2077aad835da9aec7bc3e5f26
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Jun 07 19:52:05 2017

Handle context loss and robustness in the passthrough command decoder.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I89bfb0885f279b044b3fa865aa24b8b683c4a710
Reviewed-on: https://chromium-review.googlesource.com/521365
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477737}
[modify] https://crrev.com/f44323edbf586dc2077aad835da9aec7bc3e5f26/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/f44323edbf586dc2077aad835da9aec7bc3e5f26/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/f44323edbf586dc2077aad835da9aec7bc3e5f26/gpu/command_buffer/service/gl_utils.cc
[modify] https://crrev.com/f44323edbf586dc2077aad835da9aec7bc3e5f26/gpu/command_buffer/service/gl_utils.h
[modify] https://crrev.com/f44323edbf586dc2077aad835da9aec7bc3e5f26/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/f44323edbf586dc2077aad835da9aec7bc3e5f26/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/f44323edbf586dc2077aad835da9aec7bc3e5f26/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/f44323edbf586dc2077aad835da9aec7bc3e5f26/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 128 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eb77dd10e8db4313b37a4fe6cde7d89a4a84914

commit 5eb77dd10e8db4313b37a4fe6cde7d89a4a84914
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Jun 12 15:37:30 2017

Update WebGL expectations for the passthrough command decoder.

TBR=zmo@chromium.org

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4b7bf4b3e28c79fb2c64d730ea063fac0b7821cf
Reviewed-on: https://chromium-review.googlesource.com/531105
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478631}
[modify] https://crrev.com/5eb77dd10e8db4313b37a4fe6cde7d89a4a84914/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 129 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24

commit 9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Jun 12 20:31:20 2017

Refactor the gpu command decoder choice to a single funtion.

This allows us to enable and disable the passthrough command decoder
globally with small changes.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I56c9cdea929f62748575fc67016e6de8fa03ac5f
Reviewed-on: https://chromium-review.googlesource.com/531344
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478744}
[modify] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/gpu/command_buffer/service/gpu_switches.cc
[modify] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/gpu/command_buffer/service/gpu_switches.h
[modify] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/ui/gl/BUILD.gn
[modify] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/ui/gl/gl_switches.cc
[modify] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/ui/gl/gl_switches.h
[add] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/ui/gl/gl_utils.cc
[add] https://crrev.com/9d2ed1642ac8b258c42f727cd24d7fe37ba2bf24/ui/gl/gl_utils.h

Blockedon: angleproject:2070
Project Member

Comment 131 by bugdroid1@chromium.org, Jun 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6653466e313dc83a33ec049a6eef95a31dda435

commit d6653466e313dc83a33ec049a6eef95a31dda435
Author: Geoff Lang <geofflang@chromium.org>
Date: Sat Jun 17 13:43:04 2017

Skip WebGL2 video tests on the passthrough command buffer.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5f16c60d3e3de5a8b85a8e1f0a654ebc2709d1e3
Reviewed-on: https://chromium-review.googlesource.com/538886
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480301}
[modify] https://crrev.com/d6653466e313dc83a33ec049a6eef95a31dda435/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Blockedon: angleproject:1897
Project Member

Comment 133 by bugdroid1@chromium.org, Jun 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05847d23a181fa16b77dc921dcf955a1f2af540c

commit 05847d23a181fa16b77dc921dcf955a1f2af540c
Author: Khushal <khushalsagar@chromium.org>
Date: Sat Jun 24 00:54:21 2017

Revert "Implement DoFlushDriverCachesCHROMIUM in the passthrough cmd decoder."

This reverts commit c631bac13c7a546353f59b361ce758bfffa8cb93.

Reason for revert: Speculative revert for WebglConformance_deqp_functional_gles3_texturefiltering failure on Win. See  crbug.com/736537 .

Original change's description:
> Implement DoFlushDriverCachesCHROMIUM in the passthrough cmd decoder.
> 
> This was the last source of NOTIMPLEMENTED spam when running tests.
> 
> BUG=602688
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Iaffc7761baa341ff1585974367b7185b3d41bd81
> Reviewed-on: https://chromium-review.googlesource.com/538082
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480825}

TBR=zmo@chromium.org,geofflang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 602688
Change-Id: Ieb420651cd67c3fb564d2e2ed8131a04c5f7e97e
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/546846
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482098}
[modify] https://crrev.com/05847d23a181fa16b77dc921dcf955a1f2af540c/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 134 by bugdroid1@chromium.org, Jun 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa32d0ed6c515bd8e92c311a27d198b803369e6

commit aaa32d0ed6c515bd8e92c311a27d198b803369e6
Author: Khushal <khushalsagar@chromium.org>
Date: Sat Jun 24 04:57:47 2017

Revert "Revert "Implement DoFlushDriverCachesCHROMIUM in the passthrough cmd decoder.""

This reverts commit 05847d23a181fa16b77dc921dcf955a1f2af540c.

Reason for revert: It was unnecessary to revert this.

Original change's description:
> Revert "Implement DoFlushDriverCachesCHROMIUM in the passthrough cmd decoder."
> 
> This reverts commit c631bac13c7a546353f59b361ce758bfffa8cb93.
> 
> Reason for revert: Speculative revert for WebglConformance_deqp_functional_gles3_texturefiltering failure on Win. See  crbug.com/736537 .
> 
> Original change's description:
> > Implement DoFlushDriverCachesCHROMIUM in the passthrough cmd decoder.
> > 
> > This was the last source of NOTIMPLEMENTED spam when running tests.
> > 
> > BUG=602688
> > 
> > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > Change-Id: Iaffc7761baa341ff1585974367b7185b3d41bd81
> > Reviewed-on: https://chromium-review.googlesource.com/538082
> > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> > Commit-Queue: Geoff Lang <geofflang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#480825}
> 
> TBR=zmo@chromium.org,geofflang@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 602688
> Change-Id: Ieb420651cd67c3fb564d2e2ed8131a04c5f7e97e
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/546846
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#482098}

TBR=zmo@chromium.org,geofflang@chromium.org,khushalsagar@chromium.org

Change-Id: I0ce7b94607f4d03d2a023016c73677321a8b0f6e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 602688
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/547197
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482137}
[modify] https://crrev.com/aaa32d0ed6c515bd8e92c311a27d198b803369e6/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Comment 135 by kbr@chromium.org, Jun 26 2017

Blockedon: 736537
Blockedon: 738513
Project Member

Comment 137 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4002f02934aae5a770a331cd66122fdcfbf91120

commit 4002f02934aae5a770a331cd66122fdcfbf91120
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Jul 04 17:04:43 2017

Update the WebGL2 conformance expectations for the passthrough cmd decoder.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688
BUG= 668223 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic670f4a79adffe377d77dad79856f6aea9394746
Reviewed-on: https://chromium-review.googlesource.com/558677
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484132}
[modify] https://crrev.com/4002f02934aae5a770a331cd66122fdcfbf91120/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 138 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba4ed7d9679f918fa425f752efea6d9a0dd9e837

commit ba4ed7d9679f918fa425f752efea6d9a0dd9e837
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Jul 12 17:24:36 2017

Reset GL_PACK_ROW_LENGTH to 0 before calls to glReadPixels.

The client side of the command buffer handles emulation of the
GL_PACK_ROW_LENGTH parameter.

TEST=conformance2/reading/read-pixels-pack-parameters.html

BUG=602688

Change-Id: Id3415d56c565504b423f2a32d91d865274667037
Reviewed-on: https://chromium-review.googlesource.com/567430
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486005}
[modify] https://crrev.com/ba4ed7d9679f918fa425f752efea6d9a0dd9e837/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/ba4ed7d9679f918fa425f752efea6d9a0dd9e837/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 139 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65e3264e99e0407703e13f06f2e8b7b716da15c0

commit 65e3264e99e0407703e13f06f2e8b7b716da15c0
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Jul 19 17:43:33 2017

Supress Intel specific failures in WebGL2 with the passthrough cmd decoder.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8d33707758586b53d0459d0e5ddc04396e5b5b93
Reviewed-on: https://chromium-review.googlesource.com/578047
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487906}
[modify] https://crrev.com/65e3264e99e0407703e13f06f2e8b7b716da15c0/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 140 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af73d5e0298e306084b947ddb0d33ee6e27026e8

commit af73d5e0298e306084b947ddb0d33ee6e27026e8
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Jul 20 20:54:52 2017

Skip the framebuffer-state-restoration test on Linux Intel.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2490f77aadb5866a8af0d34ce16673e7be06d2b9
Reviewed-on: https://chromium-review.googlesource.com/580489
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488397}
[modify] https://crrev.com/af73d5e0298e306084b947ddb0d33ee6e27026e8/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Blockedon: 749748
Blockedon: -angleproject:2014
Blockedon: -angleproject:1726
Blockedon: -angleproject:1723
Blockedon: -angleproject:1722
Blockedon: -angleproject:1720
Blockedon: -angleproject:1718
Blockedon: -angleproject:1717
Blockedon: -angleproject:1716
Blockedon: -angleproject:1714
Blockedon: -angleproject:1713
Project Member

Comment 152 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0332327c4bf5e85e9aab3d38fa7cfe817fdcf25

commit e0332327c4bf5e85e9aab3d38fa7cfe817fdcf25
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Jul 27 23:03:58 2017

On share group destruction, don't explicitly delete ref-counted textures.

Only delete textures that are not represented by a TexturePassthrough
object, ie textures that have been generated by never bound.  Add a DCHECK
that it's not possible to get into a state where a texture is tracked with
a TexturePassthrough but the driver does not believe the texture exists.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8e48272e813eb879fd8073925ac7bb4b74ddf99a
Reviewed-on: https://chromium-review.googlesource.com/585575
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490059}
[modify] https://crrev.com/e0332327c4bf5e85e9aab3d38fa7cfe817fdcf25/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/e0332327c4bf5e85e9aab3d38fa7cfe817fdcf25/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h

Blockedon: 750813
Blockedon: 754000
Blockedon: 754008
Project Member

Comment 156 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d390c7afbb263a681f8aadfce54cbd20b0f10a65

commit d390c7afbb263a681f8aadfce54cbd20b0f10a65
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Aug 10 17:43:59 2017

Don't expect specific errors for TextureStorageTest.InternalFormatBleedingToTexImage

ANGLE generates an INVALID_OPERATION error in this case.

BUG=602688
BUG= 754008 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I913ede27f3a4c9b729f584abaeed020418c9ac62
Reviewed-on: https://chromium-review.googlesource.com/608816
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493451}
[modify] https://crrev.com/d390c7afbb263a681f8aadfce54cbd20b0f10a65/gpu/command_buffer/tests/gl_texture_storage_unittest.cc

Project Member

Comment 157 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eefb733c920914518f269aded510206ce49376b9

commit eefb733c920914518f269aded510206ce49376b9
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Aug 10 17:51:47 2017

Copy the workarounds from the context group when initializing.

Each passthrough command decoder has a unique FeatureInfo to handle
requested extensions but was not using the workarounds from the context
group.

TEST=GLTest.FeatureFlagsMatchCapabilities

BUG= 754008 
BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0d050818fed7f1982b12ea66d54bc62dad97f88b
Reviewed-on: https://chromium-review.googlesource.com/608808
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493454}
[modify] https://crrev.com/eefb733c920914518f269aded510206ce49376b9/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Project Member

Comment 158 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062c3d87579761d0a076933afca57d841914eea8

commit 062c3d87579761d0a076933afca57d841914eea8
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Aug 10 19:06:33 2017

Update tracked buffer bindings on glBindBufferBase and glBindBufferRange.

When buffers are bound to the indexed binding points, they are also bound
to the generic binding points.

TEST=ES3MapBufferRangeTest

BUG= 754008 
BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic626961d556d155d9d1b2cf584ac57c91e7f4496
Reviewed-on: https://chromium-review.googlesource.com/609266
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493485}
[modify] https://crrev.com/062c3d87579761d0a076933afca57d841914eea8/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Blockedon: 754710
Project Member

Comment 160 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/619081b145eb7b4ac6d944d517ae3de83efc2c69

commit 619081b145eb7b4ac6d944d517ae3de83efc2c69
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Aug 31 19:23:31 2017

Only create the passthrough command decoder if it is supported.

Check the available EGL extensions to determine if it is possible to
support the passthrough command decoder and only create one if it is
both requested and supportable.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6a38402088148a000d57cf05b8d7a70d32e60838
Reviewed-on: https://chromium-review.googlesource.com/621424
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498949}
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/content/public/browser/gpu_utils.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/service/context_group.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/service/context_group.h
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/service/context_group_unittest.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/service/service_discardable_manager_unittest.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/service/service_utils.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/service/service_utils.h
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/gles2_conform_support/egl/context.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/ipc/service/gpu_command_buffer_stub.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/ui/gl/gl_context_egl.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/619081b145eb7b4ac6d944d517ae3de83efc2c69/ui/gl/gl_surface_egl.h

Comment 161 by kbr@chromium.org, Sep 20 2017

Blockedon: 766918
Project Member

Comment 162 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba

commit 7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba
Author: Geoff Lang <geofflang@chromium.org>
Date: Sat Sep 23 17:56:02 2017

Switch ANGLE's robust resource init extension to a context creation attrib.

Previously this extension was a display creation attribute but it is
easier to detect and control as a context creation attribute.

This patch leaves both paths intact, the old path will be removed once
the updated versionof ANGLE is rolled into Chrome.

BUG= angleproject:1635 
BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I23951db13f4657c664ec717d7c56690b725c3313
Reviewed-on: https://chromium-review.googlesource.com/679318
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503944}
[modify] https://crrev.com/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba/gpu/command_buffer/service/service_utils.cc
[modify] https://crrev.com/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba/ui/gl/gl_bindings.h
[modify] https://crrev.com/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba/ui/gl/gl_context.h
[modify] https://crrev.com/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba/ui/gl/gl_context_egl.cc
[modify] https://crrev.com/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/7f82ef49abf63749fedadf2c4f9da3dbcbcb37ba/ui/gl/gl_surface_egl.h

Blockedon: 770696
Project Member

Comment 164 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c68aa9b8375467795a6fd83c8c2408d730d9874a

commit c68aa9b8375467795a6fd83c8c2408d730d9874a
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Oct 02 15:00:03 2017

WATCHLISTS: Add cwallez and geofflang for passthrough cmd decoder

BUG=602688

Change-Id: I5a6184acea335f4d1add8ce11caf4ce33571a77c
Reviewed-on: https://chromium-review.googlesource.com/693298
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505612}
[modify] https://crrev.com/c68aa9b8375467795a6fd83c8c2408d730d9874a/WATCHLISTS

Project Member

Comment 165 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eef8b8277f9ea953093ff87f56226b4ce5b03328

commit eef8b8277f9ea953093ff87f56226b4ce5b03328
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Oct 02 21:58:42 2017

Passthrough cmd decoder: Make all accesses on top of handlers

Forcing the structure of the handlers to be like this will help avoid
TOCTOU errors.

BUG=602688

Change-Id: I50626770f3f123c40f45680661d97ca9e1416129
Reviewed-on: https://chromium-review.googlesource.com/695842
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505807}
[modify] https://crrev.com/eef8b8277f9ea953093ff87f56226b4ce5b03328/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc

Project Member

Comment 166 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f4b0b8be1c25d2a525da1fd2c30f419a6d19df6

commit 5f4b0b8be1c25d2a525da1fd2c30f419a6d19df6
Author: Corentin Wallez <cwallez@chromium.org>
Date: Tue Oct 03 22:49:55 2017

Passthrough cmd decoder: remove tautological error handling

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6eae977bbc1745475738c3348fa3ced1bc263298
Reviewed-on: https://chromium-review.googlesource.com/698605
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506217}
[modify] https://crrev.com/5f4b0b8be1c25d2a525da1fd2c30f419a6d19df6/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc

Project Member

Comment 167 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/c3bc984156967837f0b17b866aca0b12a2edf0e6

commit c3bc984156967837f0b17b866aca0b12a2edf0e6
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu Oct 12 17:20:41 2017

WebGLCompatibility: test for vertex OOB caused by indices

BUG=602688

Change-Id: I49a1a9b3753159c91058a7754534383fbc8a778e
Reviewed-on: https://chromium-review.googlesource.com/713740
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/c3bc984156967837f0b17b866aca0b12a2edf0e6/src/tests/gl_tests/WebGLCompatibilityTest.cpp

Project Member

Comment 168 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/5bd9f2c19ea5f2e893ba7aeebef9e3c217f084bb

commit 5bd9f2c19ea5f2e893ba7aeebef9e3c217f084bb
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Thu Oct 12 19:19:31 2017

Roll skia/third_party/externals/angle2/ 6aee8620c..c3bc98415 (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/6aee8620c51f..c3bc98415696

$ git log 6aee8620c..c3bc98415 --date=short --no-merges --format='%ad %ae %s'
2017-10-11 cwallez WebGLCompatibility: test for vertex OOB caused by indices
2017-10-10 oetuaho Recognize more non-fallthrough cases in switch/case

Created with:
  roll-dep skia/third_party/externals/angle2
BUG=602688,772695


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=reed@google.com

Change-Id: Ic1d63b3e6126cc6e32119eef2855ec3908308fcf
Reviewed-on: https://skia-review.googlesource.com/59120
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/5bd9f2c19ea5f2e893ba7aeebef9e3c217f084bb/DEPS

Project Member

Comment 169 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fba1215cdc4fb726f8412970e47ca7f632c9156

commit 2fba1215cdc4fb726f8412970e47ca7f632c9156
Author: Frank Henigman <fjhenigman@chromium.org>
Date: Thu Oct 12 22:55:36 2017

Roll ANGLE 852fe87..c3bc984

https://chromium.googlesource.com/angle/angle.git/+log/852fe87..c3bc984

BUG=chromium:772695,602688

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I5cd6ab1e70fe4510b1d13e71b7d04a24a86e40b7
Reviewed-on: https://chromium-review.googlesource.com/716858
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508517}
[modify] https://crrev.com/2fba1215cdc4fb726f8412970e47ca7f632c9156/DEPS

Project Member

Comment 170 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f

commit d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Oct 12 23:31:38 2017

Remove references to old display-level robust resource init extension.

Remove the passthrough command decoder flag from the gl layer.

BUG= angleproject:1635 
BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie32bbce062f5ed3a5480fb06f7f283e895c97157
Reviewed-on: https://chromium-review.googlesource.com/703634
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508535}
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/content/public/browser/gpu_utils.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/gpu/command_buffer/service/gpu_switches.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/gpu/command_buffer/service/gpu_switches.h
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/gpu/command_buffer/service/service_utils.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/gpu/command_buffer/service/service_utils.h
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/ui/gl/gl_context_egl.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/ui/gl/gl_surface_egl.h
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/ui/gl/gl_switches.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/ui/gl/gl_switches.h
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/ui/gl/gl_utils.cc
[modify] https://crrev.com/d72f1e979c25e00371ba92cf4a22a8d11e4ecd3f/ui/gl/gl_utils.h

Project Member

Comment 171 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a24eadedcaf0ccdaac8648c812dffad37b9fce5

commit 1a24eadedcaf0ccdaac8648c812dffad37b9fce5
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Fri Oct 13 22:15:45 2017

Roll src/third_party/skia/ e60ca7eae..f543a60ef (46 commits; 2 trivial rolls)

https://skia.googlesource.com/skia.git/+log/e60ca7eae432..f543a60ef06a

$ git log e60ca7eae..f543a60ef --date=short --no-merges --format='%ad %ae %s'
2017-10-13 fmalita [SVGDom] Add 'stroke-dasharray' support
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 40dbdd6c7..2bdbf788b (1 commit)
2017-10-13 abarth Add the ability to customize skia's settings in gn
2017-10-13 kjlubick Fix asset version detection
2017-10-13 bsalomon Implemenet onStealBackendTexture in GrMtlTexture
2017-10-13 reed remove dead code -- older than min picture version
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 3755c48d1..40dbdd6c7 (1 commit)
2017-10-13 halcanary platform_tools/android/bin/android_gdbserver: fix error
2017-10-12 bungeman Make SkTypeface::Style and FromOldStyle private.
2017-10-09 egdaniel Add support for allocating mips inside of ColorSpaceXormImageGenerator
2017-10-11 benjaminwagner Add Win Clang ANGLE test and perf jobs.
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 429756442..3755c48d1 (1 commit)
2017-10-13 reed remove dead code for getSize, getSafeSize, etc.
2017-10-13 mtklein Back out new SkColorSpaceXform pipeline.
2017-10-13 reed Revert "move SkMatrix anonymous affine enum to private"
2017-10-13 kjlubick Modify skpbench to use newer adb version
2017-10-13 kjlubick Adjust blacklist for IB2
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 41200d21b..429756442 (1 commit)
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 91c8de883..41200d21b (1 commit)
2017-10-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 22d7f1f3f..91c8de883 (1 commit)
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ f6d242edb..22d7f1f3f (1 commit)
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ c3bc98415..f6d242edb (1 commit)
2017-10-12 ericrk MakeBackendTextureFromSkImage
2017-10-12 caryclark move SkMatrix anonymous affine enum to private
2017-10-12 egdaniel Handle coverage for hairline lines with sub pixel lengths correctly on GPU
2017-10-12 reed remove dead flag
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 6aee8620c..c3bc98415 (2 commits)
2017-10-12 kjlubick Fix Chromebook output step and skpbench
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ d736cccf0..6aee8620c (1 commit)
2017-10-11 mtklein check unpremul scale directly against infinity
2017-10-12 kjlubick Update to adb 1.0.35
2017-10-12 fmalita [SVGDom] Add 'visibility' support
2017-10-12 egdaniel Add flag on GrBackendTexture to say whether texture is mipped or not
2017-10-12 egdaniel Fix Metal build
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 923ecef6b..d736cccf0 (2 commits)
2017-10-12 egdaniel Use enum to track MipMapsStatus throughout Texture creation
2017-10-12 angle-deps-roller Roll skia/third_party/externals/angle2/ d92e93b8c..923ecef6b (1 commit)
2017-10-12 jvanverth Fix assert in GrSmallPathRenderer tickled by GLProgramsTest
2017-10-12 fmalita Plumb more SkPaintFilterCanvas virtuals
2017-10-11 mtklein abort SkRRect::transform() before dst->scaleRadii() asserts
2017-10-12 hcm Update Skia milestone to 64
2017-10-12 stani Implement getGrContext in SkPaintFilterCanvas
2017-10-12 jvanverth Batch better in GrSmallPathRenderer and add perspective support.
2017-10-11 robertphillips Force all Intel GPUs to use draws instead of clears on Macs

Created with:
  roll-dep src/third_party/skia
BUG= 602737 ,602688,772695


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I5195a5c74f49f8b9f8830dcbf373e97f0f9ed63d
Reviewed-on: https://chromium-review.googlesource.com/719419
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508840}
[modify] https://crrev.com/1a24eadedcaf0ccdaac8648c812dffad37b9fce5/DEPS

Comment 172 by kbr@chromium.org, Oct 16 2017

Blockedon: 775226

Comment 173 by kbr@chromium.org, Oct 17 2017

Blockedon: angleproject:2188
Blockedon: angleproject:2192
Project Member

Comment 175 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16f2fc56dfe94d22860e113c3591d56a8545597f

commit 16f2fc56dfe94d22860e113c3591d56a8545597f
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Oct 23 17:26:33 2017

Change the passthrough cmd decoder bool switch to an enum.

When the default command decoder changes, an enum switch is required to
select the validating command decoder.

Update the test switches so that no coverage is lost if the default
changes.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7bac1e701f8ba7cf230f12149ace6068c0456c3c
Reviewed-on: https://chromium-review.googlesource.com/726403
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510832}
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/gpu/command_buffer/service/gpu_switches.cc
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/gpu/command_buffer/service/gpu_switches.h
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/gpu/command_buffer/service/service_utils.cc
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/gpu/command_buffer/tests/decoder_perftest.cc
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/16f2fc56dfe94d22860e113c3591d56a8545597f/testing/buildbot/client.v8.fyi.json

Blockedon: angleproject:2196
Blockedon: angleproject:2195
Blockedon: angleproject:2197
Blockedon: angleproject:2198
Project Member

Comment 180 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cb6e5c0e17babc4b68a2e4a2a628beff31b64d5

commit 6cb6e5c0e17babc4b68a2e4a2a628beff31b64d5
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Oct 24 18:02:21 2017

Run WebGL1 conformance against the passthrough cmd decoder on Win/OpenGL.

Previously this configuration was run against the validating command
decoder on Windows.

BUG=602688
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I94d2e5b0d3d277746130d93965223d830fbc2814
Reviewed-on: https://chromium-review.googlesource.com/733946
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511210}
[modify] https://crrev.com/6cb6e5c0e17babc4b68a2e4a2a628beff31b64d5/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/6cb6e5c0e17babc4b68a2e4a2a628beff31b64d5/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/6cb6e5c0e17babc4b68a2e4a2a628beff31b64d5/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 181 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/388aca47dd82dcc7e7669718753d59f7d2990a39

commit 388aca47dd82dcc7e7669718753d59f7d2990a39
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Oct 25 17:23:49 2017

Run WebGL1 conformance against the passthrough cmd decoder and D3D9.

BUG=602688
TBR=kbr@chromium.org
NOTRY=true

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7ad39f40d2321293ff26bf7e6faf0b3aa9475b51
Reviewed-on: https://chromium-review.googlesource.com/733786
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511500}
[modify] https://crrev.com/388aca47dd82dcc7e7669718753d59f7d2990a39/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/388aca47dd82dcc7e7669718753d59f7d2990a39/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/388aca47dd82dcc7e7669718753d59f7d2990a39/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 182 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94cb94676650ec2e563d48f68753f823a639919c

commit 94cb94676650ec2e563d48f68753f823a639919c
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Oct 25 21:54:02 2017

Add a Finch experiment for using the passthrough command decoder by default.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Change-Id: I7234af73871db561a33cbde0bea27cc5d74df7a4
Reviewed-on: https://chromium-review.googlesource.com/734080
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511603}
[modify] https://crrev.com/94cb94676650ec2e563d48f68753f823a639919c/gpu/command_buffer/service/service_utils.cc
[modify] https://crrev.com/94cb94676650ec2e563d48f68753f823a639919c/gpu/config/gpu_finch_features.cc
[modify] https://crrev.com/94cb94676650ec2e563d48f68753f823a639919c/gpu/config/gpu_finch_features.h

Project Member

Comment 183 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83b310b016562b64dab4b39263f97193c30a6c56

commit 83b310b016562b64dab4b39263f97193c30a6c56
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Oct 30 21:51:47 2017

Autogen and update unknown command checks in the passthrough cmd decoder.

Update the build_gles2_cmd_buffer.py script to auto-generate extension
and version checks for all auto-generated entry points and update
hand-written handlers to do the same.  Move unknown command validation
out of the Doer functions.

Covered by new gpu_unittests.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ica1b0f244138ed7a086f410b008c71783811ce53
Reviewed-on: https://chromium-review.googlesource.com/743692
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512635}
[modify] https://crrev.com/83b310b016562b64dab4b39263f97193c30a6c56/gpu/BUILD.gn
[modify] https://crrev.com/83b310b016562b64dab4b39263f97193c30a6c56/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/83b310b016562b64dab4b39263f97193c30a6c56/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/83b310b016562b64dab4b39263f97193c30a6c56/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/83b310b016562b64dab4b39263f97193c30a6c56/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
[modify] https://crrev.com/83b310b016562b64dab4b39263f97193c30a6c56/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[add] https://crrev.com/83b310b016562b64dab4b39263f97193c30a6c56/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_commands.cc

Blockedon: 787063
Project Member

Comment 185 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c1643876d820e241f10d0f67edf8740be72be3d

commit 3c1643876d820e241f10d0f67edf8740be72be3d
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Nov 28 19:30:52 2017

Add fieldtrial testing for DefaultPassthroughCommandDecoder.

BUG=602688

Change-Id: If13efb71c6d3c471c95aa2e5649e943dad25a9d7
Reviewed-on: https://chromium-review.googlesource.com/781800
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519793}
[modify] https://crrev.com/3c1643876d820e241f10d0f67edf8740be72be3d/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 186 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0da75a2b961f292fb55fef8167b2b01d652742e9

commit 0da75a2b961f292fb55fef8167b2b01d652742e9
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Nov 29 14:28:10 2017

Revert "Add fieldtrial testing for DefaultPassthroughCommandDecoder."

This reverts commit 3c1643876d820e241f10d0f67edf8740be72be3d.

Reason for revert: Broke direct composition/video tests on GPU FYI waterfall.

BUG= 789334 

Original change's description:
> Add fieldtrial testing for DefaultPassthroughCommandDecoder.
> 
> BUG=602688
> 
> Change-Id: If13efb71c6d3c471c95aa2e5649e943dad25a9d7
> Reviewed-on: https://chromium-review.googlesource.com/781800
> Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519793}

TBR=geofflang@chromium.org,gayane@chromium.org

Change-Id: I6c681bec8ec1ff6599c03817061f643773802c9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 602688
Reviewed-on: https://chromium-review.googlesource.com/796690
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520103}
[modify] https://crrev.com/0da75a2b961f292fb55fef8167b2b01d652742e9/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 187 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/408921af86e70591ea6f05722e49babb6711ef23

commit 408921af86e70591ea6f05722e49babb6711ef23
Author: Geoff Lang <geofflang@chromium.org>
Date: Fri Jan 05 18:11:20 2018

Add fieldtrial testing for DefaultPassthroughCommandDecoder.

Rebaseline two pixel tests that had imperceptible differences.

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id4eec802af5ed306377884dacc2c3dcdf5d3df6f
Reviewed-on: https://chromium-review.googlesource.com/850997
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527318}
[modify] https://crrev.com/408921af86e70591ea6f05722e49babb6711ef23/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/408921af86e70591ea6f05722e49babb6711ef23/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/408921af86e70591ea6f05722e49babb6711ef23/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 188 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7241f55e5cadf269e2e98b6a6b67dcb19317ac35

commit 7241f55e5cadf269e2e98b6a6b67dcb19317ac35
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Jan 11 00:20:27 2018

Rebaseline MP4 video tests for intel and temporarily supress VP9 failure.

TBR=zmo@chromium.org

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I444e8786012d0dcb06b4b74fa4acac9e83d94970
Reviewed-on: https://chromium-review.googlesource.com/854876
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528499}
[modify] https://crrev.com/7241f55e5cadf269e2e98b6a6b67dcb19317ac35/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 189 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/716c9a14e0103aab645e9130c9922b5140ae7e18

commit 716c9a14e0103aab645e9130c9922b5140ae7e18
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Jan 11 16:08:27 2018

Temporarily supress Pixel_DirectComposition_Video_VP9 on Windows Intel.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6bc4da2bc9acb5aaebc301dd18efaa17661ce421
Reviewed-on: https://chromium-review.googlesource.com/861746
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528635}
[modify] https://crrev.com/716c9a14e0103aab645e9130c9922b5140ae7e18/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 190 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3de798ff1538695cfe7b9693f1e060757b2bc9b

commit b3de798ff1538695cfe7b9693f1e060757b2bc9b
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Jan 23 16:30:00 2018

Update WebGL expectations for the passthrough command decoder.

TBR=zmo@chromium.org

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ieeda065d9d481b18198e6cec1fb4cb06e88537dd
Reviewed-on: https://chromium-review.googlesource.com/879132
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531256}
[modify] https://crrev.com/b3de798ff1538695cfe7b9693f1e060757b2bc9b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 191 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c1709ec979d06ca7f0f9dcd6ffec02cda93b01

commit 66c1709ec979d06ca7f0f9dcd6ffec02cda93b01
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Jan 23 20:07:20 2018

Re-supress webgl-draw-buffers test for Intel/OpenGL.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie6cb900f6b89a063323564fcbfb39b4458b3e025
Reviewed-on: https://chromium-review.googlesource.com/881822
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531321}
[modify] https://crrev.com/66c1709ec979d06ca7f0f9dcd6ffec02cda93b01/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 192 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/399e97834e0f1b08ee104789a87482fd79712da0

commit 399e97834e0f1b08ee104789a87482fd79712da0
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed Jan 24 02:10:19 2018

Re-supress webgl-draw-buffers test for Linux/AMD/OpenGL.

TBR=zmo@chromium.org,geofflang@chromium.org

NOTRY=true
BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I96a685447122bc7e3d229ee3b5d98ad33301ffee
Reviewed-on: https://chromium-review.googlesource.com/882122
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531404}
[modify] https://crrev.com/399e97834e0f1b08ee104789a87482fd79712da0/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 193 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd6e3b951f3ae5f0b7cc2fcf92af2db87416930b

commit cd6e3b951f3ae5f0b7cc2fcf92af2db87416930b
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Jan 24 18:19:04 2018

Temporarily mark passthrough webgl2 tests as flaky on NVIDIA.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I309d25aadc632a9c68c861edce257f3197b9dd05
Reviewed-on: https://chromium-review.googlesource.com/884227
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531610}
[modify] https://crrev.com/cd6e3b951f3ae5f0b7cc2fcf92af2db87416930b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 194 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f8479fffc858bd0b4aefb9fba4bfc7987e626be

commit 5f8479fffc858bd0b4aefb9fba4bfc7987e626be
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Feb 05 16:25:28 2018

Expand Linux Passthrough OpenGL flaky supression to all Linux.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688

Change-Id: I3273800dfae43ed355daebbf7eeb1d9fd7b92fac
Reviewed-on: https://chromium-review.googlesource.com/901803
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534397}
[modify] https://crrev.com/5f8479fffc858bd0b4aefb9fba4bfc7987e626be/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/5f8479fffc858bd0b4aefb9fba4bfc7987e626be/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Blocking: 832028
Blocking: 829541
Blockedon: 825906
Blocking: 738568
Project Member

Comment 199 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1140edbf8524def4ce5776ac31be39297900ab99

commit 1140edbf8524def4ce5776ac31be39297900ab99
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue May 29 19:03:08 2018

Enable the passthrough command decoder by default on Windows.

This ensures that the passthrough command decoder is tested on developer
builds.

BUG=738568
BUG=602688

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3cb473c51d8c889f958827233ca67d6cf6b7fb04
Reviewed-on: https://chromium-review.googlesource.com/1075507
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562533}
[modify] https://crrev.com/1140edbf8524def4ce5776ac31be39297900ab99/gpu/config/gpu_finch_features.cc

Project Member

Comment 200 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18952334c961e8ea269a6e1c07ad53543678f0e8

commit 18952334c961e8ea269a6e1c07ad53543678f0e8
Author: Geoff Lang <geofflang@chromium.org>
Date: Sat Jun 23 01:40:14 2018

Use the default command decoder for webgl[2]_conformance tests.

This will change the optional GPU testers to always test what we're shipping.

Change webgl2_conformance_d3d11_passthrough_tests to
webgl2_conformance_d3d11_validating_tests now that the passthrough command
decoder is used in webgl2_conformance_tests on Windows.

BUG= 828135 
BUG=602688

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I600b53722d797693fd205166afcc4cefc2a4f242
Reviewed-on: https://chromium-review.googlesource.com/1107846
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569873}
[modify] https://crrev.com/18952334c961e8ea269a6e1c07ad53543678f0e8/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/18952334c961e8ea269a6e1c07ad53543678f0e8/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/18952334c961e8ea269a6e1c07ad53543678f0e8/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/18952334c961e8ea269a6e1c07ad53543678f0e8/testing/buildbot/client.v8.fyi.json
[modify] https://crrev.com/18952334c961e8ea269a6e1c07ad53543678f0e8/testing/buildbot/test_suites.pyl

Project Member

Comment 201 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/054e04efa5eb96c8ab764ddf54d4afdc22c519bf

commit 054e04efa5eb96c8ab764ddf54d4afdc22c519bf
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Aug 06 19:35:05 2018

Update the name field of the DefaultPassthroughCommandDecoder experiment.

This allows the experiment name to line up with the finch trial
experiment name, fixing a presubmit warning.

BUG=602688

Change-Id: I98da2aa87f58395aecf258a6f8cfb57586d096ee
Reviewed-on: https://chromium-review.googlesource.com/1163744
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580951}
[modify] https://crrev.com/054e04efa5eb96c8ab764ddf54d4afdc22c519bf/testing/variations/fieldtrial_testing_config.json

Blockedon: 871955
Project Member

Comment 203 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1f6e47c3337853fb41fa5ea496276d727a3145b

commit d1f6e47c3337853fb41fa5ea496276d727a3145b
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Aug 09 00:10:20 2018

Disable GPU compositing for telemetry_unittests.

These tests are run on VMs without real GPU access.  This avoids trying
to use the vmware GL drivers.

BUG= 871955 
BUG=602688

Change-Id: If8cbd19c80b3bb29788abab342c5c14a2d482d5f
Reviewed-on: https://chromium-review.googlesource.com/1167894
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#581728}
[modify] https://crrev.com/d1f6e47c3337853fb41fa5ea496276d727a3145b/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/d1f6e47c3337853fb41fa5ea496276d727a3145b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/d1f6e47c3337853fb41fa5ea496276d727a3145b/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/d1f6e47c3337853fb41fa5ea496276d727a3145b/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/d1f6e47c3337853fb41fa5ea496276d727a3145b/testing/buildbot/chromium.swarm.json
[modify] https://crrev.com/d1f6e47c3337853fb41fa5ea496276d727a3145b/testing/buildbot/chromium.win.json
[modify] https://crrev.com/d1f6e47c3337853fb41fa5ea496276d727a3145b/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/d1f6e47c3337853fb41fa5ea496276d727a3145b/testing/buildbot/test_suites.pyl

Project Member

Comment 204 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/548ac6ffdaac420fbc90a96f09104ef401bc2c38

commit 548ac6ffdaac420fbc90a96f09104ef401bc2c38
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu Aug 23 13:42:45 2018

Suppress Win/Intel/Passthrough/OpenGL WebGL CTS failures

These are the initial suppressions because the
webgl[2]_gl_passthrough_conformance_tests just got added on Win/Intel.

TBR=kbr@chromium.org

BUG=angleproject:2760
BUG=chromium:602688
BUG= chromium:809594 
BUG= chromium:864524 
BUG= chromium:876777 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I88cc85a313ab09fafca5f44129a7f85cc99ddcb2
Reviewed-on: https://chromium-review.googlesource.com/1186462
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585470}
[modify] https://crrev.com/548ac6ffdaac420fbc90a96f09104ef401bc2c38/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 205 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9456e9b9166e3e3f59d39ec49176458190d603b4

commit 9456e9b9166e3e3f59d39ec49176458190d603b4
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Sat Sep 08 02:30:53 2018

Revert "Enable the passthrough command decoder by default on Windows."

This reverts commit 1140edbf8524def4ce5776ac31be39297900ab99.

Reason for revert: This enables the feature on stable by default and causes GPU memory usage to grow indefinitely because GPU discardable textures aren't implemented in passthrough. See  crbug.com/881303 

Original change's description:
> Enable the passthrough command decoder by default on Windows.
> 
> This ensures that the passthrough command decoder is tested on developer
> builds.
> 
> BUG=738568
> BUG=602688
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I3cb473c51d8c889f958827233ca67d6cf6b7fb04
> Reviewed-on: https://chromium-review.googlesource.com/1075507
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562533}

TBR=geofflang@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 738568, 602688,  881303 
Change-Id: I302775b317de7732753cd48fe9d470a35520679f
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1213958
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589757}
[modify] https://crrev.com/9456e9b9166e3e3f59d39ec49176458190d603b4/gpu/config/gpu_finch_features.cc

Project Member

Comment 206 by bugdroid1@chromium.org, Sep 8

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f431eaf6c8dd78867a580dcc72ab3b3a868de44

commit 2f431eaf6c8dd78867a580dcc72ab3b3a868de44
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Sat Sep 08 03:30:09 2018

[merge to M69] Revert "Enable the passthrough command decoder by default on Windows."

This reverts commit 1140edbf8524def4ce5776ac31be39297900ab99.

Reason for revert: This enables the feature on stable by default and causes GPU memory usage to grow indefinitely because GPU discardable textures aren't implemented in passthrough. See  crbug.com/881303 

Original change's description:
> Enable the passthrough command decoder by default on Windows.
> 
> This ensures that the passthrough command decoder is tested on developer
> builds.
> 
> BUG=738568
> BUG=602688
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I3cb473c51d8c889f958827233ca67d6cf6b7fb04
> Reviewed-on: https://chromium-review.googlesource.com/1075507
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562533}

TBR=geofflang@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 738568, 602688,  881303 
Change-Id: I302775b317de7732753cd48fe9d470a35520679f
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1213958
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589757}(cherry picked from commit 9456e9b9166e3e3f59d39ec49176458190d603b4)
Reviewed-on: https://chromium-review.googlesource.com/1214761
Cr-Commit-Position: refs/branch-heads/3497@{#913}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2f431eaf6c8dd78867a580dcc72ab3b3a868de44/gpu/config/gpu_finch_features.cc

Project Member

Comment 207 by bugdroid1@chromium.org, Sep 8

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98613e3bbd612c2287b7d5ddc293633a54406ca8

commit 98613e3bbd612c2287b7d5ddc293633a54406ca8
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Sat Sep 08 03:31:12 2018

[merge to M70] Revert "Enable the passthrough command decoder by default on Windows."

This reverts commit 1140edbf8524def4ce5776ac31be39297900ab99.

Reason for revert: This enables the feature on stable by default and causes GPU memory usage to grow indefinitely because GPU discardable textures aren't implemented in passthrough. See  crbug.com/881303 

Original change's description:
> Enable the passthrough command decoder by default on Windows.
> 
> This ensures that the passthrough command decoder is tested on developer
> builds.
> 
> BUG=738568
> BUG=602688
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I3cb473c51d8c889f958827233ca67d6cf6b7fb04
> Reviewed-on: https://chromium-review.googlesource.com/1075507
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562533}

TBR=geofflang@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 738568, 602688,  881303 
Change-Id: I302775b317de7732753cd48fe9d470a35520679f
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1213958
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589757}(cherry picked from commit 9456e9b9166e3e3f59d39ec49176458190d603b4)
Reviewed-on: https://chromium-review.googlesource.com/1214942
Cr-Commit-Position: refs/branch-heads/3538@{#184}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/98613e3bbd612c2287b7d5ddc293633a54406ca8/gpu/config/gpu_finch_features.cc

Blockedon: 892288
Cc: -oetu...@nvidia.com
Blockedon: angleproject:2894
Project Member

Comment 211 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6

commit a5f88b7e35a567c40e25e21b285ec7e8c687e6d6
Author: James Darpinian <jdarpinian@chromium.org>
Date: Mon Nov 12 23:09:19 2018

Cleaning up WebGL test failure expectations.

Many of these are leftover failure expectations from fixed bugs.
Some were fixed on some platforms but not others. There are some
new failures that were hidden by previous broad suppressions. Also
some tests are only failing because we haven't updated the drivers
on the bots (http://crbug.com/887241).

Bug:  757097 ,  838133 ,  672380 , 625738,  angleproject:2325 
Bug:  534697 , 849572, 625738, 703779,  angleproject:2142 
Bug: 757098, 644740, 705865, 602688,  angleproject:2103 
Bug: 903903,  740769 , 662644,  680720 ,  angleproject:1932 
Bug:  709874 , 887241,  625365 , angleproject:2952
Change-Id: I4e39e5a09d31d788d8a8615ad06d1ec88f064f00
Reviewed-on: https://chromium-review.googlesource.com/c/1325197
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607367}
[modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/a5f88b7e35a567c40e25e21b285ec7e8c687e6d6/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py

Showing comments 112 - 211 of 211 Older

Sign in to add a comment