New issue
Advanced search Search tips

Issue 602676 link

Starred by 8 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Split LoginModel implementation from the PasswordManager

Project Member Reported by vabr@chromium.org, Apr 12 2016

Issue description

PasswordManager implements the LoginModel interface to serve http auth forms. But the implementation is largely independent of the rest of PasswordManager.

Instead, we should create a separate class implementing LoginModel, and move also PasswordManager::AutofillHttpAuth and PasswordManager::observers_ into it. This will make PasswordManager itself clearer and unittesting easier.

While there seems to be no other subclass of LoginModel than PasswordManager, we should probably keep the pulled-out implementation still a separate subclass of LoginModel (as opposed to just putting it inside LoginModel). Having the separate interface will again make unittesting easier.

It is not clear ATM whether PasswordManager should own the LoginModel implementation, or whether they should be completely independent. The latter is preferable, if possible.
 

Comment 1 by vabr@chromium.org, Jun 6 2016

Labels: -refactoring Hotlist-Refactoring
Hi,

I am new to chrome and open source contribution in general. I was looking at issues tagged for beginners and this issue seems interesting to me. Can I work on it?

Thanks,
Tushar

Comment 3 by vabr@chromium.org, Jul 6 2016

Hi Tushar,
Sure, feel free to do so.
Thank you.

Is there any documentation on the PasswordManager class and LoginModel interface so that I have a high level understanding of what it does, which will be helpful during refactoring. Or is reading source code and its comments my best bet over here?

Comment 5 Deleted

Project Member

Comment 6 by sheriffbot@chromium.org, Apr 13 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by vabr@chromium.org, Apr 17 2018

Labels: -Type-Feature Type-Task
Status: Available (was: Untriaged)

Sign in to add a comment