Issue metadata
Sign in to add a comment
|
[MaterialDesign] [Mac] Regression: Icon menus have wrong padding |
||||||||||||||||||||
Issue descriptionVersion: Chromium 386680 OS: OSX 10.11.4 What steps will reproduce the problem? (1) Click on the Chrome (wrench) icon or click and hold on the back/forward arrow (2) Menu appears What is the expected output? What do you see instead? The padding is no longer the same as in some builds before: 1.) There is no space any more between the icon and its menu. 2.) The Menu is no longer aligned with its icon on the right side. Please use labels and text to provide additional information. Screenshots are attached. Thanks and regards Mehmet
,
Apr 12 2016
I believe the distance is correct, but looking to sgabriel@ for confirmation.
,
Apr 12 2016
So there is to things here: - The edge alignment should remain as showed in the "expected" screenshots. - In term of spacing between the active state and the top edge of the menu, what we do for Cros might not be what we want to do for OSX. since we are using native menus, I'm more than happy to keep the gap as it is if it's consistent with how generally this things work throughout the OS. Thanks!
,
Apr 12 2016
You said there were two things but it seems like the first and second points were the same? Or did I miss something?
,
Apr 12 2016
I consider edge alignement and gap two separate things :)
,
Apr 12 2016
Ah, good thing I asked - can you elaborate? Because I'm not sure how they are different.
,
Apr 12 2016
ok might have not expressed it in the best way. We should do what's showed in the "Expected" shots, i.e bringing the menu gap back and the edge alignement back as well.
,
Apr 12 2016
By edge alignment you mean vertical edge? I've been focused on the horizontal edge.
,
Apr 12 2016
Yes vertical.
,
Apr 12 2016
,
Apr 13 2016
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d2416adbf662a8c646ba7aa2f47e0fc0de600a4 commit 5d2416adbf662a8c646ba7aa2f47e0fc0de600a4 Author: shrike <shrike@chromium.org> Date: Wed Apr 13 23:59:56 2016 [Mac] Restore menu position for buttons after Material Design changes. Changing the button active area from 28x28 to 24x24 caused button menus to be slightly mispositioned. This change restores their position to normal. R=avi@chromium.org BUG= 602672 Review URL: https://codereview.chromium.org/1886903002 Cr-Commit-Position: refs/heads/master@{#387160} [modify] https://crrev.com/5d2416adbf662a8c646ba7aa2f47e0fc0de600a4/chrome/browser/ui/cocoa/menu_button.mm [modify] https://crrev.com/5d2416adbf662a8c646ba7aa2f47e0fc0de600a4/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h [modify] https://crrev.com/5d2416adbf662a8c646ba7aa2f47e0fc0de600a4/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
,
Apr 14 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Apr 12 2016