[css-grid] Issue with alignment and content distribution |
||||||||
Issue descriptionIf we use content distribution (with "space-around" and that kind of values) and we align one item with "center" and/or "end". The item uses the space added by the content distribution, but it shouldn't use it. Attached example showing the issue, check it live at: http://jsbin.com/doyole/1/edit?html,css,output
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60d690dfa729305930f3e8a387abb6da6d6146a0 commit 60d690dfa729305930f3e8a387abb6da6d6146a0 Author: rego <rego@igalia.com> Date: Mon Apr 18 11:18:59 2016 [css-grid] Fix alignment with content distribution We were only subtracting the distribution offset for items spanning several tracks, but not for items in a single cell. We should actually subtract the offset in that situation too, the same that we do for the grid gaps. Created new test and renamed the old one as it was only testing items spanning several cells. BUG= 602670 TEST=fast/css-grid-layout/grid-content-alignment-and-self-alignment.html Review URL: https://codereview.chromium.org/1880393005 Cr-Commit-Position: refs/heads/master@{#387888} [rename] https://crrev.com/60d690dfa729305930f3e8a387abb6da6d6146a0/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-and-self-alignment-spanning-expected.txt [add] https://crrev.com/60d690dfa729305930f3e8a387abb6da6d6146a0/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-and-self-alignment-spanning.html [modify] https://crrev.com/60d690dfa729305930f3e8a387abb6da6d6146a0/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-and-self-alignment.html [modify] https://crrev.com/60d690dfa729305930f3e8a387abb6da6d6146a0/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
,
Apr 18 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by r...@igalia.com
, Apr 12 2016Status: Assigned (was: Available)