PaymentRequest should be a ContextLifecycleObserver |
|||||
Issue descriptionWork started in https://codereview.chromium.org/1863053005.
,
Apr 12 2016
,
Apr 12 2016
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b76c04ae3040e16d924495416b722b2fcf13616 commit 5b76c04ae3040e16d924495416b722b2fcf13616 Author: rob.buis <rob.buis@samsung.com> Date: Thu Apr 14 02:41:37 2016 PaymentRequest should be a ContextLifecycleObserver This CL makes PaymentRequest a ContextLifecycleObserver. Since mojo::Binding::Close() has a precondition that it is bound, check that in PaymentRequest::cleanUp before calling Close(), if not Payment unit tests that create PaymentRequests that do not bind will crash. BUG= 602660 Review URL: https://codereview.chromium.org/1880353004 Cr-Commit-Position: refs/heads/master@{#387214} [modify] https://crrev.com/5b76c04ae3040e16d924495416b722b2fcf13616/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/5b76c04ae3040e16d924495416b722b2fcf13616/third_party/WebKit/Source/modules/payments/PaymentRequest.h
,
Apr 14 2016
,
Jun 6 2016
,
Jul 1 2016
bulk verified |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rouslan@chromium.org
, Apr 12 2016