New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602660 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 587995



Sign in to add a comment

PaymentRequest should be a ContextLifecycleObserver

Project Member Reported by rouslan@chromium.org, Apr 12 2016

Issue description

Cc: rob.b...@samsung.com
Cc: -rob.b...@samsung.com rouslan@chromium.org
Owner: rob.b...@samsung.com
Components: Blink>Payments
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b76c04ae3040e16d924495416b722b2fcf13616

commit 5b76c04ae3040e16d924495416b722b2fcf13616
Author: rob.buis <rob.buis@samsung.com>
Date: Thu Apr 14 02:41:37 2016

PaymentRequest should be a ContextLifecycleObserver

This CL makes PaymentRequest a ContextLifecycleObserver.
Since mojo::Binding::Close() has a precondition that it
is bound, check that in PaymentRequest::cleanUp before
calling Close(), if not Payment unit tests that create
PaymentRequests that do not bind will crash.

BUG= 602660 

Review URL: https://codereview.chromium.org/1880353004

Cr-Commit-Position: refs/heads/master@{#387214}

[modify] https://crrev.com/5b76c04ae3040e16d924495416b722b2fcf13616/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/5b76c04ae3040e16d924495416b722b2fcf13616/third_party/WebKit/Source/modules/payments/PaymentRequest.h

Status: Fixed (was: Assigned)
Fixed by r387214.
Labels: M-53
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment