Block installs on pre-Win7 |
||||||
Issue descriptionInstallUtil::IsOSSupported and the various messages used by setup.exe need to be revised so that the installer bails out early on pre-Win7 machines.
,
Apr 12 2016
,
Apr 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d7a972e9b8f1d8031fa9b59c1723abf2fe1c612 commit 0d7a972e9b8f1d8031fa9b59c1723abf2fe1c612 Author: grt <grt@chromium.org> Date: Tue Apr 12 18:45:39 2016 Bump the min-supported OS version in the installer. BUG= 602655 Review URL: https://codereview.chromium.org/1884663002 Cr-Commit-Position: refs/heads/master@{#386753} [modify] https://crrev.com/0d7a972e9b8f1d8031fa9b59c1723abf2fe1c612/chrome/app/chromium_strings.grd [modify] https://crrev.com/0d7a972e9b8f1d8031fa9b59c1723abf2fe1c612/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/0d7a972e9b8f1d8031fa9b59c1723abf2fe1c612/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/0d7a972e9b8f1d8031fa9b59c1723abf2fe1c612/chrome/installer/util/install_util.cc
,
Apr 12 2016
Requesting early merge to M50. Thanks.
,
Apr 13 2016
[Automated comment] GRD changes detected, less than 3 weeks to before stable release of M50, manual review required.
,
Apr 14 2016
The string changes are really late but critical. Merge approved for M50 (branch 2661). Pls go ahead merge. Once merged in, Krishna, can you pls run L10n script to send the 2 strings for translation? Thanks!
,
Apr 14 2016
Sure, will re-run translation once the change is merged to M50 branch 2661.
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f9b0c613f27ef7f53ea316512c961a88156f921 commit 5f9b0c613f27ef7f53ea316512c961a88156f921 Author: Greg Thompson <grt@chromium.org> Date: Thu Apr 14 18:44:03 2016 Bump the min-supported OS version in the installer. BUG= 602655 Review URL: https://codereview.chromium.org/1884663002 Cr-Commit-Position: refs/heads/master@{#386753} (cherry picked from commit 0d7a972e9b8f1d8031fa9b59c1723abf2fe1c612) TBR=grt@chromium.org Review URL: https://codereview.chromium.org/1890913003 . Cr-Commit-Position: refs/branch-heads/2661@{#582} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/5f9b0c613f27ef7f53ea316512c961a88156f921/chrome/app/chromium_strings.grd [modify] https://crrev.com/5f9b0c613f27ef7f53ea316512c961a88156f921/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/5f9b0c613f27ef7f53ea316512c961a88156f921/chrome/installer/setup/setup_main.cc [modify] https://crrev.com/5f9b0c613f27ef7f53ea316512c961a88156f921/chrome/installer/util/install_util.cc
,
Apr 14 2016
Translation re-run started. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by scottmg@chromium.org
, Apr 12 2016