Make stack.py handle Java crashes |
||
Issue descriptionExample crash: https://chromegw.corp.google.com/i/internal.client.clank_qa/builders/release-tests/builds/3946/steps/stack_tool_with_logcat_dump/logs/stdio If you look at the crash, it's referring to a java crash but you have to separately hunt down the logcat. This also slows down triage as not everyone is familiar with this. Making stack tool aware of these would help.
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa0d5241405e4dadb49b93b49ce40685c1406fad commit fa0d5241405e4dadb49b93b49ce40685c1406fad Author: timav <timav@chromium.org> Date: Wed Apr 13 17:22:57 2016 Revert of ⛄ Capture Android stderr when symbolizing native stack traces. (patchset #1 id:1 of https://codereview.chromium.org/1886473002/ ) Reason for revert: Seems to cause exception failures on the bots: NameError: global name 'java_exceptions' is not defined E.g. https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20%28dbg%29/builds/9749 What is |java_exceptions| at the end of stack_core.py? Original issue's description: > Capture Android stderr when symbolizing native stack traces. > > When native->Java results in a Java exception, upon the stack returning > back to C++, we dump the Java exception to stderr and then signal a crash. > > Update our stack tool to capture Java-formatted stderr while processing logcat and dump > all matching logs if the pid of the error matches the native stack. > While this may sometimes be irrelevant, it can often include the Java > exception and makes it easier to triage and less confusing. > > BUG= 602651 > > Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 > Cr-Commit-Position: refs/heads/master@{#386987} TBR=rmcilroy@chromium.org,yfriedman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 602651 Review URL: https://codereview.chromium.org/1884873004 Cr-Commit-Position: refs/heads/master@{#387015} [modify] https://crrev.com/fa0d5241405e4dadb49b93b49ce40685c1406fad/third_party/android_platform/README.chromium [modify] https://crrev.com/fa0d5241405e4dadb49b93b49ce40685c1406fad/third_party/android_platform/development/scripts/stack_core.py
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85922ea529c280c58903a84056053c777485c118 commit 85922ea529c280c58903a84056053c777485c118 Author: yfriedman <yfriedman@chromium.org> Date: Wed Apr 13 18:10:33 2016 [Reland] Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG= 602651 Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 Cr-Commit-Position: refs/heads/master@{#386987} Review URL: https://codereview.chromium.org/1886473002 Cr-Commit-Position: refs/heads/master@{#387029} [modify] https://crrev.com/85922ea529c280c58903a84056053c777485c118/third_party/android_platform/README.chromium [modify] https://crrev.com/85922ea529c280c58903a84056053c777485c118/third_party/android_platform/development/scripts/stack_core.py
,
Apr 14 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 13 2016