New issue
Advanced search Search tips

Issue 602646 link

Starred by 2 users
Status: Fixed
Owner:
ekaramad@chromium.org
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

[Refactor] In site_per_process_browser_test.cc file, use web_contents() instead of static_cast to WebContentsImpl* when possible.

Project Member Reported by ekaramad@chromium.org, Apr 12 2016 
After {#385537}, we have SitePerProcessBrowserTest::web_contents() which is a static cast of shell()->web_contents() to WebContentsImpl. Use this to clean up code when/where possible.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd1b5cfa2cdbafeb27ce0dc1981f77136df0b72f

commit fd1b5cfa2cdbafeb27ce0dc1981f77136df0b72f
Author: ekaramad <ekaramad@chromium.org>
Date: Tue Apr 19 00:35:00 2016

[Refactor] Replace static casts to WebContentsImpl with member function.

Replace static casts to WebContentsImpl with member function.

BUG= 602646 

Review URL: https://codereview.chromium.org/1890453002

Cr-Commit-Position: refs/heads/master@{#388095}

[modify] https://crrev.com/fd1b5cfa2cdbafeb27ce0dc1981f77136df0b72f/content/DEPS
[modify] https://crrev.com/fd1b5cfa2cdbafeb27ce0dc1981f77136df0b72f/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/fd1b5cfa2cdbafeb27ce0dc1981f77136df0b72f/content/browser/site_per_process_browsertest.h

Comment 2 by ekaramad@chromium.org, Apr 27 2016

Status: Fixed (was: Started)
►

Sign in to add a comment