[tracking bug] Add a way to enable the feature only for signed-in users |
|||||
Issue descriptionRight now, if we want to enable the feature for some users, we can't distinguish between signed-in and non-signed-in users. Of course, non-signed-in users wouldn't get snippets because they don't have MostLikely suggestions, but they would still get the new NTP UI.
,
Apr 12 2016
We have to find out before inflating the NTP if we have snippets or not -- would the stored snippets always be fresh enough to use for that?
,
Apr 12 2016
Hm, that would probably break the first-run, no? When you see an NTP for the first time, we're probably not done fetching snippets yet, so you'd get the old UI. We'd also need to be careful about cases when you have discarded all snippets etc, to prevent users from going back and forth between the UIs.
,
Apr 12 2016
The thing is, there could be a lot of reasons why we don't show cards -- not signed in, Sync is encrypted, network error, no matching cards -- and for some of them we don't even know in advance whether that's going to be the case. Showing the new NTP UI with no cards in those cases would be suboptimal, so ideally we would just be able to fall back to the old UI. What are the differences between old and new UI? The bookmarks / recent tabs buttons, and what else?
,
Apr 12 2016
That, plus bugs while we work on the new NTP UI.
,
Apr 12 2016
> What are the differences between old and new UI? The bookmarks / recent tabs buttons, and what else? The spacing and background color are also. Besides that, differences should be related to bugs. If the new UI is not disabled because of a flag, I think we should still use it for users where snippets are not enabled. Other experiments will rely on it, it will avoid splitting the work across both UIs, and will be consistent for all users. If we stay on the new UI, shouldn't hiding or showing the hint ( issue 586126 ) be the only required UI change? that would not break on FRE, sign out, etc.
,
Apr 12 2016
Hm... I'm thinking we should make the new NTP UI nice enough that it's not a problem to show it to everyone -- I think that's basically what Nicolas is saying, right? And then we could show the hint if and only if there are cards.
,
Apr 12 2016
Makes sense! Then I guess this is WontFix :)
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bauerb@chromium.org
, Apr 12 2016