New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602644 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 640844



Sign in to add a comment

Document.write scripts should not be considered for blocking in a reload

Project Member Reported by shivanisha@chromium.org, Apr 12 2016

Issue description

To reduce the possibility of a page break by blocking a document.written script, there will be a check that if the user is reloading the same page then do not consider the document.written scripts on this page for blocking.

Feature Bug: 599875
 
Components: Blink>Loader
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6ea16af4915e7080af6ca022363e75d8d9b05f9

commit f6ea16af4915e7080af6ca022363e75d8d9b05f9
Author: shivanisha <shivanisha@chromium.org>
Date: Mon Apr 25 15:21:53 2016

To reduce the possibility of a page break by blocking a document.written
script,this patch includes a check that if the user is reloading the same
page then do not consider the document.written scripts on this page for
blocking.
BUG= 602644 

Review URL: https://codereview.chromium.org/1883873002

Cr-Commit-Position: refs/heads/master@{#389480}

[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html
[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types.html
[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html
[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html
[add] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload-expected.txt
[add] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html
[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6ea16af4915e7080af6ca022363e75d8d9b05f9

commit f6ea16af4915e7080af6ca022363e75d8d9b05f9
Author: shivanisha <shivanisha@chromium.org>
Date: Mon Apr 25 15:21:53 2016

To reduce the possibility of a page break by blocking a document.written
script,this patch includes a check that if the user is reloading the same
page then do not consider the document.written scripts on this page for
blocking.
BUG= 602644 

Review URL: https://codereview.chromium.org/1883873002

Cr-Commit-Position: refs/heads/master@{#389480}

[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html
[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types.html
[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html
[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html
[add] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload-expected.txt
[add] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html
[modify] https://crrev.com/f6ea16af4915e7080af6ca022363e75d8d9b05f9/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Status: Verified (was: Assigned)
Labels: Merge-Request-51OS-All

Comment 7 by tin...@google.com, May 6 2016

Labels: Merge-Review Hotlist-Merge-Review
[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).
Labels: -Merge-Request-51OS-All Merge-Request-51

Comment 9 by tin...@google.com, May 6 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Labels: -Merge-Approved-51 merge-merged-2704
This was merged in https://codereview.chromium.org/1955043003/
Blocking: 640844

Sign in to add a comment