New issue
Advanced search Search tips

Issue 602643 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Shelf position not remembered by monitor anymore

Project Member Reported by kuscher@chromium.org, Apr 12 2016

Issue description

Chrome Version       : 51.0.2701.0
OS Version: 8161.0.0537.36

The shelf used to remember its position per display. It now forgets this when I unplug a display and plug it in. Steps to repro:

1) Have self at bottom on internal display
2) Plug in monitor
3) Close laptop (closed lid mode)
4) Move shelf to right on external monitor
5) unplug and replug

After (5) I used to have shelf on the right on my external monitor. When I unplugged it was at bottom on internal. Now, it always goes back to bottom everywhere.

Did we change anything in shelf code?


 

Comment 1 by derat@chromium.org, Apr 12 2016

Cc: -derat@chromium.org

Comment 2 by msw@chromium.org, Apr 12 2016

Cc: osh...@chromium.org msw@chromium.org
It's possible that one of my recent shelf changes is related...
I can't repro from linux with out/Default/chrome --ash-host-window-bounds=1000x500,0+600-800x500
(setting the secondary display's shelf to right; restart; secondary shelf is still on right)
Can we get a regression range or find repro steps without a device?

Comment 3 by osh...@chromium.org, Apr 12 2016

Owner: osh...@chromium.org
Status: Started (was: Unconfirmed)
This seems to happen only with docked mode, so it's harder to test. Best way would be to add a unit test. Let me take a look at first.

Comment 4 by osh...@chromium.org, Apr 12 2016

Confirmed that this is working on m50.

Comment 5 by msw@chromium.org, Apr 12 2016

You can try reverting https://codereview.chromium.org/1851883002/ locally.

Comment 6 by osh...@chromium.org, Apr 13 2016

I couldn't somehow reproduce this on Pixel 1 + ToT (from yesterday). I'll look into this again tomorrow.

Comment 7 by r...@chromium.org, Apr 13 2016

Cc: -r...@chromium.org

Comment 8 by osh...@chromium.org, Apr 13 2016

Status: WontFix (was: Started)
Looks like this is fixed on ToT and on 51, although there was another issue with vertical shelf layout. I'll file a separate bug.

Sign in to add a comment