New issue
Advanced search Search tips

Issue 602639 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug

Blocking:
issue 578160



Sign in to add a comment

Mus needs ui::Event to blink::WebInputEvent converter

Project Member Reported by jonr...@chromium.org, Apr 12 2016

Issue description

Currently when dispatching events to the renderer we convert from ui::Event to mojom::Event. Then we convert from mojom::Event to blink::WebInputEvent.

With mus::InputEventHandler now using ui::Event this extra conversion is unnecessary. We should clean this up when we setup the direct posting of events from mus to the chrome renderer.

Eg: CompositorMusConnection::OnWindowInputEvent calls:

 std::unique_ptr<blink::WebInputEvent> web_event(
      mus::mojom::Event::From(event)
          .To<std::unique_ptr<blink::WebInputEvent>>());

Which first converts using InputEventTypeConverters:
mus::mojom::EventPtr TypeConverter<mus::mojom::EventPtr, ui::Event>::Convert(
    const ui::Event& input)

Then uses BlinkInputEventTypeConverters:
scoped_ptr<blink::WebInputEvent>
TypeConverter<scoped_ptr<blink::WebInputEvent>, mus::mojom::EventPtr>::Convert
 
Components: Internals>MUS
Labels: Proj-Mustash
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 5 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Labels: -Proj-Mustash Proj-Mash
Status: Available (was: Untriaged)

Sign in to add a comment