Provide a testing switch for other forms of browsing history |
|||||
Issue descriptionWe currently do not have an API to query the existence of other forms of browsing history. This makes the UI difficult to test, as the web history service query constantly returns false, never showing the UI. We should provide a testing switch to skip this query (and assume it did find some other forms of browsing history stored in the user's account).
,
Apr 22 2016
This seems to have already made it into Canary; I have tested on Mac and it works correctly. Requesting merge to M51.
,
Apr 22 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2 commit 14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2 Author: Martin Sramek <msramek@chromium.org> Date: Fri Apr 22 14:16:25 2016 Add a testing switch to override the query for other forms of browsing history The API to query other forms of browsing history is not ready yet. The query done by web history service therefore currently always return false, i.e. "no other forms of browsing history found in this account". Until the API is ready, provide a switch for testing purposes that will change this to always return true. BUG= 602629 Review URL: https://codereview.chromium.org/1884553002 Cr-Commit-Position: refs/heads/master@{#388753} (cherry picked from commit 2b3e76a0b6974e86953e3786fad5ddafa59cd573) Review URL: https://codereview.chromium.org/1915473002 . Cr-Commit-Position: refs/branch-heads/2704@{#183} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2/chrome/browser/ui/webui/history_ui.cc [modify] https://crrev.com/14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2/components/browsing_data_ui/history_notice_utils.cc [modify] https://crrev.com/14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2/components/browsing_data_ui/history_notice_utils.h [modify] https://crrev.com/14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2/ios/chrome/app/resources/history/history.js [modify] https://crrev.com/14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2/ios/chrome/browser/BUILD.gn [rename] https://crrev.com/14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2/ios/chrome/browser/ui/webui/history/history_ui.mm [modify] https://crrev.com/14ef220fa7d5e12accc0c64099d7f0b5a72ebcc2/ios/chrome/ios_chrome.gyp
,
Apr 22 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 21 2016