New issue
Advanced search Search tips

Issue 602609 link

Starred by 3 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Sign-in dialogue content doesn't scale with zoom setting

Reported by jshan...@etouch.net, Apr 12 2016

Issue description

Version:51.0.2704.4 Revision 5bcb06bd733f10474ea2f719aa594b13883a393e-refs/branch-heads/2704@{#6}(32/64 bit)
OS: All(Win-7 Aero Enabled)

Precondition: Enable 'new gaia password-separated sign in flow' flag from 'chrome://flags'.

Steps:
1. Launch Chrome and navigate to chrome://settings
2. Click on 'Show advanced settings' and set the page zoom to 175%
3. Scroll up page, click on 'Sign in to chrome' button and observe the 'Close'(Cross) icon of Sign in overlay.

Actual: Unnecessary 'Close' icon size changes after changing page zoom to 175%.

Expected: 'Close' icon size should not change after changing page zoom to 175%.

This is regression issue,broken in ‘M 51’ and below is narrow bisect:

Good build: 51.0.2671.0
Bad build: 51.0.2672.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/5241d81a41e319f8b1f4d9840cd8d1269b265788..61f3f4f037aca857735769cda129e18e38e8853e?pretty=fuller&n=100

Suspecting: r379986 ?

Kindly help to re-assign, if your changes are not cause for this issue.


 
Actual_Expected_screenshot.jpg
112 KB View Download
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 19 2016

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: msarda@chromium.org
+msarda since I no longer work on Identity. I imagine this will be obsolete once the flows are moved to native UI (the button is currently chrome-side WebUI).

Comment 3 by ew...@chromium.org, May 12 2017

Cc: ew...@chromium.org
Labels: -Pri-1 Pri-3
Mihai - is there anything we can do about this in the short-term? If not, I'm inclined to mark this as WontFix.

Comment 4 by msarda@chromium.org, May 12 2017

I do not see how we can fix this. I have tried various things, but I think we would need the help from the WebUI experts to get this fixed.

Comment 5 by ew...@chromium.org, May 12 2017

Cc: dbeam@chromium.org
Labels: -Type-Bug-Regression Type-Bug
+a WebUI expert :)

Dan, are you familiar with how we implement the "x"-to-close button in the sign-in dialogue? With the way it's implemented right now (in Chrome-side WebUI), it's affected by the "page zoom" setting, which feels a bit awkward.

Do you have any suggestions for a way we could fix this short of moving to native UI for the dialogue?

Thanks for your help!

Comment 6 by dbeam@chromium.org, May 16 2017

isn't it really only a bug that the "Sign in to Chrome" content is too small?

the user has a non-default zoom.  they want everything to be bigger, don't they?

Comment 7 by ew...@chromium.org, May 16 2017

Cc: lpalmaro@chromium.org
Summary: Sign-in dialogue content doesn't scale with zoom setting (was: Regression: Weird behaviour of 'Close' icon at 'Sign in' overlay is seen after changing page zoom to 175%)
+Laura FYI for a11y

Hmmm yeah, that's a good point :) I agree that the dialogue content should scale with the zoom setting.

Do you think it's expected that the close button would also scale? I'm not sure whether I'd expect a control like the "x"-to-close to scale with my zoom setting. I guess it probably makes sense for it to, though (a small "x" with large content would look weird).

Updating the title. Mihai - I know this page is served by GAIA. Is there an easy way for us to apply the zoom setting to it?

Comment 8 by msarda@chromium.org, May 16 2017

The inline login UI is actually presented in a Guest WebView inside an extension. I have no idea for the moment why the scaling does not apply to the internal guest WebView. I guess this is something that I'll need to debug.

Seeing this is a P3 and as we have hundreds of bugs, I doubt I'll have the time to actually work on it soon.
Project Member

Comment 9 by sheriffbot@chromium.org, May 15 2018

Cc: droger@chromium.org bsazonov@chromium.org jlebel@chromium.org tangltom@chromium.org sabineb@chromium.org msarda@chromium.org
--Chrome Identity automated triaging--

This bug is Available and has gone one year without any activity. If another month passes without any activity, this bug will be closed out. Please provide an update with the latest status for this bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -jlebel@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment