Regression: On sign in overlay, 'Print' and 'View source page' options of context menu is not working.
Reported by
rk...@etouch.net,
Apr 12 2016
|
||||||||
Issue descriptionVersion:51.0.2704.4 Revision 5bcb06bd733f10474ea2f719aa594b13883a393e-refs/branch-heads/2704@{#6}(32/64 bit) OS: All(Win-7 Aero Enabled) Precondition: Enable 'new gaia password-separated sign in flow' flag from 'chrome://flags'. What steps will reproduce the problem? (1) Launch chrome, click on avatar icon and then click on 'Sign in into Chrome' button.(Sign in overlay opens) (2) Right click on Close icon and select 'Print' or 'View source page' option, observe. Options(i.e. 'Print' and 'View source page') in context menu is not working as intended . Options(i.e. 'Print' and 'View source page') in context menu should be work. or Context menu should not appear. This is regression issue,broken in ‘M 51’ and below is narrow bisect: Good build: 51.0.2670.0 Bad build: 51.0.2672.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/5241d81a41e319f8b1f4d9840cd8d1269b265788..61f3f4f037aca857735769cda129e18e38e8853e?pretty=fuller&n=100 Suspecting: r379986 ? Kindly help to re-assign, if your changes are not cause for this issue.
,
Apr 12 2016
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e commit dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e Author: anthonyvd <anthonyvd@chromium.org> Date: Mon Jun 27 18:41:01 2016 Disable the Context Menu in the tab-modal signin dialog. This prevents weird behaviors such as opening links in different profiles and unusable "view source" and "print" buttons. BUG= 622225 , 614680 , 602594 TEST= 1. Open the User Menu and click "sign in to Chrome" 2. In the sign in flow and the sync confirmation dialog, right-clicking to display the context menu shouldn't work. Review-Url: https://codereview.chromium.org/2093563003 Cr-Commit-Position: refs/heads/master@{#402235} [modify] https://crrev.com/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e/chrome/browser/ui/signin_view_controller_delegate.cc [modify] https://crrev.com/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e/chrome/browser/ui/signin_view_controller_delegate.h
,
Jun 27 2016
,
Jun 28 2016
Tested this issue on Win7, Mac OS X 10.11.5, Ubuntu 14.04 using Chrome Canary/Dev # 53.0.2782.0 and the context menu was disabled. adding TE-verified labels and attached screencast for reference.
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by msrchandra@chromium.org
, Apr 12 2016