A couple of places in renderer code https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/pepper/pepper_platform_audio_input.cc&l=179&cl=GROK https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/media/audio_renderer_mixer_manager_unittest.cc&l=33&cl=GROK + an upcoming CL https://codereview.chromium.org/1769933002/ use AudiomanagerBase to reason about device IDs. media/audio is traditionally browser side only, so those device ID dependencies should be moved to media/base.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/251dd5695fddf760cbd1206d634d0c9dc1572c77 commit 251dd5695fddf760cbd1206d634d0c9dc1572c77 Author: olka <olka@chromium.org> Date: Wed Apr 27 15:50:17 2016 Moving device description utils from AudioManager[Base] into AudioDeviceDescription; to be shared by browser/renderer Moved from AudioManagerBase: * device id constants, * IsDefaultDeviceId() (renamed to IsDefaultDevice) * UseSessionIdToSelectDevice() Moved from AudioManager: * GetDefaultDeviceName() * GetCommuncationDeviceName() AudioDeviceName: introduced two static helpers: CreateDefault and CreateCommunications The rest is renaming and header include fixes. BUG= 602581 Review-Url: https://codereview.chromium.org/1892433002 Cr-Commit-Position: refs/heads/master@{#390086} [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/chrome/browser/copresence/chrome_whispernet_client.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/chrome/browser/media/desktop_capture_access_handler.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/components/audio_modem/audio_recorder_impl.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/components/audio_modem/audio_recorder_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/browser/renderer_host/media/audio_output_device_enumerator.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/browser/renderer_host/media/audio_output_device_enumerator_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/browser/renderer_host/media/audio_renderer_host.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/browser/renderer_host/media/media_stream_manager.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/browser/renderer_host/media/media_stream_manager_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/browser/renderer_host/render_message_filter.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/browser/speech/speech_recognition_manager_impl.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/browser/speech/speech_recognizer_impl_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/renderer/media/audio_renderer_mixer_manager.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/renderer/media/audio_renderer_mixer_manager.h [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/renderer/media/audio_renderer_mixer_manager_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/content/renderer/pepper/pepper_platform_audio_input.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/BUILD.gn [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/alsa/audio_manager_alsa.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/android/audio_android_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/android/audio_manager_android.cc [add] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_device_description.cc [add] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_device_description.h [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_device_name.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_device_name.h [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_input_controller_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_input_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_low_latency_input_output_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_manager.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_manager.h [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_manager_base.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_manager_base.h [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_manager_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_output_controller_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/audio_output_device.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/cras/audio_manager_cras.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/cras/cras_input.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/cras/cras_input_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/mac/audio_low_latency_input_mac_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/mac/audio_manager_mac.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/pulse/audio_manager_pulse.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/pulse/pulse_input.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/pulse/pulse_output.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/pulse/pulse_util.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/audio_low_latency_input_win.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/audio_low_latency_input_win.h [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/audio_low_latency_output_win.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/audio_low_latency_output_win_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/audio_manager_win.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/core_audio_util_win.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/core_audio_util_win_unittest.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/wavein_input_win.cc [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/audio/win/wavein_input_win.h [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/media.gyp [modify] https://crrev.com/251dd5695fddf760cbd1206d634d0c9dc1572c77/media/mojo/services/test_mojo_media_client.cc
Comment 1 by olka@chromium.org
, Apr 25 2016