New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602572 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Need better debugging info for remote commands

Project Member Reported by atwilson@chromium.org, Apr 12 2016

Issue description

We need to have better client side logging for remote commands:

1) Log when we fetch commands and which commands we are fetching.
2) Log when we are uploading a response for a command and what the response was.
3) Log when we execute a command.
4) Log when we decide not to execute a command (example: screenshots failing due to user input)
5) Log all places where we create an UploadJob so we know what it is (log upload, screenshot upload, etc).

 
Would be good to log the type of input event that is preventing screenshots as well.
Cc: sduraisamy@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/481a291fd77a809b5f5844192d674709679c776d

commit 481a291fd77a809b5f5844192d674709679c776d
Author: hunyadym <hunyadym@chromium.org>
Date: Mon Jun 06 09:32:32 2016

Add logging to remote commands

BUG= 602572 

Review-Url: https://codereview.chromium.org/1923943003
Cr-Commit-Position: refs/heads/master@{#397998}

[add] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/base/chromeos/logging.h
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/chrome/browser/chromeos/policy/status_uploader.cc
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/chrome/browser/chromeos/policy/upload_job_impl.cc
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/components/policy/core/common/remote_commands/remote_command_job.cc
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/components/policy/core/common/remote_commands/remote_commands_service.cc
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/ui/base/user_activity/user_activity_detector.cc
[modify] https://crrev.com/481a291fd77a809b5f5844192d674709679c776d/ui/base/user_activity/user_activity_detector.h

Status: Fixed (was: Untriaged)
Labels: M-53 OS-Chrome

Comment 6 by mlight@google.com, Jul 29 2016

Status: Verified (was: Fixed)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98991ca7a6c1ea7048f2ecf3246afdde6a1200df

commit 98991ca7a6c1ea7048f2ecf3246afdde6a1200df
Author: hunyadym <hunyadym@chromium.org>
Date: Fri Oct 14 16:14:00 2016

Replace CHROMEOS_SYSLOG logs with SYSLOG logs so remote command related
logs will get uploaded to the management console even after the kiosk
session started.

BUG= 602572 

Review-Url: https://codereview.chromium.org/2412963003
Cr-Commit-Position: refs/heads/master@{#425342}

[modify] https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc
[modify] https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
[modify] https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc
[modify] https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df/chrome/browser/chromeos/policy/status_uploader.cc
[modify] https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df/chrome/browser/chromeos/policy/upload_job_impl.cc
[modify] https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df/chrome/browser/policy/cloud/remote_commands_invalidator.cc
[modify] https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df/components/policy/core/common/remote_commands/remote_command_job.cc
[modify] https://crrev.com/98991ca7a6c1ea7048f2ecf3246afdde6a1200df/components/policy/core/common/remote_commands/remote_commands_service.cc

Labels: Merge-Request-55

Comment 9 by dimu@chromium.org, Oct 17 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 17 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bba6c3d447556798d4d00e2f54876a582957394

commit 1bba6c3d447556798d4d00e2f54876a582957394
Author: Andrew Wilson <atwilson@chromium.org>
Date: Mon Oct 17 09:58:03 2016

Replace CHROMEOS_SYSLOG logs with SYSLOG logs so remote command related logs will get uploaded to the management console even after the kiosk session started.

BUG= 602572 

Review-Url: https://codereview.chromium.org/2412963003
Cr-Commit-Position: refs/heads/master@{#425342}
(cherry picked from commit 98991ca7a6c1ea7048f2ecf3246afdde6a1200df)

Review URL: https://codereview.chromium.org/2427443004 .

Cr-Commit-Position: refs/branch-heads/2883@{#142}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/status_uploader.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/upload_job_impl.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/policy/cloud/remote_commands_invalidator.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/components/policy/core/common/remote_commands/remote_command_job.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/components/policy/core/common/remote_commands/remote_commands_service.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bba6c3d447556798d4d00e2f54876a582957394

commit 1bba6c3d447556798d4d00e2f54876a582957394
Author: Andrew Wilson <atwilson@chromium.org>
Date: Mon Oct 17 09:58:03 2016

Replace CHROMEOS_SYSLOG logs with SYSLOG logs so remote command related logs will get uploaded to the management console even after the kiosk session started.

BUG= 602572 

Review-Url: https://codereview.chromium.org/2412963003
Cr-Commit-Position: refs/heads/master@{#425342}
(cherry picked from commit 98991ca7a6c1ea7048f2ecf3246afdde6a1200df)

Review URL: https://codereview.chromium.org/2427443004 .

Cr-Commit-Position: refs/branch-heads/2883@{#142}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/status_uploader.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/chromeos/policy/upload_job_impl.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/chrome/browser/policy/cloud/remote_commands_invalidator.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/components/policy/core/common/remote_commands/remote_command_job.cc
[modify] https://crrev.com/1bba6c3d447556798d4d00e2f54876a582957394/components/policy/core/common/remote_commands/remote_commands_service.cc

Comment 12 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment