Issue metadata
Sign in to add a comment
|
Regression: Numeric value on ruler appears to be weird on chrome://tracing page.
Reported by
dchau...@etouch.net,
Apr 12 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 52.0.2706.0 (Official Build) 5ec069c3c18423f9dccc1beba5bea65d35efbb49-refs/heads/master@{#386523} 32/64-bit. OS: Windows(Win 7-Aero enabled) What steps will reproduce the problem? 1. Launch chrome, go to chrome://tracing page and click on 'Record' button. 2. Click on 'Record' button to record the traces and then click on 'Stop' button and observe the ruler. Ruler is not seen properly and looks weird. Ruler should seen properly. This is a regression issue, broken in M-52 series, will soon update other info.
,
Apr 12 2016
Adding release block label, please undo if not the case.
,
Apr 12 2016
r386467 is not responsible (doesn't have any interaction with this code).
,
Apr 12 2016
Sending to petrcermak@ to triage for tracing.
,
Apr 12 2016
It doesn't look like either of my changes in r386463 could have caused anything; both of my changes are in systrace, and I don't think that chrome://tracing uses systrace. nednguyen@, charliea@: Is that true that chrome://tracing doesn't use systrace?
,
Apr 12 2016
That's correct. This is a purely trace-viewer bug.
,
Apr 12 2016
I'm doing a manual bisect. My results so far: good: 7bacc0eaa9eb6edb22c9e2734e0e57e64e8b4125 (r386453) bad: 6a31ee36d65f80ca2626c8b629550eb4af1d851e (r386457) My biggest suspect at this point is a Skia roll: 17fc152ee3bb941b1043b76ad669ecea35ac86c7 (r386456)
,
Apr 12 2016
My gut feeling was right, the regression was caused by a Skia roll (17fc152ee3bb941b1043b76ad669ecea35ac86c7). Time to go deeper...
,
Apr 12 2016
And the winner of my manual bisect is... fef28606d2c51be627be3a656581882e31945c03: Switch SkPictureImageFilter over to new onFilterImage interface (https://codereview.chromium.org/1779743002)
,
Apr 12 2016
,
Apr 12 2016
,
Apr 13 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/0b7e5a13bd371126b5d5794f3f9d2930c35ce05f commit 0b7e5a13bd371126b5d5794f3f9d2930c35ce05f Author: robertphillips <robertphillips@google.com> Date: Wed Apr 13 14:18:41 2016 Make SkSpecialSurfaces always use kUnknown for their pixel geometry This now matches how the SkDevices were being created by the device proxy and prevents LCD text from being inadvertently applied. BUG= 602555 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1878143004 Review URL: https://codereview.chromium.org/1878143004 [modify] https://crrev.com/0b7e5a13bd371126b5d5794f3f9d2930c35ce05f/src/core/SkSpecialSurface.cpp [modify] https://crrev.com/0b7e5a13bd371126b5d5794f3f9d2930c35ce05f/src/effects/SkPictureImageFilter.cpp
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f22c3a892170c9101611344a8505e2fe019f33a commit 6f22c3a892170c9101611344a8505e2fe019f33a Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Wed Apr 13 15:50:31 2016 Roll src/third_party/skia/ 903ec3ce4..0b7e5a13b (1 commit). https://chromium.googlesource.com/skia.git/+log/903ec3ce4dae..0b7e5a13bd37 $ git log 903ec3ce4..0b7e5a13b --date=short --no-merges --format='%ad %ae %s' 2016-04-13 robertphillips Make SkSpecialSurfaces always use kUnknown for their pixel geometry BUG= 602555 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=borenet@google.com Review URL: https://codereview.chromium.org/1884993002 Cr-Commit-Position: refs/heads/master@{#387000} [modify] https://crrev.com/6f22c3a892170c9101611344a8505e2fe019f33a/DEPS
,
Apr 13 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/54ef1a7c95bcc8e507f7d6ccd9a49bd9a110ba90 commit 54ef1a7c95bcc8e507f7d6ccd9a49bd9a110ba90 Author: robertphillips <robertphillips@google.com> Date: Wed Apr 13 17:55:07 2016 Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters BUG= 602555 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1878373003 Review URL: https://codereview.chromium.org/1878373003 [modify] https://crrev.com/54ef1a7c95bcc8e507f7d6ccd9a49bd9a110ba90/gm/pictureimagefilter.cpp
,
Apr 13 2016
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/845767758e6b57c270432dda4f243a742179507b commit 845767758e6b57c270432dda4f243a742179507b Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Wed Apr 13 19:02:38 2016 Roll src/third_party/skia/ 2892668f1..54ef1a7c9 (1 commit). https://chromium.googlesource.com/skia.git/+log/2892668f1b36..54ef1a7c95bc $ git log 2892668f1..54ef1a7c9 --date=short --no-merges --format='%ad %ae %s' 2016-04-13 robertphillips Add GM to prevent mis-drawing of LCD text in SkPictureImageFilters BUG= 602555 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=borenet@google.com Review URL: https://codereview.chromium.org/1885953002 Cr-Commit-Position: refs/heads/master@{#387055} [modify] https://crrev.com/845767758e6b57c270432dda4f243a742179507b/DEPS |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dchau...@etouch.net
, Apr 12 2016Components: Internals>Tracing
Labels: hasbisect
Owner: alexandermont@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression: Numeric value on ruler appears to be weird on chrome://tracing page. (was: Regression: Ruler is seems to be weird on chrome://tracing page.)
19.0 KB
19.0 KB View Download
404 KB
404 KB Download
289 KB
289 KB Download