Regression : In devtools, page goes unresponsive after dragging the devtools window from left to right.
Reported by
mni...@etouch.net,
Apr 12 2016
|
||||||||||||
Issue descriptionChrome Version : 51.0.2704.4 5bcb06bd733f10474ea2f719aa594b13883a393e-refs/branch-heads/2704@{#6} (32/64-bit) OS : All(Win 7 aero enabled). What steps will reproduce the problem? 1. Launch chrome, open NTP and go to devtools. 2. Now select emulated view and open 'Sources' section and drag the devtools window from Left to right. 3. Now try to click any where on the page and observe. Actual: Page goes unresponsive after dragging the devtools window from left to right. Expected: Page should not go unresponsive after dragging the devtools window from left to right. This is a regression issue broken in 'M-51' and below is the manual regression and Narrow bisect info : Good Build: 51.0.2702.0 Bad Build: 51.0.2704.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/0b46091cb37b8fdd73a02675e2ab86850d51cb09..c0dfd6b2d5be7951bc1dfa61053f67d2514889f5?pretty=fuller&n=100 Suspecting: r385872 from Narrow bisect @lushnikov : Kindly help to re-assign, if your changes are not cause for this issue.
,
Apr 12 2016
This happens due to exception in the following code:
/**
* @return {boolean}
*/
Element.prototype.isInsertionCaretInside = function()
{
var selection = this.getComponentSelection();
if (!selection.rangeCount || !selection.isCollapsed)
return false;
var selectionRange = selection.getRangeAt(0);
return selectionRange.startContainer.isSelfOrDescendant(this);
}
The code assumes that the selectionRange is not a null, since selection.rangeCount is non-zero.
However, this is not the case, and thus an exception in the main thread is thrown.
,
Apr 12 2016
,
Apr 12 2016
This should be merged to M-50 and M-51.
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7eb9fc98d4038fc256ab580bb7f61ce796117d68 commit 7eb9fc98d4038fc256ab580bb7f61ce796117d68 Author: lushnikov <lushnikov@chromium.org> Date: Wed Apr 13 22:21:51 2016 DevTools: workaround bug in Blink selection API The patch works around the bug in the blink selection API, when the selection.rangeCount returns 1, but selection.getRangeAt(0) still returns null. BUG= 602541 , 595100 R=dgozman, pfeldman_ooo Review URL: https://codereview.chromium.org/1881233002 Cr-Commit-Position: refs/heads/master@{#387121} [modify] https://crrev.com/7eb9fc98d4038fc256ab580bb7f61ce796117d68/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
,
Apr 14 2016
Issue 602247 has been merged into this issue.
,
Apr 15 2016
,
Apr 15 2016
Verified working on Mac Chrome Canary 52.0.2709.0 Luckily, the current Beta 50 seems to be not affected - so would be nice to merge to 51 only.
,
Apr 15 2016
Approving merge to M51 branch 2704 based on Comment #7 & #8.
,
Apr 18 2016
Please merge your change to M51 branch 2704 ASAP (before 5:00 PM PST, today) so we can take it in for M51 last Dev release tomorrow.
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd81d5ade7fec37084a344302667df257eb25993 commit fd81d5ade7fec37084a344302667df257eb25993 Author: Andrey Lushnikov <lushnikov@chromium.org> Date: Mon Apr 18 22:25:50 2016 DevTools: workaround bug in Blink selection API The patch works around the bug in the blink selection API, when the selection.rangeCount returns 1, but selection.getRangeAt(0) still returns null. BUG= 602541 , 595100 R=dgozman, pfeldman_ooo Review URL: https://codereview.chromium.org/1881233002 (cherry picked from commit 7eb9fc98d4038fc256ab580bb7f61ce796117d68) Cr-Original-Commit-Position: refs/heads/master@{#387121} Cr-Commit-Position: refs/branch-heads/2704@{#114} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/fd81d5ade7fec37084a344302667df257eb25993/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
,
Apr 18 2016
,
Apr 19 2016
Verified the issue on Windows 7, Ubuntu 14.04 and Mac OS 10.11.4 using chrome latest Dev M51-51.0.2704.19. Observed the Dev tools are totally responsive and able to click menus after dragging the windows left to right. Hence adding TE-Verified label.
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ranjitkan@chromium.org
, Apr 12 2016