New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602540 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK if open via shortcut and USERPROFILE contains non-ascii character

Project Member Reported by se...@yandex-team.ru, Apr 12 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

Steps to reproduce the problem:
1. Ensure USERPROFILE contains non-ascii character.
2. Open DCHECK-enabled browser from a shortcut.

What is the expected behavior?
Browser successfully starts.

What went wrong?
[3280:7164:0412/103938:FATAL:utf_string_conversions.cc(222)] Check failed: IsStringASCII(ascii). C:\Users\╤В╨╡╤Б╤В
Backtrace:
        base::debug::StackTrace::StackTrace [0x10098CB1+33] (c:\browser\chromium\dev\src\base\debug\stack_trace_win.cc:215)
        logging::LogMessage::~LogMessage [0x100EDFEB+75] (c:\browser\chromium\dev\src\base\logging.cc:520)
        base::ASCIIToUTF16 [0x101E4218+232] (c:\browser\chromium\dev\src\base\strings\utf_string_conversions.cc:223)
        `anonymous namespace'::GetLaunchShortcutKind [0x09578DC5+373] (c:\browser\chromium\dev\src\chrome\browser\ui\startup\startup_browser_creator_impl.cc:164)
        `anonymous namespace'::RecordLaunchModeHistogram [0x0957BC66+38] (c:\browser\chromium\dev\src\chrome\browser\ui\startup\startup_browser_creator_impl.cc:180)
        StartupBrowserCreatorImpl::Launch [0x09579B55+821] (c:\browser\chromium\dev\src\chrome\browser\ui\startup\startup_browser_creator_impl.cc:349)
        StartupBrowserCreator::LaunchBrowser [0x0956F786+726] (c:\browser\chromium\dev\src\chrome\browser\ui\startup\startup_browser_creator.cc:369)
        StartupBrowserCreator::ProcessCmdLineImpl [0x09570DE9+2825] (c:\browser\chromium\dev\src\chrome\browser\ui\startup\startup_browser_creator.cc:736)
        StartupBrowserCreator::Start [0x09572563+323] (c:\browser\chromium\dev\src\chrome\browser\ui\startup\startup_browser_creator.cc:324)
        ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x0660BF6A+6250] (c:\browser\chromium\dev\src\chrome\browser\chrome_browser_main.cc:1741)
        ChromeBrowserMainParts::PreMainMessageLoopRun [0x0660A560+288] (c:\browser\chromium\dev\src\chrome\browser\chrome_browser_main.cc:1162)
        content::BrowserMainLoop::PreMainMessageLoopRun [0x1446B8C9+393] (c:\browser\chromium\dev\src\content\browser\browser_main_loop.cc:931)
        base::internal::RunnableAdapter<int (__thiscall content::BrowserMainLoop::*)(void)>::Run<> [0x1445BBBB+27] (c:\browser\chromium\dev\src\base\bind_internal.h:181)
        base::internal::InvokeHelper<0,int,base::internal::RunnableAdapter<int (__thiscall content::BrowserMainLoop::*)(void)> >::MakeItSo<content::BrowserMainLoop *> [0x1445BA0A+26] (c:\browser\chromium\dev\src\base\bind_internal.h:304)
        base::internal::Invoker<base::IndexSequence<0>,base::internal::BindState<base::internal::RunnableAdapter<int (__thiscall content::BrowserMainLoop::*)(void)>,int __cdecl(content::BrowserMainLoop *),base::internal::UnretainedWrapper<content::BrowserMainLoop [0x1446C107+71] (c:\browser\chromium\dev\src\base\bind_internal.h:364)
        base::Callback<int __cdecl(void),1>::Run [0x14D8475F+47] (c:\browser\chromium\dev\src\base\callback.h:397)
        content::StartupTaskRunner::RunAllTasksNow [0x15360F7E+126] (c:\browser\chromium\dev\src\content\browser\startup_task_runner.cc:45)
        content::BrowserMainLoop::CreateStartupTasks [0x14466156+774] (c:\browser\chromium\dev\src\content\browser\browser_main_loop.cc:806)
        content::BrowserMainRunnerImpl::Initialize [0x14473072+1346] (c:\browser\chromium\dev\src\content\browser\browser_main_runner.cc:140)
        content::BrowserMain [0x14459CC5+181] (c:\browser\chromium\dev\src\content\browser\browser_main.cc:42)
        content::RunNamedProcessTypeMain [0x140DDAD9+169] (c:\browser\chromium\dev\src\content\app\content_main_runner.cc:381)
        content::ContentMainRunnerImpl::Run [0x140DD8F6+598] (c:\browser\chromium\dev\src\content\app\content_main_runner.cc:742)
        content::ContentMain [0x140C90A0+144] (c:\browser\chromium\dev\src\content\app\content_main.cc:20)
        ChromeMain [0x06303128+168] (c:\browser\chromium\dev\src\chrome\app\chrome_main.cc:84)
        MainDllLoader::Launch [0x00426E31+1025] (c:\browser\chromium\dev\src\chrome\app\main_dll_loader_win.cc:183)
        wWinMain [0x004215A7+903] (c:\browser\chromium\dev\src\chrome\app\chrome_exe_main_win.cc:268)
        __tmainCRTStartup [0x00544F1C+540] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:618)
        wWinMainCRTStartup [0x0054505D+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
        BaseThreadInitThunk [0x7565338A+18]
        RtlInitializeExceptionChain [0x773C9A02+99]
        RtlInitializeExceptionChain [0x773C99D5+54]

Did this work before? No 

Chrome version: 52.0.2706.0  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 21.0 r0

Environment::GetVar() returns UTF8, but failed code thinks that there must be ASCII.
 

Comment 1 by b...@chromium.org, Apr 12 2016

Components: UI>Browser>Profiles
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41fc1171445d71c5d1d8352f3f0a021238da3638

commit 41fc1171445d71c5d1d8352f3f0a021238da3638
Author: sense <sense@yandex-team.ru>
Date: Wed Apr 13 05:41:47 2016

Fix Environment::GetVar() result converting to UTF16.

Environment::GetVar() returns UTF8, but the code in GetLaunchShortcutKind() thinks that there must be ASCII.

R=pkasting@chromium.org
BUG= 602540 

Review URL: https://codereview.chromium.org/1877223002

Cr-Commit-Position: refs/heads/master@{#386919}

[modify] https://crrev.com/41fc1171445d71c5d1d8352f3f0a021238da3638/chrome/browser/ui/startup/startup_browser_creator_impl.cc

Project Member

Comment 3 by sheriffbot@chromium.org, Dec 19 2016

Cc: ew...@chromium.org bzanotti@chromium.org msarda@chromium.org
Status: WontFix (was: Unconfirmed)
--Chrome Identity automated triaging--

This bug is Unconfirmed and has gone two weeks without any activity, so it is being closed as WontFix. Please re-open if this is still a valid and reproducible bug or feature request and mark it as Available. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: WontFix)

Sign in to add a comment