ssia
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58256ff511a983238942e5699965b6fa0d3a3ea9 commit 58256ff511a983238942e5699965b6fa0d3a3ea9 Author: dbeam <dbeam@chromium.org> Date: Thu Apr 14 03:02:23 2016 MD Settings: polish top-level bluetooth page R=stevenjb@chromium.org BUG= 602538 Review URL: https://codereview.chromium.org/1875413002 Cr-Commit-Position: refs/heads/master@{#387220} [modify] https://crrev.com/58256ff511a983238942e5699965b6fa0d3a3ea9/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/58256ff511a983238942e5699965b6fa0d3a3ea9/chrome/browser/resources/settings/bluetooth_page/bluetooth_add_device_dialog.html [delete] https://crrev.com/dc0d234f7c87d29e9d070249a5dd601141faff5b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.css [modify] https://crrev.com/58256ff511a983238942e5699965b6fa0d3a3ea9/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html [delete] https://crrev.com/dc0d234f7c87d29e9d070249a5dd601141faff5b/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.css [modify] https://crrev.com/58256ff511a983238942e5699965b6fa0d3a3ea9/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/58256ff511a983238942e5699965b6fa0d3a3ea9/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js [modify] https://crrev.com/58256ff511a983238942e5699965b6fa0d3a3ea9/chrome/browser/resources/settings/bluetooth_page/bluetooth_pair_device_dialog.html [modify] https://crrev.com/58256ff511a983238942e5699965b6fa0d3a3ea9/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/58256ff511a983238942e5699965b6fa0d3a3ea9/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/58256ff511a983238942e5699965b6fa0d3a3ea9/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe commit 7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe Author: dbeam <dbeam@chromium.org> Date: Tue Apr 19 18:52:42 2016 MD Settings: move bluetooth dialog styles to a shared import R=stevenjb@chromium.org BUG= 602538 Review URL: https://codereview.chromium.org/1896963003 Cr-Commit-Position: refs/heads/master@{#388260} [modify] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/chrome/browser/resources/settings/bluetooth_page/bluetooth_add_device_dialog.html [delete] https://crrev.com/56f9c7717b86f7a67b70257f3d61dd6c7187a7fc/chrome/browser/resources/settings/bluetooth_page/bluetooth_dialog.css [add] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/chrome/browser/resources/settings/bluetooth_page/bluetooth_dialog_shared_css.html [modify] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/chrome/browser/resources/settings/bluetooth_page/bluetooth_pair_device_dialog.html [modify] https://crrev.com/7407e9b1ba4b3f3d70dfdb60b098f5df873d66fe/chrome/browser/resources/settings/settings_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55403528a28add7cec94a81bbef29a42ee6dee6d commit 55403528a28add7cec94a81bbef29a42ee6dee6d Author: dbeam <dbeam@chromium.org> Date: Wed May 11 23:19:47 2016 MD Settings: combine bluetooth adding and pairing dialogs into one <settings-dialog> This CL is intentionally meant to do as little modification of the existing code as possible, but mainly to combine and iterate. There are many visual issues caused by this CL that will live very temporarily. Next step: move bluetooth_dialog_shared_css.html into a <style> tag in bluetooth_device_dialog.html. R=stevenjb@chromium.org BUG= 602538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1954383002 Cr-Commit-Position: refs/heads/master@{#393102} [delete] https://crrev.com/f2d4f91d5314bac20cfc06cb180b61ed41eea068/chrome/browser/resources/settings/bluetooth_page/bluetooth_add_device_dialog.html [delete] https://crrev.com/f2d4f91d5314bac20cfc06cb180b61ed41eea068/chrome/browser/resources/settings/bluetooth_page/bluetooth_add_device_dialog.js [add] https://crrev.com/55403528a28add7cec94a81bbef29a42ee6dee6d/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [rename] https://crrev.com/55403528a28add7cec94a81bbef29a42ee6dee6d/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js [modify] https://crrev.com/55403528a28add7cec94a81bbef29a42ee6dee6d/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [delete] https://crrev.com/f2d4f91d5314bac20cfc06cb180b61ed41eea068/chrome/browser/resources/settings/bluetooth_page/bluetooth_pair_device_dialog.html [modify] https://crrev.com/55403528a28add7cec94a81bbef29a42ee6dee6d/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp [modify] https://crrev.com/55403528a28add7cec94a81bbef29a42ee6dee6d/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/55403528a28add7cec94a81bbef29a42ee6dee6d/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7f6b761518b0450d53a5e0db65df71a1f62855d commit f7f6b761518b0450d53a5e0db65df71a1f62855d Author: dbeam <dbeam@chromium.org> Date: Wed May 11 23:54:21 2016 MD Settings: inline bluetooth_dialog_shared_css.html now that it's only used in 1 place. R=stevenjb@chromium.org BUG= 602538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1954413002 Cr-Commit-Position: refs/heads/master@{#393110} [modify] https://crrev.com/f7f6b761518b0450d53a5e0db65df71a1f62855d/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [delete] https://crrev.com/621bf9b555524998e1dac48faf7d4032d7bd7605/chrome/browser/resources/settings/bluetooth_page/bluetooth_dialog_shared_css.html [modify] https://crrev.com/f7f6b761518b0450d53a5e0db65df71a1f62855d/chrome/browser/resources/settings/settings_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94c2e7d73b8c3996f7c878c539329ebac807c860 commit 94c2e7d73b8c3996f7c878c539329ebac807c860 Author: dbeam <dbeam@chromium.org> Date: Sat May 14 01:02:58 2016 MD Settings: combine title and ways of closing Bluetooth device dialog R=stevenjb@chromium.org BUG= 602538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1976733002 Cr-Commit-Position: refs/heads/master@{#393716} [modify] https://crrev.com/94c2e7d73b8c3996f7c878c539329ebac807c860/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [modify] https://crrev.com/94c2e7d73b8c3996f7c878c539329ebac807c860/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js [modify] https://crrev.com/94c2e7d73b8c3996f7c878c539329ebac807c860/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
see also: https://codereview.chromium.org/1974193002 https://codereview.chromium.org/2002363002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f16e174c0b43eb00657d768bdcc582929e9b4735 commit f16e174c0b43eb00657d768bdcc582929e9b4735 Author: dbeam <dbeam@chromium.org> Date: Thu May 26 01:10:50 2016 MD Settings: make bluetooth dialog resize like other settings-dialogs Just call notifyResize() when devices change and use the same resize logic. R=stevenjb@chromium.org BUG= 602538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2009023003 Cr-Commit-Position: refs/heads/master@{#396070} [modify] https://crrev.com/f16e174c0b43eb00657d768bdcc582929e9b4735/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [modify] https://crrev.com/f16e174c0b43eb00657d768bdcc582929e9b4735/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js [modify] https://crrev.com/f16e174c0b43eb00657d768bdcc582929e9b4735/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp
i think we've gotten pretty far here, but there's still things changing and potential feature work here, so I'm unassigning for now
FWIW, we should't use this to track feature work, so unless there is known polish work to be done I would close this rather than leaving it unassigned. We can always open a new issue (and this one already has several associated CLs).
Yep, there is known polish work. Mocks are being updated.
Here are the updated mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW_Bluetooth.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b commit f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b Author: stevenjb <stevenjb@chromium.org> Date: Sat Jul 16 02:10:34 2016 MD Settings: Bluetooth: Additional polish This CL: * Does some code cleanup * Fixes showing and enabling of the Connect button * Fixes pincode and passkey logic * Disables the 'enable' UI when bluetooth is not available. BUG= 602538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2148573003 Cr-Commit-Position: refs/heads/master@{#405921} [modify] https://crrev.com/f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [modify] https://crrev.com/f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js [modify] https://crrev.com/f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js [modify] https://crrev.com/f2bdfb96231eb8e5dc6a0d5a3241be103dbedb0b/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/148e478e5800f9664b2f89536d2985e8cfd8a95f commit 148e478e5800f9664b2f89536d2985e8cfd8a95f Author: stevenjb <stevenjb@chromium.org> Date: Sat Jul 16 06:52:31 2016 MD Settings: Bluetooth: Add error dialog and messages BUG= 602538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2146553005 Cr-Commit-Position: refs/heads/master@{#405938} [modify] https://crrev.com/148e478e5800f9664b2f89536d2985e8cfd8a95f/chrome/app/settings_strings.grdp [modify] https://crrev.com/148e478e5800f9664b2f89536d2985e8cfd8a95f/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [modify] https://crrev.com/148e478e5800f9664b2f89536d2985e8cfd8a95f/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js [modify] https://crrev.com/148e478e5800f9664b2f89536d2985e8cfd8a95f/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/148e478e5800f9664b2f89536d2985e8cfd8a95f/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js [modify] https://crrev.com/148e478e5800f9664b2f89536d2985e8cfd8a95f/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/148e478e5800f9664b2f89536d2985e8cfd8a95f/chrome/test/data/webui/i18n_behavior_test.html [modify] https://crrev.com/148e478e5800f9664b2f89536d2985e8cfd8a95f/ui/webui/resources/js/i18n_behavior.js
I am going to call this good. Any isses that come up at this point should be filed as separate bugs.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/003a037bb7b06772d7a4d06abc01b18b012229a6 commit 003a037bb7b06772d7a4d06abc01b18b012229a6 Author: stevenjb <stevenjb@chromium.org> Date: Wed Aug 17 19:04:14 2016 MD Settings: Bluetooth polish Some extra bluettoth polish: * Fixed height for the bluetooth dialog * Correctly center dialog contents * Blue spinners for all chrome WebUI * Focus dialog inputs BUG= 602538 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2218713002 Cr-Commit-Position: refs/heads/master@{#412604} [modify] https://crrev.com/003a037bb7b06772d7a4d06abc01b18b012229a6/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [modify] https://crrev.com/003a037bb7b06772d7a4d06abc01b18b012229a6/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js [modify] https://crrev.com/003a037bb7b06772d7a4d06abc01b18b012229a6/ui/webui/resources/cr_elements/shared_style_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad35751666b58d9ff414cb31c01ba5eba794f882 commit ad35751666b58d9ff414cb31c01ba5eba794f882 Author: stevenjb <stevenjb@chromium.org> Date: Fri Aug 26 22:27:42 2016 MD Settings: Bluetooth: Use CrScrollableBehavior BUG= 602538 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2256773005 Cr-Commit-Position: refs/heads/master@{#414833} [modify] https://crrev.com/ad35751666b58d9ff414cb31c01ba5eba794f882/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [modify] https://crrev.com/ad35751666b58d9ff414cb31c01ba5eba794f882/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js [modify] https://crrev.com/ad35751666b58d9ff414cb31c01ba5eba794f882/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html [modify] https://crrev.com/ad35751666b58d9ff414cb31c01ba5eba794f882/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js [modify] https://crrev.com/ad35751666b58d9ff414cb31c01ba5eba794f882/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/ad35751666b58d9ff414cb31c01ba5eba794f882/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js [modify] https://crrev.com/ad35751666b58d9ff414cb31c01ba5eba794f882/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp [modify] https://crrev.com/ad35751666b58d9ff414cb31c01ba5eba794f882/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
Comment 1 by bugdroid1@chromium.org
, Apr 14 2016