I think we need a bit of UX expertise here. pschaffner@, what do you think? How about a "Got It" button?

There's nothing wrong with the "x" close boxes - I think everyone understands how to use them, and they are not foreign on the Mac platform.

The problem is when you have an "x" close box *and* an OK button. On the Mac, a panel with an OK button says that the panel is modal, in which case you can/should only be able to dismiss it by choosing a button option (most commonly OK or Cancel).

If all of these panels look like BeyondCorp (i.e. purely informative), you could go ahead and add back the "x". I'm confused, though, by the Google Docs panel - does that popup button take action when you choose one of its items or does it allow you to select an option from its list? If it takes action it needs to be changed to some other kind of control. If it allows you to select an option there need to be OK and Cancel buttons at the bottom.

Current behaviour is:

Changing the combo immediately adjusts some configuration state - I think its behaviour is consistent e.g. with combos in System Preferences, where there's no OK/Cancel buttons either.

"Create shortcuts..." takes action after an app-modal confirmation prompt. App Info stays open with either option ("Cancel" or "Create").

"Remove..." takes action after an app-modal confirmation prompt. App Info stays open with "Cancel" but closes if you choose "Remove" (the extension is gone, so there's nothing to show).

OK, fired this up in Canary. I didn't realize this was a modal panel. Modal panels cannot have "x" buttons to close them. There needs to be a button to dismiss the panel. I don't know what that means for layout of the panel when it needs to include other buttons at the bottom.

 Issue 604332  has been merged into this issue.

So should we add a default (blue) button to the dialog in the bottom right?

Should the label be:
 - Same as bookmark/browser action bubbles ("Done" in US-English, "Finished" in UK-English)
 - Same as collected cookies dialog ("Close")
 - "OK" like Safari (e.g. click padlock), and the OS-provided certificate viewer that Chrome uses (even though Apple HIG say ~"OK is ambiguous - don't use it")
 - "Cancel" because Apple HIG say "In general, include a Cancel button"

If you need to address this very soon you should go ahead and add a button and set the title to Done (Close is odd, OK and Cancel don't quit make sense).

If this does not need to be addressed in the very near future, UX is still figuring out dialogs and close buttons, so it's not clear how this panel will ultimately look.

There's no particular urgency to this, since that dialog isn't in phase 2.

This dialog doesn't need to block Harmony since it doesn't exist on Cocoa browser.

But also this bug is sorta resolved since under Harmony it got a big `X` button back, with hover effects.

Still, I think in Mac it should have a `Done/Finished` button.

Screengrab from 57.0.2943.0 canary.

Deleted: Screen Shot 2016-12-07 at 5.19.14 pm.png 42.0 KB

	Screen Shot 2016-12-07 at 5.19.14 pm.png 42.0 KB View Download

Since this dialog doesn't exist on Mac, this won't matter until MacViews-Browser, so I'm tagging this MacViews-Browser.

tapted@, I'm going to hand this one to you because you know about apps, but it's M-X because of #14.

MacViews triage: Let's target fixing this (in the Views browser) at M-68. Assigning to spqchan@ for that.

Note this entire dialog may be on the chopping block. Most of its functionality is being subsumed by chrome://flags/#enable-md-extensions  (i.e. you get the same info this native dialog provides by going to chrome://extensions ).

Thanks for the heads up. Who should I talk to check on this?

Perhaps Devlin? He probably knows best what the plans for MD chrome://extensions is and whether we want to drop the separate app info dialog (i.e. have the current 'App Info' menu entries direct instead to the extensions details page under chrome://extensions).

We want to remove the app info dialog on the chrome extensions page, which, if we're only worried about mac, is all that matters here.  We may need to keep it on CrOS (where I think it's used through the finder as well).

Thanks for the update, Devlin! In that case, I think it should be safe to just close this bug, unless it will take a really long time to remove the App Info Dialog.

Any thoughts? 

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

MD extensions is launched on Mac, so I think we're probably good!  (We still need to clean up the code, but the dialog shouldn't be displayed.)

Awesome, thanks!