New issue
Advanced search Search tips

Issue 602497 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 477150



Sign in to add a comment

Inconsistent console messages about mixed content, when running with or without --site-per-process

Project Member Reported by lukasza@chromium.org, Apr 11 2016

Issue description

Repro:
======

DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn -v --additional-drt-flag=--site-per-process --no-retry-failures --additional-drt-flag=--no-sandbox http/tests/security/mixedContent

Observed text diffs from the expected test output:


Diff #1:
========

This kind of diff is only present in http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed.html

Extra 2nd line below - same as 1st line but with shortened URI of the originating page:

CONSOLE WARNING: Mixed Content: The page at 'https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-iframe.html' was loaded over HTTPS, but requested an insecure resource 'http://127.0.0.1:8080/security/mixedContent/resources/boring.html'. This content should also be served over HTTPS.
CONSOLE WARNING: Mixed Content: The page at 'https://127.0.0.1:8443/' was loaded over HTTPS, but requested an insecure resource 'http://127.0.0.1:8080/security/mixedContent/resources/boring.html'. This content should also be served over HTTPS.


Diff #2:
========

This kind of diff is kind-of present both in
http/tests/security/mixedContent/active-subresource-in-http-iframe-not-blocked.https.html
and in
http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed.html

An output line is almost the same as expected, but URI of the originating page is shortened:

CONSOLE WARNING: Mixed Content: The page at 'https://127.0.0.1:8443/security/mixedContent/active-subresource-in-http-iframe-not-blocked.https.html' was loaded over HTTPS, but requested an insecure script 'http://127.0.0.1:8000/security/mixedContent/resources/script-post-message.js'. This content should also be served over HTTPS.
CONSOLE WARNING: Mixed Content: The page at 'https://127.0.0.1:8443/' was loaded over HTTPS, but requested an insecure script 'http://127.0.0.1:8000/security/mixedContent/resources/script-post-message.js'. This content should also be served over HTTPS.

 
BTW: I thought that we already had a bug about this kind of a difference (shortening of the page URI in mixed content warnings), but I couldn't find it now...  Please shout (and dedupe) if I missed it.
Oh, I forgot to mention that the repro depends on some other fixes, which are currently queued up in https://codereview.chromium.org/1878863002/
Found the earlier bug -  issue 582522  (although it only really covers "diff #2", so maybe it makes sense to keep both bugs).

Comment 4 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Comment 5 by sshru...@google.com, May 18 2016

Components: -Blink>LayoutTests
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20030433ab4e8a95ea00dde8697bd20692c3de0d

commit 20030433ab4e8a95ea00dde8697bd20692c3de0d
Author: lukasza <lukasza@chromium.org>
Date: Thu Nov 10 18:05:13 2016

Adjust expectations for layout tests that are passing now w/ --site-per-process.

BUG= 554119 ,  602497 

Review-Url: https://codereview.chromium.org/2491813002
Cr-Commit-Position: refs/heads/master@{#431287}

[modify] https://crrev.com/20030433ab4e8a95ea00dde8697bd20692c3de0d/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eb2db5b44e5076cac3d634ffd5332cb96b92ea3

commit 1eb2db5b44e5076cac3d634ffd5332cb96b92ea3
Author: Alex Moshchuk <alexmos@chromium.org>
Date: Wed Jul 26 23:44:05 2017

Update site-per-process expectations for new virtual layout test suite.

The following tests need to be disabled for --site-per-process in
the new off-main-thread-fetch virtual suite:

virtual/off-main-thread-fetch/http/tests/security/mixedContent/
  insecure-iframe-in-main-frame.html
  insecure-iframe-in-main-frame-allowed.html
  insecure-iframe-in-iframe.html

TBR=creis@chromium.org
NOTRY=true

Bug:  602497 ,  602493 
Change-Id: I28f999fc124bd1f94b4ac5b4cf6b6feedb03eb9f
Reviewed-on: https://chromium-review.googlesource.com/587832
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489800}
[modify] https://crrev.com/1eb2db5b44e5076cac3d634ffd5332cb96b92ea3/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62db39d8dec89187c2518d0046b7ca28d9fc747d

commit 62db39d8dec89187c2518d0046b7ca28d9fc747d
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Oct 04 23:23:03 2017

Disable exceptions for tests that have "healed" themselves.

Bug:  758075 ,  700535 ,  582522 ,  602497 ,  616905 
Bug:  623268 ,  623265 ,  678492 
Change-Id: I1bdc648c9aeb97cc1d16b0d8693d04e0c76030de
Reviewed-on: https://chromium-review.googlesource.com/700983
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506557}
[modify] https://crrev.com/62db39d8dec89187c2518d0046b7ca28d9fc747d/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Status: Fixed (was: Untriaged)
Both Site Isolation FYI bots are green - closing this as fixed.  It most likely got fixed by PlzNavigate moving mixed-content checks to the browser.

Sign in to add a comment