New issue
Advanced search Search tips

Issue 602493 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 583093
Owner: ----
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 477150



Sign in to add a comment

Layout tests harness doesn't support history dump across OOPIFs

Project Member Reported by lukasza@chromium.org, Apr 11 2016

Issue description

Repro (depends on https://crrev.com/1878863002):

DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn -v --additional-drt-flag=--site-per-process --no-retry-failures --additional-drt-flag=--no-sandbox http/tests/security/mixedContent/insecure-iframe-in-main-frame.html

Running the test above will crash:

STDERR: [7141:7141:0411/153056:885092839027:FATAL:blink_test_runner.cc(618)] Check failed: false. 
STDERR: #0 0x000000536a91 __interceptor_backtrace
STDERR: #1 0x7f5c2d812763 base::debug::StackTrace::StackTrace()
STDERR: #2 0x7f5c2d87e1d8 logging::LogMessage::~LogMessage()
STDERR: #3 0x000001aa6c4c content::BlinkTestRunner::DumpHistoryForWindow()
STDERR: #4 0x000001aa6dd2 content::BlinkTestRunner::DumpHistoryForWindow()
STDERR: #5 0x7f5c24a44edb test_runner::WebTestProxyBase::DumpBackForwardLists()
STDERR: #6 0x000001aac099 content::BlinkTestRunner::OnLayoutDumpCompleted()
STDERR: #7 0x000001aa58ce content::BlinkTestRunner::CaptureDump()
 

Comment 1 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Comment 2 by sshru...@google.com, May 18 2016

Components: -Blink>LayoutTests
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.
Mergedinto: 583093
Status: Duplicate (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eb2db5b44e5076cac3d634ffd5332cb96b92ea3

commit 1eb2db5b44e5076cac3d634ffd5332cb96b92ea3
Author: Alex Moshchuk <alexmos@chromium.org>
Date: Wed Jul 26 23:44:05 2017

Update site-per-process expectations for new virtual layout test suite.

The following tests need to be disabled for --site-per-process in
the new off-main-thread-fetch virtual suite:

virtual/off-main-thread-fetch/http/tests/security/mixedContent/
  insecure-iframe-in-main-frame.html
  insecure-iframe-in-main-frame-allowed.html
  insecure-iframe-in-iframe.html

TBR=creis@chromium.org
NOTRY=true

Bug:  602497 ,  602493 
Change-Id: I28f999fc124bd1f94b4ac5b4cf6b6feedb03eb9f
Reviewed-on: https://chromium-review.googlesource.com/587832
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489800}
[modify] https://crrev.com/1eb2db5b44e5076cac3d634ffd5332cb96b92ea3/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db57d8325c7ba637033afd7d59f0aa9cc8749070

commit db57d8325c7ba637033afd7d59f0aa9cc8749070
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Oct 04 17:18:52 2017

No longer expect crashes for insecure-iframe-in-main-frame.html test.

After r505922, the
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html test
will no longer crash, but we still have a test output difference with
--site-per-process because of https://crbug.com/771003 (because with
--site-per-process the newly opened https window is in a different
process than the main test frame).

Bug:  602493 , 770487
Change-Id: Ic19079c0edbb6c74cb2a2d408acada00340d8973
Notry: True
Reviewed-on: https://chromium-review.googlesource.com/699764
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506425}
[modify] https://crrev.com/db57d8325c7ba637033afd7d59f0aa9cc8749070/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Sign in to add a comment