New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602488 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

IME doesn't show up.

Project Member Reported by khushals...@chromium.org, Apr 11 2016

Issue description

Open google.com and tap on the search box. You should see the keyboard come up but you only see the blinking cursor.
This is a regression.
 
Status: Started (was: Assigned)
Apparently, I am not getting a call to BlimpEngineSession::OnShowImeIfNeeded due to some recent changes
Cc: ekaramad@chromium.org
As discussed with shaktisahu@ offline, this seems to be my CL https://codereview.chromium.org/1652483002/. I am working on a short fix which was verified by shaktisahu@.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c

commit 6bb171a404c2e9a951a1c8c980fc316da4b7fd7c
Author: ekaramad <ekaramad@chromium.org>
Date: Fri Apr 15 22:09:36 2016

Revert of Browser Side Text Input State Tracking for OOPIF (Manual).

The original patch (https://codereview.chromium.org/1652483002/) led to
many regressions. This CL is a manual revert of that patch, plus several
dependent CLs that landed subsequently.

Revert "Browser Side Text Input State Tracking for OOPIF."
This reverts commit 2bd4a2f0c0f114979d47f4498ea1bce9b091591e.

Revert "Disable WebViewTextInputStateInteractiveTest.TopLevelWebContentsTracksCorrectly on Win"
This reverts commit ce2d8a33e2f0b9c742a67ba47618eb9e9172d825.

Revert "Disable WebViewTextInputStateInteractiveTest.TopLevelWebContentsTracksCorrectly on Mac"
This reverts commit 83e4dfa6bc12f0fb1a5da73fc82f19776a158c75.

Revert "Initialize TextInputState::TextInputState::show_ime_if_needed in the constructor."
This reverts commit 0c15a6bce78d7dc48bdaac09d90dc8cd55893b6f.

Revert "Add the missing text input state tracking code to RenderWidgetHostViewMac."
This reverts commit 46248c7ed4872cffc4ebb0b9da458678f7d7e7a3.

Revert "Reset Text Input State for RenderWidgetHostView before RenderWidgetHost Detaches from Delegate"
This reverts commit 5292d041d34d49e8c3e851a0e21504a983e5be57.

BUG= 578168 ,  546645 ,  601570 ,  601738 ,  602144 ,  602488 , 602926,  602954 , 603209,  603676 , 603886
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1889313002

Cr-Commit-Position: refs/heads/master@{#387715}

[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/background.js
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/guest.html
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/manifest.json
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.html
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.js
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/DEPS
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/interstitial_page_impl.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mus.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/renderer_host/render_widget_host_view_mus.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/site_per_process_browsertest.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/browser/web_contents/web_contents_impl.h
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/content/common/text_input_state.cc
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/content/common/text_input_state.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/common/view_messages.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/content_common.gypi
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/public/test/browser_test_utils.h
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/renderer/render_widget.cc
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/content/test/data/textinput/page_with_input.html
[delete] https://crrev.com/668d6c81de9e5b821ed96671f4f435093fafa404/content/test/data/textinput/page_with_input_iframeX2_input.html
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/test/test_render_view_host.cc
[modify] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/content/test/test_render_view_host.h

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 18 2016

Labels: merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46b778341feee9da0294c6138d860ad20dffca90

commit 46b778341feee9da0294c6138d860ad20dffca90
Author: ekaramad <ekaramad@chromium.org>
Date: Mon Apr 18 20:44:49 2016

Revert "Browser Side Text Input State Tracking for OOPIF."

The original patch (https://codereview.chromium.org/1652483002/) led to
many regressions. This CL is a manual revert of that patch, plus several
dependent CLs that landed subsequently.

Revert "Browser Side Text Input State Tracking for OOPIF."
This reverts commit 2bd4a2f0c0f114979d47f4498ea1bce9b091591e.

Revert "Initialize TextInputState::TextInputState::show_ime_if_needed in the constructor."
This reverts commit 0c15a6bce78d7dc48bdaac09d90dc8cd55893b6f.

Revert "Add the missing text input state tracking code to RenderWidgetHostViewMac."
This reverts commit 73a3921eff94c55d259dac5d1536a6b4bc88345a.

BUG= 578168 ,  546645 ,  601424 ,  601570 ,  601738 ,  602144 ,  602488 , 602926,  602954 , 603209,  603676 , 603886
NOTRY=true
NOPRESUBMIT=true

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1898803002

Cr-Commit-Position: refs/branch-heads/2704@{#108}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/background.js
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/guest.html
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/manifest.json
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.html
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/chrome/test/data/extensions/platform_apps/web_view/text_input_state/window.js
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/DEPS
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/interstitial_page_impl.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mus.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/renderer_host/render_widget_host_view_mus.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/site_per_process_browsertest.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/browser/web_contents/web_contents_impl.h
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/content/common/text_input_state.cc
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/content/common/text_input_state.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/common/view_messages.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/content_common.gypi
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/public/test/browser_test_utils.h
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/renderer/render_widget.cc
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/content/test/data/textinput/page_with_input.html
[delete] https://crrev.com/73ebab994224d08a93500fe8dc8e328ca0ac58ec/content/test/data/textinput/page_with_input_iframeX2_input.html
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/test/test_render_view_host.cc
[modify] https://crrev.com/46b778341feee9da0294c6138d860ad20dffca90/content/test/test_render_view_host.h

Status: Fixed (was: Started)
Labels: Archive-Blimp

Sign in to add a comment