Issue 602487 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	█ ananta@chromium.org Last visit > 30 days ago
Closed:	Jul 2016
Cc:	█ mfomitchev@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
Stability-Valgrind VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

ash_unittests failing on ChromeOS Valgrind

Project Member Reported by thestig@chromium.org, Apr 11 2016

Issue description

Started with https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/42288 and still failing. The only ash change in the blamelist is r386136. PTAL.

----
CursorWindowControllerTest.DSF:
Xlib:  extension "RANDR" missing on display ":9".
[17461:17461:0408/134618:2528410422:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0xf9cc790
../../ash/display/cursor_window_controller_unittest.cc:164: Failure
Value of: GetCursorImage().HasRepresentation(2.0f)
Actual: false
Expected: true
../../ash/display/cursor_window_controller_unittest.cc:170: Failure
Value of: GetCursorImage().HasRepresentation(2.0f)
Actual: false
Expected: true
[17461:17461:0408/134619:2529568638:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0xf9cc790
----

----
WindowManagerTest.MouseEventCursors:
Xlib:  extension "RANDR" missing on display ":9".
[17461:17461:0408/141853:4483510057:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0xf5c1920
../../ash/wm/window_manager_unittest.cc:509: Failure
Value of: host->last_cursor().native_type()
Actual: 0
Expected: ui::kCursorPointer
Which is: 1
[17461:17461:0408/141855:4484798754:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0xf5c1920
----

----
WindowManagerTest.TestCursorClientObserver:
Xlib:  extension "RANDR" missing on display ":9".
[17461:17461:0408/141901:4491632360:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0xe46bcf0
../../ash/wm/window_manager_unittest.cc:821: Failure
Value of: observer_a.did_visibility_change()
Actual: false
Expected: true
../../ash/wm/window_manager_unittest.cc:822: Failure
Value of: observer_b.did_visibility_change()
Actual: false
Expected: true
[17461:17461:0408/141903:4492750084:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0xe46bcf0
----

----
WindowManagerTest.UpdateCursorVisibilityAccelerator:
Xlib:  extension "RANDR" missing on display ":9".
[17461:17461:0408/141900:4490356232:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0xc333eb0
../../ash/wm/window_manager_unittest.cc:778: Failure
Value of: cursor_manager->IsCursorVisible()
Actual: false
Expected: true
[17461:17461:0408/141901:4491396357:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0xc333eb0
----

Comment 1 by thestig@chromium.org, Apr 11 2016

Labels: OS-Chrome

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc448256e3cdf70fa47cb921536d3e39d5055c0

commit abc448256e3cdf70fa47cb921536d3e39d5055c0
Author: thestig <thestig@chromium.org>
Date: Tue Apr 12 00:14:19 2016

Valgrind: Address redness on the memory.fyi bots.

1) Update a suppression
2) Disable failing ash_unittests test cases.
3) Disable failing NativeDesktopMediaListTests.

TBR=glider@chromium.org
BUG=562431, 602487 , 602494 

Review URL: https://codereview.chromium.org/1877113002

Cr-Commit-Position: refs/heads/master@{#386529}

[modify] https://crrev.com/abc448256e3cdf70fa47cb921536d3e39d5055c0/tools/valgrind/gtest_exclude/ash_unittests.gtest-memcheck.txt
[modify] https://crrev.com/abc448256e3cdf70fa47cb921536d3e39d5055c0/tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt
[modify] https://crrev.com/abc448256e3cdf70fa47cb921536d3e39d5055c0/tools/valgrind/memcheck/suppressions.txt

Comment 3 by mfomitchev@chromium.org, Apr 12 2016

Cc: mfomitchev@chromium.org
Owner: ananta@chromium.org
Status: Assigned (was: Untriaged)

I suspect https://codereview.chromium.org/1870743003 has caused this. @ananta - can you PTAL?

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2b280f227d364e58576c282958837289aa87b52

commit f2b280f227d364e58576c282958837289aa87b52
Author: ananta <ananta@chromium.org>
Date: Wed Apr 13 21:49:35 2016

Attempt to fix ash tests on Chrome OS valgrind

Revert "Valgrind: Address redness on the memory.fyi bots."

This reverts commit abc448256e3cdf70fa47cb921536d3e39d5055c0.

Fix for these tests is to reset the cursor state before each Ash test.

BUG= 602487 

Review URL: https://codereview.chromium.org/1885653003

Cr-Commit-Position: refs/heads/master@{#387108}

[modify] https://crrev.com/f2b280f227d364e58576c282958837289aa87b52/ash/test/ash_test_helper.cc
[modify] https://crrev.com/f2b280f227d364e58576c282958837289aa87b52/tools/valgrind/gtest_exclude/ash_unittests.gtest-memcheck.txt
[modify] https://crrev.com/f2b280f227d364e58576c282958837289aa87b52/ui/wm/core/cursor_manager.cc
[modify] https://crrev.com/f2b280f227d364e58576c282958837289aa87b52/ui/wm/core/cursor_manager.h