New issue
Advanced search Search tips

Issue 602477 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools: add a setting for console history

Project Member Reported by dgozman@chromium.org, Apr 11 2016

Issue description

Recent addition of autocompletions from history is painful for some developers.

See this thread for details: https://groups.google.com/forum/#!topic/google-chrome-developer-tools/zaSxnoa-1Jw

We can introduce a setting to turn this off.
 
Labels: TE-Verified-M52 TE-Verified-52.0.2709.0
Tested the same on win8.1,mac 10.11 and Linux 14.04 chrome version 52.0.2709.0 - observed the option "Autocomplete from history" in console as shown in the screenshot.
Screen Shot 2016-04-15 at 4.36.27 PM.png
177 KB View Download

Comment 3 by gov...@chromium.org, Apr 15 2016

This bug has been marked as M50 Stable Blocker. Please request a merge to M50 branch 2661 by applying "Merge-Request-50" label.
Labels: Merge-Request-50
Verified in mac canary 52.0.2709.0.

Comment 5 by tin...@google.com, Apr 15 2016

Labels: -Merge-Request-50 Merge-Review-50 Hotlist-Merge-Review
[Automated comment] Less than a week to go before stable on M50, we might already have a stable candidate build. Manual review required.

Comment 6 by gov...@chromium.org, Apr 15 2016

Labels: -Merge-Review-50 Merge-Approved-50
Approving Merge to M50 branch 2661 as it is already baked and verified in Canary. Please merge asap.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 15 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14d5b91e1f81715582feb0bb1f6b3199679c3bb1

commit 14d5b91e1f81715582feb0bb1f6b3199679c3bb1
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri Apr 15 21:21:08 2016

Merge to 2661 "[DevTools] Introduce a setting for console autocomplete from history."
> [DevTools] Introduce a setting for console autocomplete from history.
>
> BUG= 602477 
>
> Review URL: https://codereview.chromium.org/1875273002
>
> Cr-Commit-Position: refs/heads/master@{#386571}
(cherry picked from commit f7393c16130b5fd223aa4cb4ea41fcf672c623f8)
TBR=lushnikov

Review URL: https://codereview.chromium.org/1892303002 .

Cr-Commit-Position: refs/branch-heads/2661@{#587}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/14d5b91e1f81715582feb0bb1f6b3199679c3bb1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/14d5b91e1f81715582feb0bb1f6b3199679c3bb1/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/14d5b91e1f81715582feb0bb1f6b3199679c3bb1/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

Labels: Merge-Request-51 M-51
Requesting merge to M51.

Comment 9 by tin...@google.com, Apr 16 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 10 Deleted

Please merge your change to M51 branch 2704 ASAP (before 5:00 PM PST, today) so we can take it in for M51 last Dev release tomorrow.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec904764f5a03996130101a25e1b25bf2309ce2a

commit ec904764f5a03996130101a25e1b25bf2309ce2a
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Apr 18 20:40:34 2016

Merge to 2704 "[DevTools] Introduce a setting for console autocomplete from history."
> [DevTools] Introduce a setting for console autocomplete from history.
>
> BUG= 602477 
>
> Review URL: https://codereview.chromium.org/1875273002
>
> Cr-Commit-Position: refs/heads/master@{#386571}
(cherry picked from commit f7393c16130b5fd223aa4cb4ea41fcf672c623f8)
TBR=lushnikov

Review URL: https://codereview.chromium.org/1898923002 .

Cr-Commit-Position: refs/branch-heads/2704@{#106}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/ec904764f5a03996130101a25e1b25bf2309ce2a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/ec904764f5a03996130101a25e1b25bf2309ce2a/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/ec904764f5a03996130101a25e1b25bf2309ce2a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

Status: Fixed (was: Assigned)
Labels: TE-Verified-51.0.2704.19 TE-Verified-M51
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.4 using chrome version 51.0.2704.19.Able to use the Autocomplete from history option in dev tools.
Please find the attached screen shot for the same.

Adding TE-Verified label.

Thanks,

602477.png
125 KB View Download
Labels: TE-Verified-M50 TE-Verified-50.0.2661.86
Tested the same on win8.1,mac 10.11 and Linux 14.04 chrome version 50.0.2661.86 - observed the option "Autocomplete from history" in console of dev tools settings as shown in the screenshot.
Screen Shot 2016-04-20 at 11.35.20 AM.png
519 KB View Download
Components: Platform>DevTools>Authoring
Components: Platform>DevTools

Comment 19 by l...@chromium.org, Nov 16 2016

Cc: l...@chromium.org
 Issue 594152  has been merged into this issue.

Sign in to add a comment