New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602473 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix leaky tests

Project Member Reported by alokp@chromium.org, Apr 11 2016

Issue description

Quite a few tests leak TaskRunner::DeleteSoon tasks because MessageLoop does not delete the object if the message loop is destroyed before it has a chance to run. This is because the MessageLoop destructor does not run the pending tasks, just pops them off the work queue.

We now have a TestMessageLoop that flushes the underlying message loop upon destruction. We should use it to fix leaky tests.
 

Sign in to add a comment