New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602464 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 546838

Blocking:
issue 614588
issue 614589



Sign in to add a comment

[Cloud Print] Implement Cloud Print section

Project Member Reported by tbuck...@chromium.org, Apr 11 2016

Issue description

There are no mocks for Cloud Print.
 
Is this for MD settings? If so Andre is working on the printing section mocks. We can assign to him if that's the case.
Blocking: 546838
Components: Internals>Printing

Comment 4 by bettes@chromium.org, Apr 20 2016

Yes, this is for MD settings - converting our existing cloud print UI to MD. I was planning on this being just a 1:1 swap, but if there are any updates to the existing UI/feature requests/etc, then it should be noted here. 

Comment 5 by bettes@chromium.org, Apr 27 2016

Status: Started (was: Assigned)

Comment 6 by bettes@chromium.org, Apr 28 2016

Owner: ----
Status: Available (was: Started)
Summary: [Cloud Print] Implement mocks (was: [Cloud Print] Need mocks)
Ready for triage

Cloud print preview: 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Printing-cloud.png%3Fz=width

Card-specific spec
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-cards_printers-cloud.png%3Fz=width

WebUI subpage spec
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_structure-subpage.png
Screen Shot 2016-04-28 at 12.16.31 PM.png
46.8 KB View Download
Thanks Alan!

Sorry for the delayed reply on this thread. This convo seemed to have existed in a couple different places which is my mistake. We had talked about getting rid of the printers_subpage and just having the toplevel button go to the web app for Cloud Print.

I'm fine with just doing the conversion as you laid it out, but would be curious to see if Tom thinks differently.
Cc: bblietz@google.com
+bblietz for feedback on having Cloud Print settings become a link to the online management page.
Labels: Hotlist-MD-Settings-CloudPrint

Comment 10 by dbeam@chromium.org, May 24 2016

so, just to make sure: we're just linking out to chrome://devices for now, right?
Blocking: -546838
Blockedon: 546838
Summary: [Cloud Print] Implement Cloud Print section (was: [Cloud Print] Implement mocks)
Yes, we should link to the chrome://devices page. Note that the mocks still need to be updated with some additional info ( crbug.com/546838 ).
Please provide updated mocks when they are available.
Labels: OS-All
Labels: Hotlist-MD-DevBlocker
Blocking: 614588
Blocking: 614589
Labels: -Hotlist-MD-DevBlocker

Comment 21 by dbeam@chromium.org, May 27 2016

Owner: dbeam@chromium.org
Status: Started (was: Available)
Project Member

Comment 22 by bugdroid1@chromium.org, May 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70c95b1e895c633a514b21b6d96fef3abe866ec9

commit 70c95b1e895c633a514b21b6d96fef3abe866ec9
Author: dbeam <dbeam@chromium.org>
Date: Sat May 28 04:44:08 2016

MD Settings: implement printing page

Adds the section as per the mocks on the bug and a side-nav item/route

BUG= 602464 
R=dschuyler@chromium.org
TBR=michaelpg@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2017283002
Cr-Commit-Position: refs/heads/master@{#396635}

[modify] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/app/settings_strings.grdp
[modify] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/browser/resources/settings/advanced_page/advanced_page.html
[modify] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/browser/resources/settings/icons.html
[add] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/browser/resources/settings/printing_page/printing_page.html
[add] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/70c95b1e895c633a514b21b6d96fef3abe866ec9/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 23 by dbeam@chromium.org, May 31 2016

Status: Fixed (was: Started)
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbf308a144b4f4026d86d9826756c0c563c6eae2

commit bbf308a144b4f4026d86d9826756c0c563c6eae2
Author: dbeam <dbeam@chromium.org>
Date: Wed Jun 01 12:57:41 2016

MD Settings: closure compile the printing page

R=dschuyler@chromium.org
BUG= 602464 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOTRY=true

Review-Url: https://codereview.chromium.org/2025023003
Cr-Commit-Position: refs/heads/master@{#397117}

[modify] https://crrev.com/bbf308a144b4f4026d86d9826756c0c563c6eae2/chrome/browser/resources/settings/compiled_resources2.gyp
[add] https://crrev.com/bbf308a144b4f4026d86d9826756c0c563c6eae2/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp

Cc: -mshe...@chromium.org

Sign in to add a comment