New issue
Advanced search Search tips

Issue 602445 link

Starred by 2 users
Status: Fixed
Owner:
ikilpatrick@chromium.org
Closed: Apr 2016
Cc:
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 578252



Sign in to add a comment

Fix messageHandlerInMainThread to handle worklets properly.

Project Member Reported by ikilpatrick@chromium.org, Apr 11 2016 
Currently messagehandlerInMainThread assumes that the entered context will be a document.

If an error is thrown in a CSS Paint API callback for example the errors won't get reported to the devtools console.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e9a7753c76d9878338c6b916bdba9fa80796574

commit 8e9a7753c76d9878338c6b916bdba9fa80796574
Author: ikilpatrick <ikilpatrick@chromium.org>
Date: Thu Apr 14 19:09:35 2016

Make messageHandlerInMainThread support main-thread worklets.

This allows messageHandlerInMainThread to work with both a
window/document and worklet execution contexts.

This is needed for properly handling JS Errors in worklets.

BUG= 602445 

Review URL: https://codereview.chromium.org/1885833002

Cr-Commit-Position: refs/heads/master@{#387384}

[modify] https://crrev.com/8e9a7753c76d9878338c6b916bdba9fa80796574/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
[modify] https://crrev.com/8e9a7753c76d9878338c6b916bdba9fa80796574/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Comment 2 by ikilpatrick@chromium.org, Apr 29 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment