bad_message renderer shutdowns due to blobs through the roof |
||||||||
Issue descriptionStability.BadMessageTerminated.Content, value BDH_INVALID_OPERATIONS https://uma.googleplex.com/p/chrome/histograms/?endDate=04-10-2016&dayCount=1&histograms=Stability.BadMessageTerminated.Content&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial I need better data to get to the bottom of this. I suspect this is due to inc/dec refcounts after the blob has been destroyed.
,
Apr 12 2016
Removing merge request until we're in canary.
,
Apr 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/907439e58214fcdf4759296655ce650ad4f0eb86 commit 907439e58214fcdf4759296655ce650ad4f0eb86 Author: dmurph <dmurph@chromium.org> Date: Tue Apr 12 18:46:20 2016 [Blob] Better error reporting and histograms. The UMA for renderer crashes due to invalid blob messages is rather high. I'm adding better error reporting to figure out the issue. BUG= 602443 Review URL: https://codereview.chromium.org/1875223002 Cr-Commit-Position: refs/heads/master@{#386754} [modify] https://crrev.com/907439e58214fcdf4759296655ce650ad4f0eb86/content/browser/bad_message.h [modify] https://crrev.com/907439e58214fcdf4759296655ce650ad4f0eb86/content/browser/blob_storage/blob_dispatcher_host.cc [modify] https://crrev.com/907439e58214fcdf4759296655ce650ad4f0eb86/tools/metrics/histograms/histograms.xml
,
Apr 14 2016
I'd like the merge so metrics aren't messed up between milestones.
,
Apr 14 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 14 2016
Please merge your change by Friday 5:00 PM PST so we can take it for next week release.
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f236d16d5b2484d5f724afed48044d04659f07b3 commit f236d16d5b2484d5f724afed48044d04659f07b3 Author: Daniel Murphy <dmurph@chromium.org> Date: Thu Apr 14 19:41:28 2016 [Blob] Better error reporting and histograms. The UMA for renderer crashes due to invalid blob messages is rather high. I'm adding better error reporting to figure out the issue. BUG= 602443 Review URL: https://codereview.chromium.org/1875223002 Cr-Commit-Position: refs/heads/master@{#386754} (cherry picked from commit 907439e58214fcdf4759296655ce650ad4f0eb86) Review URL: https://codereview.chromium.org/1888453005 . Cr-Commit-Position: refs/branch-heads/2704@{#58} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/f236d16d5b2484d5f724afed48044d04659f07b3/content/browser/bad_message.h [modify] https://crrev.com/f236d16d5b2484d5f724afed48044d04659f07b3/content/browser/blob_storage/blob_dispatcher_host.cc [modify] https://crrev.com/f236d16d5b2484d5f724afed48044d04659f07b3/tools/metrics/histograms/histograms.xml
,
Apr 18 2016
Note: it's unclear whether this is an error with the new blob system, or there was already flakiness here that we just weren't detecting due to how we just ignored invalid messages.
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a00379794f50019c7047c83e537803b7ba2b11ea commit a00379794f50019c7047c83e537803b7ba2b11ea Author: dmurph <dmurph@chromium.org> Date: Thu Apr 21 00:22:40 2016 [Blob] Added error reporting metrics to invalid message errors. This helps us get to the bottom of where the invalid blob refcount and url calls are. It's unclear whether these are new or if they've always occurred, as we used to ignore these messages. R=kinuko@chromium.org, mpearson@chromium.org BUG= 602443 Review URL: https://codereview.chromium.org/1893293006 Cr-Commit-Position: refs/heads/master@{#388626} [modify] https://crrev.com/a00379794f50019c7047c83e537803b7ba2b11ea/content/browser/blob_storage/blob_dispatcher_host.cc [modify] https://crrev.com/a00379794f50019c7047c83e537803b7ba2b11ea/tools/metrics/histograms/histograms.xml
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0440e2b94ca72b49ce5a2bc45f814033b092d1f commit e0440e2b94ca72b49ce5a2bc45f814033b092d1f Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Apr 29 21:23:40 2016 [Blob] Added error reporting metrics to invalid message errors. This helps us get to the bottom of where the invalid blob refcount and url calls are. It's unclear whether these are new or if they've always occurred, as we used to ignore these messages. R=kinuko@chromium.org, mpearson@chromium.org BUG= 602443 , 607698 Review URL: https://codereview.chromium.org/1893293006 Cr-Commit-Position: refs/heads/master@{#388626} (cherry picked from commit a00379794f50019c7047c83e537803b7ba2b11ea) Review URL: https://codereview.chromium.org/1940623002 . Cr-Commit-Position: refs/branch-heads/2704@{#317} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/e0440e2b94ca72b49ce5a2bc45f814033b092d1f/content/browser/blob_storage/blob_dispatcher_host.cc [modify] https://crrev.com/e0440e2b94ca72b49ce5a2bc45f814033b092d1f/tools/metrics/histograms/histograms.xml
,
Sep 14 2016
,
Jun 15 2018
,
Jun 15 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dmu...@chromium.org
, Apr 12 2016