New issue
Advanced search Search tips

Issue 602443 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

bad_message renderer shutdowns due to blobs through the roof

Project Member Reported by dmu...@chromium.org, Apr 11 2016

Issue description

Stability.BadMessageTerminated.Content, value BDH_INVALID_OPERATIONS

https://uma.googleplex.com/p/chrome/histograms/?endDate=04-10-2016&dayCount=1&histograms=Stability.BadMessageTerminated.Content&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

I need better data to get to the bottom of this. I suspect this is due to inc/dec refcounts after the blob has been destroyed.
 

Comment 1 by dmu...@chromium.org, Apr 12 2016

Labels: Merge-Request-51
Merge requested for this patch:
https://codereview.chromium.org/1875223002/
(it's going through the CQ now)

I'd like the merge so metrics aren't messed up between milestones.

Comment 2 by dmu...@chromium.org, Apr 12 2016

Labels: -Merge-Request-51
Removing merge request until we're in canary.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/907439e58214fcdf4759296655ce650ad4f0eb86

commit 907439e58214fcdf4759296655ce650ad4f0eb86
Author: dmurph <dmurph@chromium.org>
Date: Tue Apr 12 18:46:20 2016

[Blob] Better error reporting and histograms.

The UMA for renderer crashes due to invalid blob messages
is rather high. I'm adding better error reporting to figure
out the issue.

BUG= 602443 

Review URL: https://codereview.chromium.org/1875223002

Cr-Commit-Position: refs/heads/master@{#386754}

[modify] https://crrev.com/907439e58214fcdf4759296655ce650ad4f0eb86/content/browser/bad_message.h
[modify] https://crrev.com/907439e58214fcdf4759296655ce650ad4f0eb86/content/browser/blob_storage/blob_dispatcher_host.cc
[modify] https://crrev.com/907439e58214fcdf4759296655ce650ad4f0eb86/tools/metrics/histograms/histograms.xml

Comment 4 by dmu...@chromium.org, Apr 14 2016

Labels: Merge-Request-51
I'd like the merge so metrics aren't messed up between milestones.


Comment 5 by tin...@google.com, Apr 14 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 6 by gov...@chromium.org, Apr 14 2016

Please merge your change by Friday 5:00 PM PST so we can take it for next week release.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 14 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f236d16d5b2484d5f724afed48044d04659f07b3

commit f236d16d5b2484d5f724afed48044d04659f07b3
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu Apr 14 19:41:28 2016

[Blob] Better error reporting and histograms.

The UMA for renderer crashes due to invalid blob messages
is rather high. I'm adding better error reporting to figure
out the issue.

BUG= 602443 

Review URL: https://codereview.chromium.org/1875223002

Cr-Commit-Position: refs/heads/master@{#386754}
(cherry picked from commit 907439e58214fcdf4759296655ce650ad4f0eb86)

Review URL: https://codereview.chromium.org/1888453005 .

Cr-Commit-Position: refs/branch-heads/2704@{#58}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/f236d16d5b2484d5f724afed48044d04659f07b3/content/browser/bad_message.h
[modify] https://crrev.com/f236d16d5b2484d5f724afed48044d04659f07b3/content/browser/blob_storage/blob_dispatcher_host.cc
[modify] https://crrev.com/f236d16d5b2484d5f724afed48044d04659f07b3/tools/metrics/histograms/histograms.xml

Comment 8 by dmu...@chromium.org, Apr 18 2016

Note: it's unclear whether this is an error with the new blob system, or there was already flakiness here that we just weren't detecting due to how we just ignored invalid messages.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a00379794f50019c7047c83e537803b7ba2b11ea

commit a00379794f50019c7047c83e537803b7ba2b11ea
Author: dmurph <dmurph@chromium.org>
Date: Thu Apr 21 00:22:40 2016

[Blob] Added error reporting metrics to invalid message errors.

This helps us get to the bottom of where the invalid blob refcount
and url calls are. It's unclear whether these are new or if they've
always occurred, as we used to ignore these messages.

R=kinuko@chromium.org, mpearson@chromium.org
BUG= 602443 

Review URL: https://codereview.chromium.org/1893293006

Cr-Commit-Position: refs/heads/master@{#388626}

[modify] https://crrev.com/a00379794f50019c7047c83e537803b7ba2b11ea/content/browser/blob_storage/blob_dispatcher_host.cc
[modify] https://crrev.com/a00379794f50019c7047c83e537803b7ba2b11ea/tools/metrics/histograms/histograms.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0440e2b94ca72b49ce5a2bc45f814033b092d1f

commit e0440e2b94ca72b49ce5a2bc45f814033b092d1f
Author: Daniel Murphy <dmurph@chromium.org>
Date: Fri Apr 29 21:23:40 2016

[Blob] Added error reporting metrics to invalid message errors.

This helps us get to the bottom of where the invalid blob refcount
and url calls are. It's unclear whether these are new or if they've
always occurred, as we used to ignore these messages.

R=kinuko@chromium.org, mpearson@chromium.org
BUG= 602443 , 607698 

Review URL: https://codereview.chromium.org/1893293006

Cr-Commit-Position: refs/heads/master@{#388626}
(cherry picked from commit a00379794f50019c7047c83e537803b7ba2b11ea)

Review URL: https://codereview.chromium.org/1940623002 .

Cr-Commit-Position: refs/branch-heads/2704@{#317}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/e0440e2b94ca72b49ce5a2bc45f814033b092d1f/content/browser/blob_storage/blob_dispatcher_host.cc
[modify] https://crrev.com/e0440e2b94ca72b49ce5a2bc45f814033b092d1f/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Components: Blink>Storage>FileAPI
Components: -Blink>FileAPI

Sign in to add a comment