New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602438 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Delete Layer Impl properties that are used only for property tree building

Project Member Reported by jaydasika@chromium.org, Apr 11 2016

Issue description

As we don't build properties on compositor, we need not push layer properties that are only used during property trees building from layer to layer_impl. We should also be able to delete them on layer impl or make sure that they are used only in tests. 
One example of is transform_origin.
 

Comment 1 by ajuma@chromium.org, Apr 11 2016

How about putting them into a separate struct that only gets instantiated in tests? Then non-test LayerImpls don't need to waste space for these.
We should totally do that. 
A more exhaustive list of properties that we push but don't actually use on the impl side : 
transform_origin, double_sided ,force_render_surface, main_thread_scrolling_reasons, is_root_for_isolated_group, maybe position (only
root’s position is used), is_container_for_fixed_position_layers, 
position_constraint, should_flatten_transform, transform_is_invertible, 
num_descendants_that_draw_content, scroll_parent (need scroll_children though, 
so we should probably keep this for consistency), clip_parent, clip_children

Owner: jaydasika@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38be7a828db674dd70d332c62f313b6170bcbd01

commit 38be7a828db674dd70d332c62f313b6170bcbd01
Author: jaydasika <jaydasika@chromium.org>
Date: Thu Apr 21 16:07:06 2016

cc :  Stop pushing transform origin from Layer and LayerImpl.

This CL also adds a new LayerImplTestProperties struct and moves the
LayerImpl's transform origin to that.

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1908593002

Cr-Commit-Position: refs/heads/master@{#388782}

[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/layers/layer.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/layers/layer_impl.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/layers/layer_impl.h
[add] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/layers/layer_utils_unittest.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/test/layer_tree_host_common_test.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/test/layer_tree_host_common_test.h
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/38be7a828db674dd70d332c62f313b6170bcbd01/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d

commit 6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Apr 22 21:56:36 2016

cc : Stop pushing properties not used on compositor to compositor. (2)

This CL moves double_sided and force_render_surface from LayerImpl to
LayerImplTestProperties and also deletes non-test calls to
SetForceRenderSurface on Layer.

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1912893002

Cr-Commit-Position: refs/heads/master@{#389256}

[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/blink/web_layer_impl.h
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/layer.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/layer.h
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/layer_impl.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/layer_impl.h
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/layer_iterator_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/layer_position_constraint_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/layer_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/nine_patch_layer_impl_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/picture_layer_impl_perftest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/solid_color_layer_impl_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/ui_resource_layer_impl_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/test/layer_tree_host_common_test.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/tiles/tile_manager_perftest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/layer_tree_host_pixeltest_blending.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/layer_tree_host_pixeltest_filters.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/layer_tree_host_unittest_occlusion.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/occlusion_tracker_perftest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/third_party/WebKit/public/platform/WebLayer.h
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/ui/compositor/layer.cc
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/ui/compositor/layer.h
[modify] https://crrev.com/6b5a32bf6cabef2f242db43bb483b2e9a94b9c8d/ui/compositor/layer_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64

commit ca2605edd4851f7b7cae85e5c0b1f118a16dcb64
Author: jaydasika <jaydasika@chromium.org>
Date: Sat Apr 23 02:52:52 2016

cc : Stop pushing properties not used by LayerImpl to LayerImpl (3)

This CL removes pushing properties :
is_root_for_isolated_group,
is_container_for_fixed_pos_layer,
position_constraint,
should_flatten_transform,
transform_is_invertible,
num_descendants_that_draw_content

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1918593002

Cr-Commit-Position: refs/heads/master@{#389349}

[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_impl.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_impl.h
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/test/layer_tree_host_common_test.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/test/layer_tree_host_common_test.h
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64

commit ca2605edd4851f7b7cae85e5c0b1f118a16dcb64
Author: jaydasika <jaydasika@chromium.org>
Date: Sat Apr 23 02:52:52 2016

cc : Stop pushing properties not used by LayerImpl to LayerImpl (3)

This CL removes pushing properties :
is_root_for_isolated_group,
is_container_for_fixed_pos_layer,
position_constraint,
should_flatten_transform,
transform_is_invertible,
num_descendants_that_draw_content

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1918593002

Cr-Commit-Position: refs/heads/master@{#389349}

[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_impl.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_impl.h
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/layers/layer_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/test/layer_tree_host_common_test.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/test/layer_tree_host_common_test.h
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/ca2605edd4851f7b7cae85e5c0b1f118a16dcb64/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e

commit 1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e
Author: jaydasika <jaydasika@chromium.org>
Date: Thu Apr 28 01:54:56 2016

cc : Stop pushing properties not used by LayerImpl to LayerImpl (4)

This CL removes pushing properties :
clip_parent, chil_children, scroll parent, scroll_children

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1924933002
Cr-Commit-Position: refs/heads/master@{#390273}

[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/BUILD.gn
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/cc.gyp
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/layers/layer.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/layers/layer_impl.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/layers/layer_impl.h
[add] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/trees/tree_synchronizer.cc
[modify] https://crrev.com/1c0a27d4d58e2d92b4ca60cf8ddc48272e34304e/cc/trees/tree_synchronizer_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc66cfb4ddd165a3d041c13eb73f46447b4762ff

commit fc66cfb4ddd165a3d041c13eb73f46447b4762ff
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Jun 10 04:34:22 2016

cc : Move LayerImpl::children to test properties

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2053193002
Cr-Commit-Position: refs/heads/master@{#399093}

[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_impl.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_impl.h
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_list_iterator.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_utils_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/nine_patch_layer_impl.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/nine_patch_layer_impl.h
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/ui_resource_layer_impl.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/ui_resource_layer_impl.h
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/test/layer_tree_json_parser_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/test/test_layer_tree_host_base.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/property_tree_builder.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc66cfb4ddd165a3d041c13eb73f46447b4762ff

commit fc66cfb4ddd165a3d041c13eb73f46447b4762ff
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Jun 10 04:34:22 2016

cc : Move LayerImpl::children to test properties

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2053193002
Cr-Commit-Position: refs/heads/master@{#399093}

[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_impl.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_impl.h
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_list_iterator.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/layer_utils_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/nine_patch_layer_impl.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/nine_patch_layer_impl.h
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/ui_resource_layer_impl.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/layers/ui_resource_layer_impl.h
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/test/layer_tree_json_parser_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/test/test_layer_tree_host_base.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff/cc/trees/property_tree_builder.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f419bf7a73a54108381698ad19e951e80ae94c87

commit f419bf7a73a54108381698ad19e951e80ae94c87
Author: jaydasika <jaydasika@chromium.org>
Date: Wed Jun 15 10:21:21 2016

cc : Move LayerImpl::parent to test properties

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2053983003
Cr-Commit-Position: refs/heads/master@{#399875}

[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/layers/layer_impl.cc
[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/layers/layer_impl.h
[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/layers/layer_list_iterator.cc
[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87/cc/trees/property_tree_builder.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89f7b5aa70aefa623f67b4adf8964308aadc9b82

commit 89f7b5aa70aefa623f67b4adf8964308aadc9b82
Author: jaydasika <jaydasika@chromium.org>
Date: Wed Jun 22 02:08:39 2016

cc: Move LayerImpl::AddChild and RemoveChild to LayerImplTestProperties

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2084233002
Cr-Commit-Position: refs/heads/master@{#401163}

[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/input/scrollbar_animation_controller_linear_fade_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/input/scrollbar_animation_controller_thinning_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/layer_impl.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/layer_impl.h
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/layer_iterator_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/layer_list_iterator_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/layer_utils_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/render_surface_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/test/layer_test_common.h
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/test/layer_tree_json_parser_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/test/test_layer_tree_host_base.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/tiles/tile_manager_perftest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/89f7b5aa70aefa623f67b4adf8964308aadc9b82/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e57ef9da5138f83571aa273a8ac7f8684f950fb4

commit e57ef9da5138f83571aa273a8ac7f8684f950fb4
Author: jaydasika <jaydasika@chromium.org>
Date: Wed Jun 22 14:32:55 2016

cc: Remove LayerTreeImpl::root_layer usage outside tests

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2080703005
Cr-Commit-Position: refs/heads/master@{#401276}

[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/debug/debug_rect_history.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/debug/debug_rect_history.h
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/test/layer_tree_json_parser_unittest.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/layer_tree_host_unittest_animation.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/occlusion_tracker.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/property_tree.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/tree_synchronizer.cc
[modify] https://crrev.com/e57ef9da5138f83571aa273a8ac7f8684f950fb4/cc/trees/tree_synchronizer.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf1875afad559e02cb26093ccbba79bbcfa9fcac

commit bf1875afad559e02cb26093ccbba79bbcfa9fcac
Author: jaydasika <jaydasika@chromium.org>
Date: Tue Jun 28 03:39:59 2016

cc: Clean up root_layer code in LTI

This CL :
1) Stop setting root_layer in
   LTI::SetRootLayerForLayerList and renames it to
   OnCanDrawStateChangedForTree.

2) Add a new LTI::SetRootLayerForLayerListForTesting

3) Make LTI::root_layer() return layer_list[0]

4) Rename : root_layer_ -> root_layer_for_testing_,
            SetRootLayer -> SetRootLayerForTesting,
            root_layer() -> root_layer_for_testing()

BUG= 602438 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2080223010
Cr-Commit-Position: refs/heads/master@{#402390}

[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/input/scrollbar_animation_controller_linear_fade_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/input/scrollbar_animation_controller_thinning_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/heads_up_display_layer_impl_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/layer_iterator_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/layer_list_iterator_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/layer_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/layer_utils_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/picture_layer_impl_perftest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/render_surface_impl_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/render_surface_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/test/fake_layer_tree_host.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/test/layer_test_common.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/test/layer_test_common.h
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/test/layer_tree_json_parser_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/test/test_layer_tree_host_base.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_common_perftest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_unittest_animation.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_unittest_damage.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_unittest_occlusion.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_unittest_picture.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_unittest_scroll.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_host_unittest_video.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/occlusion_tracker_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/tree_synchronizer.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/cc/trees/tree_synchronizer_unittest.cc
[modify] https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment